Commit Graph

6 Commits

Author SHA1 Message Date
Evan Bradley 94199c8952
[chore][docs/rfc] Add RFC on confmap Provider configuration goals (#10776)
#### Description

This is a stripped-down version of
https://github.com/open-telemetry/opentelemetry-collector/pull/10121
that eschews implementation details in favor of answering questions
about _what_ we want to achieve instead of how we will achieve it. A
section from that PR has been reproduced here to cover a few approaches
for future discussions.
2024-08-07 10:43:12 -07:00
Pablo Baeyens 0001db2759
[confmap] Store original string in confmap.Conf (#10618)
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description

<!-- Issue number if applicable -->

- Adds new `expandedValue` struct that holds the original string
representation if available for values resolved from a provider.
- Removes any mention of `expandedValue` in the public API by adding a
`sanitize` step before returning any `Get`s or `ToStringMap`s.
- Adds new decoding hook that checks if the target field is of `string`
type and uses the string representation in that case.



#### Link to tracking issue

Fixes #10605, Fixes #10405, Fixes #10659

<!--Describe what testing was performed and which tests were added.-->
#### Testing

<!--Describe the documentation added.-->

This changes the behavior in some cases, I update the test cases.

#### Documentation

<!--Please delete paragraphs that you did not use before submitting.-->

| ENV value | ${ENV} before unification | ${ENV} in v0.105.0 (also
${env:ENV} before unification) | Value after this PR |

|----------------------------|----------------------------|---------------------------------------------------------|----------------------------|
| foo\nbar | foo\nbar | foo bar | foo\nbar |
| 1111:1111:1111:1111:1111:: | 1111:1111:1111:1111:1111:: | **Error** |
1111:1111:1111:1111:1111:: |
| "0123" | "0123" | 0123 | "0123" |
2024-07-25 10:06:08 +02:00
Damien Mathieu c60fb1dad2
RFC: Experimental profiling (#10375)
#### Description

This is an RFC discussing the proposed solution for adding the profiling
signal.
Follows
https://github.com/open-telemetry/opentelemetry-collector/issues/10207

PoC:
https://github.com/open-telemetry/opentelemetry-collector/pull/10307

cc @open-telemetry/profiling-triagers
@open-telemetry/profiling-approvers
@open-telemetry/profiling-maintainers
cc @open-telemetry/collector-approvers

---------

Co-authored-by: Christos Kalkanis <christos.kalkanis@elastic.co>
Co-authored-by: Pablo Baeyens <pablo.baeyens@datadoghq.com>
2024-06-28 10:25:54 +02:00
Tyler Helmuth 227101d6d4
[otelcol] rfc for how to log during startup (#10066)
#### Description

This is an RFC to help us decide how we want `otelcol` to provide a
logger before the primary logger is created. As we discuss I will update
the doc. Before this is merged we should have decided on a solution and
the Accepted Solution section must be updated.

Related to
https://github.com/open-telemetry/opentelemetry-collector/pull/10056

#### Link to tracking issue
This unblocks:
- https://github.com/open-telemetry/opentelemetry-collector/issues/9162
- https://github.com/open-telemetry/opentelemetry-collector/issues/5615

---------

Co-authored-by: Pablo Baeyens <pbaeyens31+github@gmail.com>
Co-authored-by: Evan Bradley <11745660+evan-bradley@users.noreply.github.com>
2024-05-06 08:48:14 -07:00
Pablo Baeyens fe582df553
[docs/rfc] RFC about environment variables (#9854)
**Description:** Adds an RFC about how environment variable resolution
should work
**Link to tracking Issue:** Fixes #9515, relates to:
- #8215
- #8565
- #9162
- #9531 
- #9532

---------

Co-authored-by: Alex Boten <223565+codeboten@users.noreply.github.com>
Co-authored-by: Evan Bradley <11745660+evan-bradley@users.noreply.github.com>
2024-04-30 14:27:17 -07:00
Pablo Baeyens 2e9ce26ed6
[chore][docs] Move RFC to a new RFCs folder (#9828)
**Description:** Some housekeeping to organize the `docs` folder. I
intend to file a new RFC-ish soon.

**Link to tracking Issue:** Fixes #8893
2024-03-27 10:20:59 +01:00