The order in which Consume* and Shutdown get handled for batch processor is inconsistent when called back to back. This results in the number of items getting passed through to be inconsistent. To unblock tests and maintain coverage, the tests only check if some data got through and the batching size is 1.
Issue #1070 has been opened to properly fix the test and ensure the total number of items sent is accounted for after shutdown has been invoked.
**Link to tracking Issue:** Fixes issue #1066 and #1069
**Testing:** Run each of the test 100 times and no test failures.
We previously used string in the codebase to represent component type
(as it is known to factories and referred to in the config).
Now we have configmodels.Type alias that provides stronger compile-time
type checks.
This is a breaking change for components but fixing the components is easy.
Resolves: https://github.com/open-telemetry/opentelemetry-collector/issues/762
Elapsed time measurement was set incorrectly. Timeout to compare elapsed time against is triggered with newBatchProcessor, move it below the timer start.
New internal data structure allows to batch together traces from different resources. This simplify batching a lot. This commit removes most of the functionality for handling many batches per node and uses only one batch with one ticker.
* initial switch to circleci
* update docs
* test packages in batches of 10.
* update golangci to have go1.14 vet support
* roll back go.mod, move to separate pull.
* allow running longer to avoid circleci timeout.
* further increase timeout.
* further increase timeout.
* fix data race, adjust timeout.
* 10 min timeout (will decrease with parallelism later)
* batch/parallelize all test executions.
* modularize circleci
* add loadtest tools
* optimize running time
* address review feedback
As we are preparing for Beta release we want to cleanup publicly exported
types and interfaces and do all necessary refactoring and breaking changes
now, before the Beta release. We will have a lot less leeway for breaking
changes after the Beta release.
Component related type declarations are now all in the `component` package.
This makes it possible for the interfaces to reference each other. This
was were very restricted earlier because component interfaces were in 5
different packages and many proposals were impossible to implement because
they would result in circular dependencies between packages.
(An example upcoming new capability that is enabled by this refactoring
is for components to query the Host for other components and for factories).
List of changes in this commit:
- Move all factory interfaces and component interfaces to component package.
- Rename old factories and components interfaces to use "Old" suffix for clarity.
- Eliminate forced checks that components implement factories. This is already
enforced by the compiler when the factory is added to the Defaults() and
was unnecessary code.
- Eliminated some unnecessary codes (removed overall over 200 lines).
- Run `go mod tidy` on testbed.
Warning: this is a breaking change to publicly exported types and function
signatures. We announced that a breaking change is comming. Once we agree
to merge this commit we will need to announce the exact list of changes
and guide component authors to modify their components accordingly.
Future changes:
- Once all components are migrated to the new internal representation,
delete all "Old"-suffixed definitions. This will likely be done while
we are still in Beta phase, before the Stable release.
Initial updates to migrate processor metrics to obsreport package, ie.: the new metrics.
Cleaned-up a bit some of the processor metrics and spelled out the rule names for new metrics.
Related to https://github.com/open-telemetry/opentelemetry-collector/issues/141
Testing: Added test for the processor common metrics, validated manually that legacy metrics were still working
This change fixes inconsistencies in component interfaces. Motivation:
- Uniformness results in reduction of code that currently has to
deal with differences.
- Processor.Start is missing and is important for allowing processors
to communicate with the Host.
What's changed:
- Introduced Component interface.
- Unified Host interface.
- Added a Start function to processors (via Component interface).
- Start/Shutdown is now called for Processors from service start/shutdown.
- Receivers, Exporters, Processors, Extensions now embed Component interface.
- Replaced StartTraceReception/StartMetricsReception by single Start function for receivers.
- Replaced StopTraceReception/StopMetricsReception by single Shutdown function for receivers.
Note: before merging this we need to announce the change in Gitter since it
breaks existing implementations in contrib (although the fix is easy).
Resolves#477Resolves#262
* Integrate golangci-lint to easily extend linting capabilities later
- that's why separate fmt, vet, etc. targets are dropped and all are run through umbrella lint target, golangci-lint.
* Additionally enabled scopelint and fixed one issue
- it's disabled for test files because it gives false positive - https://github.com/kyoh86/scopelint/issues/4.
* Misspell on go files are also run by golangci-lint, that's why `ALL_SRC_AND_DOC` is simplified to `ALL_DOC`.
Fixes#342
For historical reasons the tag associated to the name of a processor was still named "exporter", changed that to "processor". Added also the name of the queued retry instance to be used as the name of the processor.
Bogdan Drutu
Pavol Loffay
Juraci Paixão Kröhling
Akash Suresh
Constance Caramanolis
Bruno Garcia
James Bebbington
Tigran Najaryan
Dmitrii Anoshin
Liz Fong-Jones
Paulo Janotti
ferhat elmas
Paulo Janotti
Steve Flanders