Commit Graph

335 Commits

Author SHA1 Message Date
OpenTelemetry Bot 095b183fd8
[chore] Prepare release v1.22.0/v0.116.0 (#11910)
The following commands were run to prepare this release:
- make chlog-update VERSION=v1.22.0/v0.116.0
- make prepare-release PREVIOUS_VERSION=1[.]21[.]0
RELEASE_CANDIDATE=1.22.0 MODSET=stable
- make prepare-release PREVIOUS_VERSION=0[.]115[.]0
RELEASE_CANDIDATE=0.116.0 MODSET=beta
2024-12-16 21:25:57 +00:00
Dmitrii Anoshin e9bc4bde92
Deprecate connectorprofiles module in favor of xconnector (#11887)
to allow adding more experimental data types.

Updates
https://github.com/open-telemetry/opentelemetry-collector/issues/11778
2024-12-14 15:04:34 +00:00
Dmitrii Anoshin 97f6c3a0aa
Deprecate exporterhelperprofiles module in favor of xexporterhelper (#11890)
to allow adding more experimental data types.

Updates
https://github.com/open-telemetry/opentelemetry-collector/issues/11778
2024-12-14 04:39:20 +00:00
Dmitrii Anoshin c6c249dd41
Deprecate consumererrorprofiles module in favor of xconsumererror (#11892)
to allow adding more experimental data types.

Updates
https://github.com/open-telemetry/opentelemetry-collector/issues/11778
2024-12-14 00:49:38 +00:00
Dmitrii Anoshin 9206c68ec2
Deprecate pipelineprofiles module in favor of xpipeline (#11888)
to allow adding more experimental data types.

Updates
https://github.com/open-telemetry/opentelemetry-collector/issues/11778
2024-12-13 23:23:06 +00:00
Dmitrii Anoshin 0d94e09e70
Deprecate exporterprofiles module in favor of xexporter (#11885)
to allow adding more experimental data types.

Updates
https://github.com/open-telemetry/opentelemetry-collector/issues/11778
2024-12-13 21:56:43 +00:00
Dmitrii Anoshin 324f5a22d6
Deprecate processorprofiles module in favor of xprocessor (#11883)
to allow adding more experimental data types

Updates
https://github.com/open-telemetry/opentelemetry-collector/issues/11778
2024-12-13 21:36:25 +00:00
Dmitrii Anoshin 4593ba7de2
Deprecate receiverprofiles module in favor of xreceiver (#11876)
to allow adding more experimental data types

Updates
https://github.com/open-telemetry/opentelemetry-collector/issues/11778
2024-12-13 18:50:00 +00:00
Dmitrii Anoshin 63d83d5e79
Deprecate consumerprofiles module in favor of xconsumer (#11779)
To allow adding more experimental data types. First step towards
https://github.com/open-telemetry/opentelemetry-collector/issues/11778
2024-12-12 22:09:02 +00:00
Matthieu MOREL 808fb7c260
[chore]: enable gofumpt linter in client, cmd, component, config and confmap (#11587)
#### Description

[gofumpt](https://golangci-lint.run/usage/linters/#gofumpt) is a
stricter format than gofmt, while being backwards compatible.

Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2024-12-11 08:50:57 +00:00
OpenTelemetry Bot a65008e7ef
[chore] Prepare release v1.21.0/v0.115.0 (#11788)
The following commands were run to prepare this release:
- make chlog-update VERSION=v1.21.0/v0.115.0
- make prepare-release PREVIOUS_VERSION=1[.]20[.]0
RELEASE_CANDIDATE=1.21.0 MODSET=stable
- make prepare-release PREVIOUS_VERSION=0[.]114[.]0
RELEASE_CANDIDATE=0.115.0 MODSET=beta
2024-12-03 13:22:05 -08:00
Vihas Makwana 97929ac9f7
[chore]: update to latest major version (#11781)
Unblocks
https://github.com/open-telemetry/opentelemetry-collector/pull/11775.
2024-12-02 10:12:15 -08:00
Jade Guiton f2e05b5089
Make `extension/auth/authtest` into its own module (#11705)
#### Description

Turns the `go.opentelemetry.io/collector/extension/auth/authtest`
package into its own module

#### Link to tracking issue
Resolves #11465
2024-11-20 09:44:40 -07:00
Bogdan Drutu 9d2685f404
Deprecate scraperhelper.Scraper in favor of scraper.Metrics (#11682)
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
Co-authored-by: Yang Song <songy23@users.noreply.github.com>
2024-11-19 13:09:27 -08:00
OpenTelemetry Bot 43fbb04cea
[chore] Prepare release v1.20.0/v0.114.0 (#11692)
The following commands were run to prepare this release:
- make chlog-update VERSION=v1.20.0/v0.114.0
- make prepare-release PREVIOUS_VERSION=1[.]19[.]0
RELEASE_CANDIDATE=1.20.0 MODSET=stable
- make prepare-release PREVIOUS_VERSION=0[.]113[.]0
RELEASE_CANDIDATE=0.114.0 MODSET=beta

---------

Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
Co-authored-by: Alex Boten <223565+codeboten@users.noreply.github.com>
2024-11-18 11:42:17 -08:00
John L. Peterson (Jack) 1d87709aea
[chore] rename confmap modules to ConfmapConverters and ConfmapProviders (#11678)
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description
change name in templates and cmd/builder to refer to Providers and
Converters as ConfmapProviders and ConfmapConverters
<!-- Issue number if applicable -->
#### Link to tracking issue
as requested here:
https://github.com/open-telemetry/opentelemetry-collector/pull/11653#discussion_r1841202325

<!--Describe what testing was performed and which tests were added.-->
#### Testing
existing tests should cover this
<!--Describe the documentation added.-->
#### Documentation
none, internal change and no new code/api
<!--Please delete paragraphs that you did not use before submitting.-->
2024-11-14 12:25:16 -08:00
Jade Guiton 3fe42eba80
Make `extensiontest` into its own module (#11629)
#### Description

Turns the `go.opentelemetry.io/collector/extension/extensiontest`
package into its own module

#### Link to tracking issue

Resolves #11463
2024-11-14 08:16:39 -08:00
John L. Peterson (Jack) de35049c01
Add local module replacement to ocb template (#11653)
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description
Adds ability to replace Providers and Converters with local paths when
building custom collector in ocb
<!-- Issue number if applicable -->
#### Link to tracking issue
Closes #11649

<!--Describe what testing was performed and which tests were added.-->
#### Testing
local build of ocb with locally downloaded converter and provider (can
add this type of test to github actions if others think it is necessary)
<!--Describe the documentation added.-->
#### Documentation
.chloggen file
<!--Please delete paragraphs that you did not use before submitting.-->

---------

Co-authored-by: Bogdan Drutu <bogdandrutu@gmail.com>
2024-11-14 08:09:50 -08:00
Jade Guiton f0fb20df0e
Make `componenttest` into its own module (#11615)
#### Description

Turn the `go.opentelemetry.io/collector/component/componenttest` package
into its own module

#### Link to tracking issue
Resolves #11464
2024-11-07 17:31:30 +01:00
Bogdan Drutu 52848cca99
[chore] Small refactoring in builder config functions (#11617)
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
2024-11-07 06:54:14 -08:00
John L. Peterson (Jack) 9cc15c5596
add confmap.Converter an option for ocb build manifest/template (#11584)
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description
Adds ability to add confmap.Converter as a module to build/import with
ocb

<!-- Issue number if applicable -->
#### Link to tracking issue
Fixes
https://github.com/open-telemetry/opentelemetry-collector/issues/11582

<!--Describe what testing was performed and which tests were added.-->
#### Testing
Added validation tests for pulling the converter go module in
cmd/builder template/build process.
Additionally, I took the default otelcorecol manifest, added a
`converters` section, and added the `expandconverter` and verified that
a custom collector both built, started up, and exited successfully.

<!--Describe the documentation added.-->
#### Documentation
Changelog file added. I can also update the documentation in cmd/builder
README if community thinks that is necessary. Since `confmap.Converter`
is not yet registered in the OTel registry and does not have any
existing components published save for the deprecated `expandconverter`
I was not certain if anything further than a changelog was necessary.
<!--Please delete paragraphs that you did not use before submitting.-->

---------

Co-authored-by: Andrzej Stencel <andrzej.stencel@elastic.co>
2024-11-06 09:34:50 -08:00
OpenTelemetry Bot 3da496be53
[chore] Prepare release v1.19.0/v0.113.0 (#11609)
The following commands were run to prepare this release:
- make chlog-update VERSION=v1.19.0/v0.113.0
- make prepare-release PREVIOUS_VERSION=1[.]18[.]0
RELEASE_CANDIDATE=1.19.0 MODSET=stable
- make prepare-release PREVIOUS_VERSION=0[.]112[.]0
RELEASE_CANDIDATE=0.113.0 MODSET=beta
2024-11-05 11:52:29 -08:00
Bogdan Drutu 084aa63173
Update builder default providers to lastest stable (#11566)
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
2024-11-04 16:10:12 -08:00
Bogdan Drutu 27bcaf6129
Apply default values before we unmarshal the config, allows not using pointers (#11596)
Skip changelog since this is not visible to our users.

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
2024-11-04 15:19:12 -08:00
Bogdan Drutu 9ae29a8309
Remove builder support to build old version, and the otelcol_version config (#11588)
Fixes
https://github.com/open-telemetry/opentelemetry-collector/issues/11405

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
2024-11-04 10:25:32 -08:00
Bogdan Drutu 3df7c320d2
[chore] Remove unnecessary overwrites for flag only values (#11589)
This is a no-op, because the file config cannot set the "skip"
properties since they have `mapstructure:"-"`

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
2024-11-04 09:01:00 -08:00
Bogdan Drutu cd6bfbb121
Remove reprecated flags from Builder (#11576)
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
2024-10-31 12:16:08 -07:00
Bogdan Drutu 8265197794
[chore] Remove unused version checks in builder config (#11568)
Updates
https://github.com/open-telemetry/opentelemetry-collector/issues/11405

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
2024-10-30 10:01:09 -07:00
VihasMakwana 78036deede
[internal/sharedcomponent] extract sharedcomponent into another package (#11542)
Resolves
https://github.com/open-telemetry/opentelemetry-collector/issues/11442

Also updates `genpdata` command, as the root module doesn't depend on
`go.opentelemetry.io/collector/pdata` anymore.
2024-10-28 08:44:24 -07:00
VihasMakwana ebed326c01
Make receivertest into its own module (#11544)
Resolves #11462
2024-10-28 08:44:00 -07:00
VihasMakwana b6d0497e42
[internal/fanoutconsumer] extract fanoutconsumer into another package (#11543)
Resolves #11441
2024-10-27 10:48:31 -07:00
OpenTelemetry Bot fee2daa249
[chore] Prepare release v1.18.0/v0.112.0 (#11515)
The following commands were run to prepare this release:
- make chlog-update VERSION=v1.18.0/v0.112.0
- make prepare-release PREVIOUS_VERSION=1[.]17[.]0
RELEASE_CANDIDATE=1.18.0 MODSET=stable
- make prepare-release PREVIOUS_VERSION=0[.]111[.]0
RELEASE_CANDIDATE=0.112.0 MODSET=beta
2024-10-22 11:38:35 -07:00
VihasMakwana 3193106bf4
[exporter/exportertest] - Make exportertest into its own module (#11489)
Resolves
https://github.com/open-telemetry/opentelemetry-collector/issues/11461
2024-10-21 09:25:23 -07:00
VihasMakwana 5a8560e80b
[consumererror] put consumererror into its own module (#11491)
Resolves
https://github.com/open-telemetry/opentelemetry-collector/issues/11440
2024-10-20 18:21:31 -07:00
Damien Mathieu f330cfb5d5
Add profiles support to OTLP HTTP exporter (#11450)
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description

This uses the profiles internal packages that were implemented in
previous PRs to provide profiles support to the OTLP HTTP exporter.

This PR requires #11226  to be merged first.
2024-10-18 09:48:13 +02:00
William Dumont 4f79e0d71e
Put connectortest in its own module (#11228)
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description

This PR is putting the connectortest pkg in its own module as requested
in
https://github.com/open-telemetry/opentelemetry-collector/issues/11216
2024-10-16 09:45:04 -07:00
William Dumont 46b0c2b5bc
Put processortest in its own module (#11229)
This PR is putting the processortest pkg in its own module as requested
in
https://github.com/open-telemetry/opentelemetry-collector/issues/11216

Fixes #11218
2024-10-15 10:15:29 -07:00
Bogdan Drutu fbf6d103ee
[chore] Extract internal/memorylimiter as a module (#11438)
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
2024-10-14 13:26:11 -07:00
Bogdan Drutu e1a03ebec2
[chore] Remove internal/globalsignal, embed into pipeline (#11422)
Depends on
https://github.com/open-telemetry/opentelemetry-collector/pull/11421

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
2024-10-14 06:18:25 -04:00
Bogdan Drutu 98a326a3c5
Move componentprofiles to pipelineprofiles (#11421)
Move componentprofiles to pipelineprofiles since only the signal
constant is defined in that package.

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
2024-10-13 13:47:00 -07:00
Bogdan Drutu be5fc23088
[chore] Remove unnecessary globalgates (#11418)
This package is no longer necessary, but if in the future we need to
have gates shared between modules we may re-create this module.

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
2024-10-12 10:37:07 -07:00
Nathan Baulch 42e6304f65
Fix typos (#11348)
Just thought I'd contribute some typo fixes I stumbled upon. Nothing
controversial (hopefully), just 72 simple fixes.

Use the following command to get a quick and dirty summary of the
specific corrections made:
```shell
git diff HEAD^! --word-diff-regex='\w+' -U0 \
  | grep -E '\[\-.*\-\]\{\+.*\+\}' \
  | sed -r 's/.*\[\-(.*)\-\]\{\+(.*)\+\}.*/\1 \2/' \
  | sort | uniq -c | sort -n
```

FWIW, the top typos are:
* invokable (16)
* subsciption (15)
* decison (7)
* reques (3)
* dissallow (3)
* documenation (3)
* locahost (3)
* prerequistes (2)
* assinged (2)
* extenions (2)

---------

Co-authored-by: Alex Boten <223565+codeboten@users.noreply.github.com>
2024-10-09 15:43:52 -07:00
luccabb 0f81b781c1
fix version init (#11388)
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description

```
debug.ReadBuildInfo()
```

returns an error for some environments, which then panics on
`info.Main.Version`:

```
panic: runtime error: invalid memory address or nil pointer dereference
```

this fixes the issue by only updating the version if
`debug.ReadBuildInfo()` succeeds
2024-10-08 13:03:17 -07:00
Pablo Baeyens 9d6a84e0b8
[cmd/builder] Update default configuration to use v1.17.0 (#11357)
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description

<!-- Issue number if applicable -->

Update default configuration to use v1.17.0 for confmap providers.

#### Link to tracking issue

This is what is making
open-telemetry/opentelemetry-collector-contrib#35605 fail
2024-10-04 17:05:51 +02:00
OpenTelemetry Bot 080b76506c
[chore] Prepare release v1.17.0/v0.111.0 (#11353)
The following commands were run to prepare this release:
- make chlog-update VERSION=v1.17.0/v0.111.0
- make prepare-release PREVIOUS_VERSION=1[.]16[.]0
RELEASE_CANDIDATE=1.17.0 MODSET=stable
- make prepare-release PREVIOUS_VERSION=0[.]110[.]0
RELEASE_CANDIDATE=0.111.0 MODSET=beta

---------

Co-authored-by: Pablo Baeyens <pablo.baeyens@datadoghq.com>
2024-10-04 01:12:02 -07:00
Tyler Helmuth f9d44de9b6
[exporter/logging] Remove logging exporter (#11037)
#### Description

It is September, which means we get to remove this deprecated component.

- The helm chart was updated to exclude the logging exporter already:
https://github.com/open-telemetry/opentelemetry-helm-charts/blob/main/charts/opentelemetry-collector/UPGRADING.md#0840-to-0850.
- The Operator references have been updated:
https://github.com/open-telemetry/opentelemetry-operator/pull/3259.
- Opentelemetry.io site final references to update:
https://github.com/open-telemetry/opentelemetry.io/pull/5143

<!-- Issue number if applicable -->
#### Link to tracking issue
Related to
https://github.com/open-telemetry/opentelemetry-collector/issues/7769
2024-10-03 11:47:39 +02:00
Matthieu MOREL aba139c2cb
[chore]: use ErrorContains and EqualError (#11295)
#### Description

Testifylint doesn't support it yet. 
This replaces `Contains(t, err.Error()` by `ErrorContains(t, err` and
`Equal(t, err.Error()` by `EqualError(t, err`
As they both check for nil error it becomes useless to check it yourself
without having defined a custom message

<!-- Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com> -->

Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2024-09-28 08:06:09 -07:00
John L. Peterson (Jack) 9811830023
Re-add version code to cmd/builder (#11208)
Revert "[chore] delete code to set a version and date, as it it not used
(#10715)"
Remove date string but re-add functions that check for version number
This (mostly) reverts commit b53f57d.

<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description
This re-enables the functionality to set a version number for ocb binary
(cmd/builder). It was erroneously removed. It also adds unit tests for
this functionality, as a warning is given on CI with no code coverage.

<!-- Issue number if applicable -->
#### Link to tracking issue
Relates to
https://github.com/open-telemetry/opentelemetry-collector-releases/issues/664.
Closes #11220 along with
https://github.com/open-telemetry/opentelemetry-collector-releases/pull/665

<!--Describe what testing was performed and which tests were added.-->
#### Testing
ran build and release cycles inside personal fork repositories
(jackgopack4/opentelemetry-collector and
jackgopack4/opentelemetry-collector-releases)
<!--Describe the documentation added.-->
#### Documentation
.chloggen file
<!--Please delete paragraphs that you did not use before submitting.-->
2024-09-24 12:23:07 -07:00
OpenTelemetry Bot d6f568dd5b
[chore] Prepare release v1.16.0/v0.110.0 (#11252)
The following commands were run to prepare this release:
- make chlog-update VERSION=v1.16.0/v0.110.0
- make prepare-release PREVIOUS_VERSION=1[.]15[.]0
RELEASE_CANDIDATE=1.16.0 MODSET=stable
- make prepare-release PREVIOUS_VERSION=0[.]109[.]0
RELEASE_CANDIDATE=0.110.0 MODSET=beta
2024-09-23 13:07:03 -07:00
Tyler Helmuth 77bb849aa0
[component] Refactor to use pipeline.ID and pipeline.Signal (#11204)
#### Description
Depends on
https://github.com/open-telemetry/opentelemetry-collector/pull/11209

This PR is a non-breaking implementation of
https://github.com/open-telemetry/opentelemetry-collector/pull/10947. It
adds a new module, `pipeline`, which houses a `pipeline.ID` and
`pipeline.Signal`. `pipeline.ID` is used to identify a pipeline within
the service. `pipeline.Signal` is uses to identify the signal associated
to a pipeline.

I do this work begrudgingly. As the PR shows, this is a huge refactor
when done in a non-breaking way, will require 3 full releases, and
doesn't benefit our [End Users or, in my opinion, our Component
Developers or Collector Library
Users](https://github.com/open-telemetry/opentelemetry-collector/blob/main/CONTRIBUTING.md#target-audiences).
I view this refactor as a Nice-To-Have, not a requirement for Component
1.0.

<!-- Issue number if applicable -->
#### Link to tracking issue
Works towards
https://github.com/open-telemetry/opentelemetry-collector/issues/9429
2024-09-23 07:38:59 -07:00
Peter Deng 396ae85e9d
Honor build_tags in config (#11156)
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description

<!-- Issue number if applicable -->
#### Link to tracking issue
Fixes #

<!--Describe what testing was performed and which tests were added.-->
#### Testing

<!--Describe the documentation added.-->
#### Documentation

<!--Please delete paragraphs that you did not use before submitting.-->
2024-09-19 10:10:43 +02:00
Matthieu MOREL 37f783308e
[chore]: enable require-error rule from testifylint (#11199)
#### Description

Testifylint is a linter that provides best practices with the use of
testify.

This PR enables
[require-error](https://github.com/Antonboom/testifylint?tab=readme-ov-file#require-error)
rule from [testifylint](https://github.com/Antonboom/testifylint)

Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2024-09-18 15:02:22 -07:00
Alex Boten fbffbb0820
[chore] small test improvements (#11211)
Clean up some inconsistencies in the test code across the components.

Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
2024-09-18 13:47:25 -07:00
Pablo Baeyens 5102a1ec65
[cmd/builder] Disable strict version check (#11168)
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description

Disable strict version check. The `--skip-strict-version-check` is kept
but is now a no-op.

This fixes #11152.

<!-- Issue number if applicable -->
#### Link to tracking issue
Fixes #11152
2024-09-13 17:29:43 +02:00
Matthieu MOREL 0e22dc367f
[chore]: enable error-is-as rule from testifylint (#11146)
#### Description

Testifylint is a linter that provides best practices with the use of
testify.

This PR enables
[error-is-as](https://github.com/Antonboom/testifylint?tab=readme-ov-file#error-is-as)
rule from [testifylint](https://github.com/Antonboom/testifylint)

Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2024-09-11 14:54:47 -07:00
Bogdan Drutu 6fb824644f
[builder]: Fix version for providers in the default config (#11123)
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
2024-09-10 15:08:29 -07:00
OpenTelemetry Bot 02d466f0c0
[chore] Prepare release v1.15.0/v0.109.0 (#11101)
The following commands were run to prepare this release:
- make chlog-update VERSION=v1.15.0/v0.109.0
- make prepare-release PREVIOUS_VERSION=1[.]14[.]1
RELEASE_CANDIDATE=1.15.0 MODSET=stable
- make prepare-release PREVIOUS_VERSION=0[.]108[.]1
RELEASE_CANDIDATE=0.109.0 MODSET=beta
2024-09-09 17:05:24 -07:00
Matthieu MOREL 6925a306fa
[chore]: enable len and empty rules from testifylint (#11021)
#### Description

Testifylint is a linter that provides best practices with the use of
testify.

This PR enables
[len](https://github.com/Antonboom/testifylint?tab=readme-ov-file#len)
and
[empty](https://github.com/Antonboom/testifylint?tab=readme-ov-file#empty)
rules from [testifylint](https://github.com/Antonboom/testifylint)

It also adds testifylint as tool to use with a make command

Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2024-09-09 09:57:58 -07:00
Pablo Baeyens 46d0f7361e
[extension] Move optional interfaces to extensioncapabilities (#11000)
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description

<!-- Issue number if applicable -->

Moves extension optional interfaces to a new module,
`extensioncapabilities`.

The intent is to be able to evolve these interfaces independently from
the core interfaces on core.

These are used by at most one component/project, so I think they are not
mature yet for 1.0

---------

Co-authored-by: Evan Bradley <11745660+evan-bradley@users.noreply.github.com>
2024-09-04 12:37:27 +02:00
Tyler Helmuth c9058e6582
[extension/ballast] Remove the deprecated memory ballast extension (#10671)
#### Description
This PR removes the deprecated memory ballast extension and all the
logic in place in memorylimiter and service that was using it.

#### Link to tracking issue
Related to
https://github.com/open-telemetry/opentelemetry-collector/issues/8343. I
don't want to close it until the [helm
chart](https://github.com/open-telemetry/opentelemetry-helm-charts/pull/1268)
is updated.

#### Testing
Unit tests

---------

Co-authored-by: Antoine Toulme <antoine@toulme.name>
Co-authored-by: Curtis Robert <crobert@splunk.com>
Co-authored-by: Pablo Baeyens <pablo.baeyens@datadoghq.com>
2024-09-04 11:14:57 +02:00
Pablo Baeyens cd1f7623fe
[extension] Split extension/experimental/storage into a separate module (#11020)
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description

<!-- Issue number if applicable -->

Fixes #11022
2024-09-02 10:56:31 +02:00
Damien Mathieu c5dbf546f5
[chore] add profiles support to exporter receiver builder (#10954)
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description

This allows building profiles in the exporter builder.
As this is only changing internal modules, I am marking it as chore (and
skipping changelog entry).

#### Link to tracking issue
https://github.com/open-telemetry/opentelemetry-collector/pull/10375

cc @mx-psi
2024-08-30 11:01:06 +02:00
Damien Mathieu 32171d20ac
[chore] add profiles support to connector receiver builder (#10956)
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description

This allows building profiles in the connector builder.
As this is only changing internal modules, I am marking it as chore (and
skipping changelog entry).

#### Link to tracking issue
https://github.com/open-telemetry/opentelemetry-collector/pull/10375

cc @mx-psi
2024-08-30 09:38:23 +02:00
Damien Mathieu 8ef05717ca
[chore] add profiles support to processor receiver builder (#10955)
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description

This allows building profiles in the processor builder.
As this is only changing internal modules, I am marking it as chore (and
skipping changelog entry).

#### Link to tracking issue
https://github.com/open-telemetry/opentelemetry-collector/pull/10375

cc @mx-psi
2024-08-29 17:41:54 +02:00
Damien Mathieu c3ef3443ba
[chore] add profiles support in receiver builder (#10945)
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description

This allows building profiles in the receiver builder.
As this is only changing internal modules, I am marking it as chore (and
skipping changelog entry).

<!-- Issue number if applicable -->
#### Link to tracking issue
https://github.com/open-telemetry/opentelemetry-collector/pull/10375

cc @mx-psi
2024-08-29 16:12:52 +02:00
OpenTelemetry Bot c8a932e6b3
[chore] Prepare release v1.14.1/v0.108.1 (#10986)
The following commands were run to prepare this release:
- make chlog-update VERSION=v1.14.1/v0.108.1
- make prepare-release PREVIOUS_VERSION=1[.]14[.]0
RELEASE_CANDIDATE=1.14.1 MODSET=stable
- make prepare-release PREVIOUS_VERSION=0[.]108[.]0
RELEASE_CANDIDATE=0.108.1 MODSET=beta
2024-08-27 11:09:14 -07:00
OpenTelemetry Bot 10155518e3
[chore] Prepare release v1.14.0/v0.108.0 (#10980)
The following commands were run to prepare this release:
- make chlog-update VERSION=v1.14.0/v0.108.0
- make prepare-release PREVIOUS_VERSION=1[.]13[.]0
RELEASE_CANDIDATE=1.14.0 MODSET=stable
- make prepare-release PREVIOUS_VERSION=0[.]107[.]0
RELEASE_CANDIDATE=0.108.0 MODSET=beta
2024-08-27 07:30:31 -07:00
Alex Boten 79bef21ac9
Revert "[builder] Support for --skip-new-go-module (#10098)" (#10978)
This reverts commit a0331ed86c.
2024-08-27 07:07:45 -07:00
Kristina Pathak a0331ed86c
[builder] Support for --skip-new-go-module (#10098)
A continuation of
https://github.com/open-telemetry/opentelemetry-collector/pull/9253 and
https://github.com/open-telemetry/opentelemetry-collector/pull/9631

Description: Adds a `--skip-new-go-module` flag to the OTC builder. This
enables users working in an existing go module environment (say, a
"monorepo") to update the module they have, vs forcing the use of a new
module.

With the new support inside an existing Go module, a collector main
package can be generated using a go:generate directive. For example, in
the directory where I want my collector built, the file generate.go has
this line:

//go:generate builder --skip-new-go-module --skip-compilation
--strict-versioning --config=./build-config.yaml
In the same directory, the build-config.yaml describes the collector to
build. The builder generates the other files in the same directory. At
this point, normal Go workflows can be used to update indirect
dependencies.

Link to tracking Issue:
https://github.com/open-telemetry/opentelemetry-collector/issues/9252

Testing: Will add unit tests in the next few days.

Documentation: Yes.

---------

Co-authored-by: Pablo Baeyens <pbaeyens31+github@gmail.com>
2024-08-22 10:52:55 +02:00
Tyler Helmuth cb24d0c7d7
[component] Remove ReportStatus from component.TelemetrySettings (#10777)
#### Description

This PR removes `ReportStatus` from `component.TelemetrySettings` and
instead expects components to check if their `component.Host` implements
a new `componentstatus.Reporter` interface.

<!-- Issue number if applicable -->
#### Link to tracking issue
Related to
https://github.com/open-telemetry/opentelemetry-collector/pull/10725
Related to
https://github.com/open-telemetry/opentelemetry-collector/pull/10413

<!--Describe what testing was performed and which tests were added.-->
#### Testing
unit tests and a sharedinstance e2e test.

The contrib tests will fail because this is a breaking change. If we
merge this I and @mwear can commit to updating contrib before the next
release.

---------

Co-authored-by: Pablo Baeyens <pablo.baeyens@datadoghq.com>
2024-08-16 09:27:01 +02:00
Alex Boten b0085e5591
[chore] use slices.Concat instead of a series of append (#10879)
Follows
https://github.com/open-telemetry/opentelemetry-collector/pull/10869

---------

Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
2024-08-13 16:09:01 -07:00
Alex Boten 76acd37b2c
Added support for go1.23, bumped the minimum version to 1.22 (#10869)
Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
2024-08-13 14:32:29 -07:00
OpenTelemetry Bot aacddac430
[chore] Prepare release v1.13.0/v0.107.0 (#10860)
The following commands were run to prepare this release:
- make chlog-update VERSION=v1.13.0/v0.107.0
- make prepare-release PREVIOUS_VERSION=1[.]12[.]0
RELEASE_CANDIDATE=1.13.0 MODSET=stable
- make prepare-release PREVIOUS_VERSION=0[.]106[.]1
RELEASE_CANDIDATE=0.107.0 MODSET=beta
2024-08-12 17:32:43 -07:00
Hajime Terasawa 291aa24bde
[cmd/builder] clarify mismatched versions in the warning message (#10767)
#### Description

Refine the warning message to make it useful for the end user.

#### Link to tracking issue

Fixes
https://github.com/open-telemetry/opentelemetry-collector/issues/10514

#### Testing

Locally tested.
```sh
2024-07-31T22:03:05.984+0900    INFO    internal/command.go:125 OpenTelemetry Collector Builder {"version": "(devel)"}
2024-07-31T22:03:05.984+0900    INFO    internal/command.go:136 Using default build configuration
2024-07-31T22:03:05.985+0900    INFO    builder/config.go:142   Using go        {"go-executable": "/usr/local/bin/go"}
2024-07-31T22:03:05.985+0900    INFO    builder/main.go:77      You're building a distribution with non-aligned version of the builder. The version mismatch may cause the compilation failure. It's recommended to use the same version.       {"collector-version": "0.104.0", "builder-version": "0.106.1"}
2024-07-31T22:03:05.985+0900    INFO    builder/main.go:100     Sources created {"path": "/tmp/otelcol-distribution3869530617"}
2024-07-31T22:03:06.510+0900    INFO    builder/main.go:191     Getting go modules
2024-07-31T22:03:06.552+0900    INFO    builder/main.go:111     Compiling
2024-07-31T22:03:07.080+0900    INFO    builder/main.go:130     Compiled        {"binary": "/tmp/otelcol-distribution3869530617/otelcorecol"}
```

#### Documentation

N/A

#### Note

I did not add a changelog entry because other PRs that only changed
logging messages and behavior did not add it too.
If this is an incorrect understanding, please point it out.

---------

Co-authored-by: Alex Boten <223565+codeboten@users.noreply.github.com>
2024-08-08 07:50:14 -07:00
Andrej Giesbrecht b521ed4220
[builder] fix the TestGenerateInvalidOutputPath (#10595)
If the test is executed with the `root` user, the
`TestGenerateInvalidOutputPath` test fails.
The behaviour was noticed with a GitLab runner that was executed with
root rights.

An attempt is made to create the directory `/:invalid` during the test.
A user without root rights receives the message `cannot create directory
'/:invalid': Permission denied`.
In contrast, the `root` user can create the directory without any
problems because this is a valid path.

To correct the behaviour of the test, the path to `:/invalid` was
adjusted.
This is not a valid path under Windows or Linux.

Signed-off-by: Andrej Giesbrecht <giesan@gmx.net>
2024-08-08 14:02:06 +02:00
Tyler Helmuth 2b9697fe09
[confmap] Deprecate expandconverter (#10510)
#### Description
This PR deprecates `expandconverter` and removes its use from
`otelcoltest.LoadConfig` and OCB.

This cannot be merged until the `confmap.unifyEnvVarExpansion` [feature
gate is made
stable](https://github.com/open-telemetry/opentelemetry-collector/pull/10508).

<!-- Issue number if applicable -->
#### Link to tracking issue
closes
https://github.com/open-telemetry/opentelemetry-collector/issues/10161
closes
https://github.com/open-telemetry/opentelemetry-collector/issues/7111
closes
https://github.com/open-telemetry/opentelemetry-collector/issues/8215

---------

Co-authored-by: Alex Boten <223565+codeboten@users.noreply.github.com>
Co-authored-by: Dmitrii Anoshin <anoshindx@gmail.com>
2024-08-07 15:55:09 -07:00
Damien Mathieu c0188e02a2
Add profiles support in connector (#10703)
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description

This follows
https://github.com/open-telemetry/opentelemetry-collector/pull/10524 and
adds profiles support into connectors.

<!-- Issue number if applicable -->
#### Link to tracking issue
See https://github.com/open-telemetry/opentelemetry-collector/pull/10375
2024-08-01 00:43:08 +02:00
Antoine Toulme b53f57dc89
[chore] delete code to set a version and date, as it it not used (#10715) 2024-07-30 11:22:06 -07:00
Yang Song a1dd721d18
Prepare Release v0.106.1 (#10754)
Co-authored-by: Alex Boten <223565+codeboten@users.noreply.github.com>
Co-authored-by: Pablo Baeyens <pbaeyens31+github@gmail.com>
2024-07-30 12:30:12 -04:00
OpenTelemetry Bot 72e906d135
[chore] Prepare release v0.106.0 (#10736)
The following commands were run to prepare this release:
- make chlog-update VERSION=v0.106.0
- make prepare-release PREVIOUS_VERSION=0[.]105[.]0
RELEASE_CANDIDATE=0.106.0 MODSET=beta

---------

Co-authored-by: Yang Song <songy23@users.noreply.github.com>
2024-07-29 12:09:03 -07:00
Antoine Toulme 7ef35175ef
[client] add new module `go.opentelemetry.io/collector/client` (#9805)
**Description:** 
Create a new go module `go.opentelemetry.io/collector/client`

**Link to tracking Issue:**
Fixes #9804

---------

Co-authored-by: Yang Song <songy23@users.noreply.github.com>
2024-07-26 13:09:10 +02:00
Damien Mathieu 2ddf1ad5db
Support profiles in consumertest (#10692)
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description

Following
https://github.com/open-telemetry/opentelemetry-collector/pull/10464,
this adds profiles support in consumertest.

cc @mx-psi
2024-07-23 13:26:01 +02:00
OpenTelemetry Bot bf6bd9fd26
[chore] Prepare release v1.12.0/v0.105.0 (#10623)
The following commands were run to prepare this release:
- make chlog-update VERSION=v1.12.0/v0.105.0
- make prepare-release PREVIOUS_VERSION=1.11.0 RELEASE_CANDIDATE=1.12.0
MODSET=stable
- make prepare-release PREVIOUS_VERSION=0.104.0
RELEASE_CANDIDATE=0.105.0 MODSET=beta
2024-07-16 09:51:56 -07:00
Daniel Jaglowski f2c56a3752
Enhance builder to capture go module for each component type (#10599)
Resolves #10570

Alternative to #10598

This implementation is more reliable that #10598 because it gets
information directly from the builder manifest. It relies on additional
structure in the `component.go` file, ultimately encoded in
`otelcol.Factories`.

An alternative would be to push the enhancements deeper, into the
`<kind>.Factories` implementations, so that the module information is
available directly alongside the Factory.
2024-07-16 17:21:42 +02:00
Pablo Baeyens 75aeab0f1d
[chore] Rename internal/featuregates to internal/globalgates (#10614)
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description

Fixes #10569. However, I think it's fine to just close the issue as
wontfix and not do this.
2024-07-15 16:11:37 +02:00
Kristina Pathak 8de544b176
[builder] more information for missing gomod error (#10475)
#### Description
improving an error message - a missing gomod field would be reported but
without informing where in the config the field is missing.

<!-- Issue number if applicable -->
#### Link to tracking issue
Fixes #10474

<!--Describe what testing was performed and which tests were added.-->
#### Testing
Unit tests pass, added some tests for missing cases, manually tested

new error looks like:
```
../../bin/ocb_darwin_amd64 --config=./default.yaml
2024-06-27T11:39:10.316-0700	INFO	internal/command.go:125	OpenTelemetry Collector Builder	{"version": "", "date": "unknown"}
2024-06-27T11:39:10.319-0700	INFO	internal/command.go:161	Using config file	{"path": "./default.yaml"}
Error: invalid configuration: receiver module at index 0: missing gomod specification for module; provider module at index 2: missing gomod specification for module
```
2024-07-08 21:06:53 +02:00
Pablo Baeyens b127da0890
[chore] Make internal/featuregates into a module, move confmap fg there (#10532)
#### Description

Create new internal module `internal/featuregates`.

This will be useful for importing feature gates while not creating a
dependency cycle.

I intend to use this for importing `confmap.strictlyTypedInput` in
`otelcol` in a follow up PR.
2024-07-05 09:17:05 -07:00
OpenTelemetry Bot a082f2e439
[chore] Prepare release v1.11.0/v0.104.0 (#10491)
The following commands were run to prepare this release:
- make chlog-update VERSION=v1.11.0/v0.104.0
- make prepare-release PREVIOUS_VERSION=1.10.0 RELEASE_CANDIDATE=1.11.0
MODSET=stable
- make prepare-release PREVIOUS_VERSION=0.103.0
RELEASE_CANDIDATE=0.104.0 MODSET=beta

---------

Co-authored-by: Tyler Helmuth <12352919+TylerHelmuth@users.noreply.github.com>
2024-07-01 13:07:11 -07:00
Tyler Helmuth 5309d60a16
[otelcol] Remove all default providers/converters (#10436)
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description
Removed deprecated `NewCommand`. Deprecates `NewCommandMustSetProvider`.
Adds `NewCommand` that requires at least one provider be set.

Removes usage of imported providers/converters from otelcol (but they
still live in otelcoltest until
https://github.com/open-telemetry/opentelemetry-collector/pull/10417 is
merged.

<!-- Issue number if applicable -->
#### Link to tracking issue
closes
https://github.com/open-telemetry/opentelemetry-collector/issues/10290.

<!--Describe what testing was performed and which tests were added.-->
#### Testing
Unit tests
2024-06-28 10:33:11 +02:00
Damien Mathieu 227fb823db
Add pprofile wrapper and testdata (#10401)
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description

This adds pprofile wrapper (the non-generated bit of pprofile), as well
as test data.

cc @mx-psi

---------

Co-authored-by: Pablo Baeyens <pbaeyens31+github@gmail.com>
2024-06-24 16:58:57 +02:00
OpenTelemetry Bot aa31b271c6
[chore] Prepare release v1.10.0/v0.103.0 (#10418)
The following commands were run to prepare this release:
- make chlog-update VERSION=v1.10.0/v0.103.0
- make prepare-release PREVIOUS_VERSION=1.9.0 RELEASE_CANDIDATE=1.10.0
MODSET=stable
- make prepare-release PREVIOUS_VERSION=0.102.1
RELEASE_CANDIDATE=0.103.0 MODSET=beta
2024-06-17 13:53:27 -07:00
Pablo Baeyens 45a688c5b3
Merge branch 'release/v0.102.x' into mx-psi/release/v0.102.x-fix-merge-conflicts-v2 2024-06-05 16:38:56 +02:00
Pablo Baeyens 7218b4cd1d
prepare release 0.102.1 (#10326)
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description

Step 2 of release process

> Make sure you are on release/<release-series>. Prepare release commits
with prepare-release make target, e.g. make prepare-release
PREVIOUS_VERSION=0.90.0 RELEASE_CANDIDATE=0.90.1 MODSET=beta, and create
a pull request against the release/<release-series> branch.
2024-06-05 16:03:09 +02:00
Tyler Helmuth d136b6d186
[cmd/builder] Allow setting DefaultScheme in builder config (#10296)
#### Description

Allows configuring `DefaultScheme` via the builder config.

#### Link to tracking issue
Related to
https://github.com/open-telemetry/opentelemetry-collector/pull/10259
Related to
https://github.com/open-telemetry/opentelemetry-collector/issues/10290

#### Testing
Local testing and unit tests

---------

Co-authored-by: Evan Bradley <11745660+evan-bradley@users.noreply.github.com>
Co-authored-by: Alex Boten <223565+codeboten@users.noreply.github.com>
2024-06-04 13:57:59 -07:00
OpenTelemetry Bot 5cbf8bebe4
[chore] Prepare release v1.9.0/v0.102.0 (#10293)
The following commands were run to prepare this release:
- make chlog-update VERSION=v1.9.0/v0.102.0
- make prepare-release PREVIOUS_VERSION=1.8.0 RELEASE_CANDIDATE=1.9.0
MODSET=stable
- make prepare-release PREVIOUS_VERSION=0.101.0
RELEASE_CANDIDATE=0.102.0 MODSET=beta

---------

Co-authored-by: Pablo Baeyens <pablo.baeyens@datadoghq.com>
2024-06-03 11:31:37 -07:00
Evan Bradley 1c7715cbfd
[chore][cmd/builder] Improve missing replace statements test (#10196)
Updates `TestReplaceStatementsAreComplete` to check the modules used in
replace statements to ensure that their dependencies also have replace
statements. This will catch the error that happened in #10188 before a
release is started.

The one caveat here is that the test may need to be run multiple times
if there are modules deep in the dependency tree that haven't been added
to the list of replace statement modules. In essence, the user has to do
a BFS walk of the dependency tree themselves by running the tests until
all missing modules are caught. We could automate this process with
additional code to report all missing modules at once regardless of
depth, but I figure it's not worth the extra complexity in the test for
such a small gain.

#### Testing

I tested this on the #10188 branch by removing the `pdata/testdata`
module from the replace statements list and seeing that the failure is
easier to understand:

```
--- FAIL: TestReplaceStatementsAreComplete (0.60s)
        	Error:      	Should be true
        	Test:       	TestReplaceStatementsAreComplete
        	Messages:   	Module missing from replace statements list: go.opentelemetry.io/collector/pdata/testdata
```
2024-05-21 11:33:43 -07:00
Juraci Paixão Kröhling d719a7efcf
[chore] Prepare release v1.8.0/v0.101.0 (#10190)
This replaces #10188, by fixing a relatively new test case that blocked
the release.

Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de>

---------

Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de>
Co-authored-by: opentelemetrybot <107717825+opentelemetrybot@users.noreply.github.com>
2024-05-21 05:58:35 -07:00
Evan Bradley 8e268367c9
[chore][cmd/builder] Test for unreleased versions (#10030)
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description

Add a test to help prevent our replace statements from going out of date
and causing situations like
https://github.com/open-telemetry/opentelemetry-collector/issues/10014.
This is also probably just a decent test case to have since it's a
syntactically valid but nonexistent version.

---------

Co-authored-by: Evan Bradley <evan-bradley@users.noreply.github.com>
Co-authored-by: Juraci Paixão Kröhling <juraci.github@kroehling.de>
2024-05-09 18:21:11 +02:00
OpenTelemetry Bot 6c2a34edea
[chore] Prepare release v1.7.0/v0.100.0 (#10087)
The following commands were run to prepare this release:
- make chlog-update VERSION=v1.7.0/v0.100.0
- make prepare-release PREVIOUS_VERSION=1.6.0 RELEASE_CANDIDATE=1.7.0
MODSET=stable
- make prepare-release PREVIOUS_VERSION=0.99.0 RELEASE_CANDIDATE=0.100.0
MODSET=beta

---------

Co-authored-by: Bogdan Drutu <bogdandrutu@gmail.com>
2024-05-06 09:33:51 -07:00
Kristina Pathak ff7a48564c
[builder] make retries configurable for faster tests (#10035)
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description
When running tests, waiting for `downloadModules()` to fail 3 times when
that's expected adds time to the test run. This updates tests to only
attempt downloading once. Note: if there's a network failure that could
cause `downloadModules()` to fail when it should normally succeed. Also
the wording here is `retries` when in actuality it's the number of
attempts. I didn't change this to keep the log wording the same, but I
can change the wording if that's preferable.

<!-- Issue number if applicable -->
#### Link to tracking issue
this will help for adding tests for
https://github.com/open-telemetry/opentelemetry-collector/issues/9252
and
https://github.com/open-telemetry/opentelemetry-collector/issues/9896

<!--Describe what testing was performed and which tests were added.-->
#### Testing
Tests ran

---------

Co-authored-by: Pablo Baeyens <pbaeyens31+github@gmail.com>
2024-05-03 13:47:38 +02:00