Commit Graph

12 Commits

Author SHA1 Message Date
Marc Alff e5a1a15296
[Code Health] Include what you use, part 6 (#3216) 2025-01-08 10:31:06 +01:00
Marc Alff c6d394547b
[Code Health] include-what-you-use cleanup, part 4 (#3040) 2024-09-11 21:05:32 +02:00
Punya Biswal 7f785b5d5c
[TEST] Add missing tests to Bazel build (#3045)
* Fix overflow in timeout logic

Also use steady clock consistently.

Prior to this change, the test would fail under ASAN:

bazel test --config=asan --test_output=errors //sdk/test/metrics:meter_provider_sdk_test
INFO: Analyzed target //sdk/test/metrics:meter_provider_sdk_test (0 packages loaded, 0 targets configured).
FAIL: //sdk/test/metrics:meter_provider_sdk_test (see /private/var/tmp/_bazel_punya/e3bd968ba61238cdeb1a5537fc3dbf7d/execroot/_main/bazel-out/darwin_arm64-fastbuild-asan/testlogs/sdk/test/metrics/meter_provider_sdk_test/test.log)
INFO: From Testing //sdk/test/metrics:meter_provider_sdk_test:
==================== Test output for //sdk/test/metrics:meter_provider_sdk_test:
Running main() from gmock_main.cc
[==========] Running 1 test from 1 test suite.
[----------] Global test environment set-up.
[----------] 1 test from MeterProvider
[ RUN      ] MeterProvider.GetMeter
[Warning] File: sdk/src/metrics/meter_provider.cc:65 [MeterProvider::GetMeter] Library name is empty.
[Warning] File: sdk/src/metrics/meter_provider.cc:65 [MeterProvider::GetMeter] Library name is empty.
/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/include/c++/v1/__chrono/duration.h:102:59: runtime error: signed integer overflow: 9221646818050376183 * 1000 cannot be represented in type '_Ct' (aka 'long long')
SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior /Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/include/c++/v1/__chrono/duration.h:102:59 in 
================================================================================
INFO: Found 1 test target...
Target //sdk/test/metrics:meter_provider_sdk_test up-to-date:
  bazel-bin/sdk/test/metrics/meter_provider_sdk_test
INFO: Elapsed time: 2.251s, Critical Path: 2.13s
INFO: 5 processes: 5 darwin-sandbox.
INFO: Build completed, 1 test FAILED, 5 total actions
//sdk/test/metrics:meter_provider_sdk_test                               FAILED in 0.6s
  /private/var/tmp/_bazel_punya/e3bd968ba61238cdeb1a5537fc3dbf7d/execroot/_main/bazel-out/darwin_arm64-fastbuild-asan/testlogs/sdk/test/metrics/meter_provider_sdk_test/test.log

Executed 1 out of 1 test: 1 fails locally.

Fix overflow in periodic_exporting_metric_reader

* Add missing tests to Bazel build by globbing test files

Previously, we were missing
* instrument_metadata_validator_test
* observable_registry_test
* cardinality_limit_test
* periodic_exporting_metric_reader_test
And there were no checks in place to prevent things from getting worse.

Remove unnecessary exception checks in attributes_hashmap_test,
which simplifies the build and CI script.

Resolve symbol collision using anonymous namespaces.

---------

Co-authored-by: Lalit Kumar Bhasin <lalit_fin@yahoo.com>
2024-09-03 21:08:37 +02:00
Siddhartha Malladi eb2b9753ea
[Code Health] clang-tidy cleanup, part 1 (#2990) 2024-07-11 11:45:17 +02:00
Cengizhan Pasaoglu cfcda5728e
[SDK] Header files cleanup, use forward declarations (#2182) 2023-06-21 00:11:31 +02:00
Ehsan Saei b8b715faf9
[Metrics SDK] Cleanup ENABLE_METRICS_PREVIEW (#1735) 2022-11-06 21:03:08 +00:00
Marc Alff c7dfc0de26
Fix build warnings (#1613) 2022-09-14 16:32:56 +02:00
Lalit Kumar Bhasin ad23f20392
METRICS SDK - Calling Observable Instruments callback during metrics collection (#1554) 2022-08-15 16:19:34 -07:00
Lalit Kumar Bhasin 73a51cf633
Support multiple async callbacks (#1495) 2022-08-05 11:54:00 -07:00
Lalit Kumar Bhasin be75bbc862
Add InstrumentationInfo and Resource to the metrics data to be exported. (#1299) 2022-04-04 22:09:02 +00:00
Lalit Kumar Bhasin 31d888a540
Enable metric collection from MetricReader (#1241) 2022-03-17 18:15:35 -07:00
Lalit Kumar Bhasin 04e3a68263
Sync and Async Instruments SDK (#1184) 2022-02-09 22:27:55 -08:00