From 01d41406b3aaec2aea9b25bce72ce7e3686e9955 Mon Sep 17 00:00:00 2001 From: Eddy Nakamura Date: Tue, 3 Nov 2020 21:50:17 -0300 Subject: [PATCH] moving to dispose --- .../BasicTests.cs | 10 +++++----- .../HttpClientTests.Basic.netcore31.cs | 10 +++++----- .../HttpWebRequestTests.Basic.netfx.cs | 10 +++++----- 3 files changed, 15 insertions(+), 15 deletions(-) diff --git a/test/OpenTelemetry.Instrumentation.AspNetCore.Tests/BasicTests.cs b/test/OpenTelemetry.Instrumentation.AspNetCore.Tests/BasicTests.cs index 77ffb9f22..3c46ffd7f 100644 --- a/test/OpenTelemetry.Instrumentation.AspNetCore.Tests/BasicTests.cs +++ b/test/OpenTelemetry.Instrumentation.AspNetCore.Tests/BasicTests.cs @@ -236,11 +236,6 @@ namespace OpenTelemetry.Instrumentation.AspNetCore.Tests Assert.Equal(expectedTraceId, activity.Context.TraceId); Assert.Equal(expectedSpanId, activity.ParentSpanId); - Sdk.SetDefaultTextMapPropagator(new CompositeTextMapPropagator(new TextMapPropagator[] - { - new TraceContextPropagator(), - new BaggagePropagator(), - })); } [Fact] @@ -338,6 +333,11 @@ namespace OpenTelemetry.Instrumentation.AspNetCore.Tests public void Dispose() { this.openTelemetrySdk?.Dispose(); + Sdk.SetDefaultTextMapPropagator(new CompositeTextMapPropagator(new TextMapPropagator[] + { + new TraceContextPropagator(), + new BaggagePropagator(), + })); } private static void WaitForProcessorInvocations(Mock> activityProcessor, int invocationCount) diff --git a/test/OpenTelemetry.Instrumentation.Http.Tests/HttpClientTests.Basic.netcore31.cs b/test/OpenTelemetry.Instrumentation.Http.Tests/HttpClientTests.Basic.netcore31.cs index b0a5f284e..70e788647 100644 --- a/test/OpenTelemetry.Instrumentation.Http.Tests/HttpClientTests.Basic.netcore31.cs +++ b/test/OpenTelemetry.Instrumentation.Http.Tests/HttpClientTests.Basic.netcore31.cs @@ -184,11 +184,6 @@ namespace OpenTelemetry.Instrumentation.Http.Tests Assert.Equal($"00/{activity.Context.TraceId}/{activity.Context.SpanId}/01", traceparents.Single()); Assert.Equal("k1=v1,k2=v2", tracestates.Single()); - Sdk.SetDefaultTextMapPropagator(new CompositeTextMapPropagator(new TextMapPropagator[] - { - new TraceContextPropagator(), - new BaggagePropagator(), - })); } [Fact] @@ -321,6 +316,11 @@ namespace OpenTelemetry.Instrumentation.Http.Tests { this.serverLifeTime?.Dispose(); Activity.Current = null; + Sdk.SetDefaultTextMapPropagator(new CompositeTextMapPropagator(new TextMapPropagator[] + { + new TraceContextPropagator(), + new BaggagePropagator(), + })); } private static void ActivityEnrichment(Activity activity, string method, object obj) diff --git a/test/OpenTelemetry.Instrumentation.Http.Tests/HttpWebRequestTests.Basic.netfx.cs b/test/OpenTelemetry.Instrumentation.Http.Tests/HttpWebRequestTests.Basic.netfx.cs index 09a8d2a76..784d896cb 100644 --- a/test/OpenTelemetry.Instrumentation.Http.Tests/HttpWebRequestTests.Basic.netfx.cs +++ b/test/OpenTelemetry.Instrumentation.Http.Tests/HttpWebRequestTests.Basic.netfx.cs @@ -55,6 +55,11 @@ namespace OpenTelemetry.Instrumentation.Http.Tests public void Dispose() { this.serverLifeTime?.Dispose(); + Sdk.SetDefaultTextMapPropagator(new CompositeTextMapPropagator(new TextMapPropagator[] + { + new TraceContextPropagator(), + new BaggagePropagator(), + })); } [Fact] @@ -141,11 +146,6 @@ namespace OpenTelemetry.Instrumentation.Http.Tests Assert.Equal("k1=v1,k2=v2", tracestate); parent.Stop(); - Sdk.SetDefaultTextMapPropagator(new CompositeTextMapPropagator(new TextMapPropagator[] - { - new TraceContextPropagator(), - new BaggagePropagator(), - })); } [Fact]