open-telemetry
/
opentelemetry-dotnet
mirror of https://github.com/open-telemetry/opentelemetry-dotnet.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Make Jaeger Exporter class and constructor public (#1644) 

* Make Jaeger Exporter class and constructor public

* resolving PR comments: reverting TTransport change

* updated changelog

Co-authored-by: Eddy Nakamura <ednakamu@microsoft.com>
Co-authored-by: Cijo Thomas <cithomas@microsoft.com>
This commit is contained in:
Vishwesh Bankwar 2020-12-08 12:00:38 -08:00 committed by GitHub
parent 7a3f5e7bbf
commit 01dc04710a
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
5 changed files with 21 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/OpenTelemetry.Exporter.Jaeger/.publicApi/net46/PublicAPI.Unshipped.txt
View File

@ -1,3 +1,5 @@
OpenTelemetry.Exporter.Jaeger.JaegerExporter
OpenTelemetry.Exporter.Jaeger.JaegerExporter.JaegerExporter(OpenTelemetry.Exporter.Jaeger.JaegerExporterOptions options) -> void
OpenTelemetry.Exporter.Jaeger.JaegerExporterOptions
OpenTelemetry.Exporter.Jaeger.JaegerExporterOptions.AgentHost.get -> string
OpenTelemetry.Exporter.Jaeger.JaegerExporterOptions.AgentHost.set -> void
@ -13,4 +15,6 @@ OpenTelemetry.Exporter.Jaeger.JaegerExporterOptions.MaxPayloadSizeInBytes.set ->
OpenTelemetry.Exporter.Jaeger.JaegerExporterOptions.ProcessTags.get -> System.Collections.Generic.IEnumerable<System.Collections.Generic.KeyValuePair<string, object>>
OpenTelemetry.Exporter.Jaeger.JaegerExporterOptions.ProcessTags.set -> void
OpenTelemetry.Trace.JaegerExporterHelperExtensions
override OpenTelemetry.Exporter.Jaeger.JaegerExporter.Dispose(bool disposing) -> void
override OpenTelemetry.Exporter.Jaeger.JaegerExporter.Export(in OpenTelemetry.Batch<System.Diagnostics.Activity> activityBatch) -> OpenTelemetry.ExportResult
static OpenTelemetry.Trace.JaegerExporterHelperExtensions.AddJaegerExporter(this OpenTelemetry.Trace.TracerProviderBuilder builder, System.Action<OpenTelemetry.Exporter.Jaeger.JaegerExporterOptions> configure = null) -> OpenTelemetry.Trace.TracerProviderBuilder

4
src/OpenTelemetry.Exporter.Jaeger/.publicApi/netstandard2.0/PublicAPI.Unshipped.txt
View File

@ -1,3 +1,5 @@
OpenTelemetry.Exporter.Jaeger.JaegerExporter
OpenTelemetry.Exporter.Jaeger.JaegerExporter.JaegerExporter(OpenTelemetry.Exporter.Jaeger.JaegerExporterOptions options) -> void
OpenTelemetry.Exporter.Jaeger.JaegerExporterOptions
OpenTelemetry.Exporter.Jaeger.JaegerExporterOptions.AgentHost.get -> string
OpenTelemetry.Exporter.Jaeger.JaegerExporterOptions.AgentHost.set -> void
@ -13,4 +15,6 @@ OpenTelemetry.Exporter.Jaeger.JaegerExporterOptions.MaxPayloadSizeInBytes.set ->
OpenTelemetry.Exporter.Jaeger.JaegerExporterOptions.ProcessTags.get -> System.Collections.Generic.IEnumerable<System.Collections.Generic.KeyValuePair<string, object>>
OpenTelemetry.Exporter.Jaeger.JaegerExporterOptions.ProcessTags.set -> void
OpenTelemetry.Trace.JaegerExporterHelperExtensions
override OpenTelemetry.Exporter.Jaeger.JaegerExporter.Dispose(bool disposing) -> void
override OpenTelemetry.Exporter.Jaeger.JaegerExporter.Export(in OpenTelemetry.Batch<System.Diagnostics.Activity> activityBatch) -> OpenTelemetry.ExportResult
static OpenTelemetry.Trace.JaegerExporterHelperExtensions.AddJaegerExporter(this OpenTelemetry.Trace.TracerProviderBuilder builder, System.Action<OpenTelemetry.Exporter.Jaeger.JaegerExporterOptions> configure = null) -> OpenTelemetry.Trace.TracerProviderBuilder

4
src/OpenTelemetry.Exporter.Jaeger/.publicApi/netstandard2.1/PublicAPI.Unshipped.txt
View File

@ -1,3 +1,5 @@
OpenTelemetry.Exporter.Jaeger.JaegerExporter
OpenTelemetry.Exporter.Jaeger.JaegerExporter.JaegerExporter(OpenTelemetry.Exporter.Jaeger.JaegerExporterOptions options) -> void
OpenTelemetry.Exporter.Jaeger.JaegerExporterOptions
OpenTelemetry.Exporter.Jaeger.JaegerExporterOptions.AgentHost.get -> string
OpenTelemetry.Exporter.Jaeger.JaegerExporterOptions.AgentHost.set -> void
@ -13,4 +15,6 @@ OpenTelemetry.Exporter.Jaeger.JaegerExporterOptions.MaxPayloadSizeInBytes.set ->
OpenTelemetry.Exporter.Jaeger.JaegerExporterOptions.ProcessTags.get -> System.Collections.Generic.IEnumerable<System.Collections.Generic.KeyValuePair<string, object>>
OpenTelemetry.Exporter.Jaeger.JaegerExporterOptions.ProcessTags.set -> void
OpenTelemetry.Trace.JaegerExporterHelperExtensions
override OpenTelemetry.Exporter.Jaeger.JaegerExporter.Dispose(bool disposing) -> void
override OpenTelemetry.Exporter.Jaeger.JaegerExporter.Export(in OpenTelemetry.Batch<System.Diagnostics.Activity> activityBatch) -> OpenTelemetry.ExportResult
static OpenTelemetry.Trace.JaegerExporterHelperExtensions.AddJaegerExporter(this OpenTelemetry.Trace.TracerProviderBuilder builder, System.Action<OpenTelemetry.Exporter.Jaeger.JaegerExporterOptions> configure = null) -> OpenTelemetry.Trace.TracerProviderBuilder

3
src/OpenTelemetry.Exporter.Jaeger/CHANGELOG.md
View File

@ -2,6 +2,9 @@
## Unreleased
* Changed `JaegerExporter` class and constructor from internal to public.
([#1612](https://github.com/open-telemetry/opentelemetry-dotnet/issues/1612))
* In `JaegerExporterOptions`: Exporter options now include a switch for
Batch vs Simple exporter, and settings for batch exporting properties.

7
src/OpenTelemetry.Exporter.Jaeger/JaegerExporter.cs
View File

@ -26,7 +26,7 @@ using Process = OpenTelemetry.Exporter.Jaeger.Implementation.Process;
namespace OpenTelemetry.Exporter.Jaeger
{
internal class JaegerExporter : BaseExporter<Activity>
public class JaegerExporter : BaseExporter<Activity>
{
private const string DefaultServiceName = "OpenTelemetry Exporter";
@ -40,6 +40,11 @@ namespace OpenTelemetry.Exporter.Jaeger
private int batchByteSize;
private bool disposedValue; // To detect redundant dispose calls
public JaegerExporter(JaegerExporterOptions options)
: this(options, null)
{
}
internal JaegerExporter(JaegerExporterOptions options, TTransport clientTransport = null)
{
if (options is null)