From 0256f875d417c6d50804d221acbd788253e40c72 Mon Sep 17 00:00:00 2001
From: Vishwesh Bankwar <vishweshbankwar@users.noreply.github.com>
Date: Fri, 17 Nov 2023 14:02:24 -0800
Subject: [PATCH] Http Span Status - Default to Unset if not in range defined
 by spec (#5060)

---
 src/Shared/SpanHelper.cs | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/src/Shared/SpanHelper.cs b/src/Shared/SpanHelper.cs
index 67e6dcbfd..393a0f2cb 100644
--- a/src/Shared/SpanHelper.cs
+++ b/src/Shared/SpanHelper.cs
@@ -32,12 +32,13 @@ internal static class SpanHelper
     /// <returns>Resolved span <see cref="Status"/> for the Http status code.</returns>
     public static ActivityStatusCode ResolveSpanStatusForHttpStatusCode(ActivityKind kind, int httpStatusCode)
     {
-        var upperBound = kind == ActivityKind.Client ? 399 : 499;
-        if (httpStatusCode >= 100 && httpStatusCode <= upperBound)
+        var lowerBound = kind == ActivityKind.Client ? 400 : 500;
+        var upperBound = 599;
+        if (httpStatusCode >= lowerBound && httpStatusCode <= upperBound)
         {
-            return ActivityStatusCode.Unset;
+            return ActivityStatusCode.Error;
         }
 
-        return ActivityStatusCode.Error;
+        return ActivityStatusCode.Unset;
     }
 }