From 44d2fe20ba8d41b1251846f7efa500d603a08a73 Mon Sep 17 00:00:00 2001
From: Timothy Mothra <tilee@microsoft.com>
Date: Wed, 7 Dec 2022 10:43:36 -0800
Subject: [PATCH] implicitusings (#3980)

---
 src/OpenTelemetry.Api/Internal/ExceptionExtensions.cs          | 2 ++
 src/OpenTelemetry.Api/Internal/Guard.cs                        | 2 ++
 src/OpenTelemetry.Exporter.Console/ConsoleActivityExporter.cs  | 1 -
 .../ConsoleExporterHelperExtensions.cs                         | 1 -
 .../ConsoleExporterLoggingExtensions.cs                        | 1 -
 .../ConsoleExporterMetricsExtensions.cs                        | 2 --
 .../ConsoleExporterOutputTargets.cs                            | 2 --
 src/OpenTelemetry.Exporter.Console/ConsoleLogRecordExporter.cs | 2 --
 src/OpenTelemetry.Exporter.Console/ConsoleTagTransformer.cs    | 1 -
 .../OpenTelemetry.Exporter.Console.csproj                      | 1 -
 src/OpenTelemetry.Exporter.InMemory/InMemoryExporter.cs        | 3 ---
 .../InMemoryExporterHelperExtensions.cs                        | 1 -
 .../InMemoryExporterLoggingExtensions.cs                       | 1 -
 .../InMemoryExporterMetricsExtensions.cs                       | 3 ---
 src/OpenTelemetry.Exporter.InMemory/MetricSnapshot.cs          | 2 --
 .../OpenTelemetry.Exporter.InMemory.csproj                     | 1 -
 src/OpenTelemetry/Internal/OpenTelemetrySdkEventSource.cs      | 2 ++
 src/OpenTelemetry/Internal/TagTransformer.cs                   | 2 ++
 18 files changed, 8 insertions(+), 22 deletions(-)

diff --git a/src/OpenTelemetry.Api/Internal/ExceptionExtensions.cs b/src/OpenTelemetry.Api/Internal/ExceptionExtensions.cs
index 0254b0cc1..733b32295 100644
--- a/src/OpenTelemetry.Api/Internal/ExceptionExtensions.cs
+++ b/src/OpenTelemetry.Api/Internal/ExceptionExtensions.cs
@@ -14,9 +14,11 @@
 // limitations under the License.
 // </copyright>
 
+#pragma warning disable IDE0005 // Temporarily suppressing "Using directive is unnecessary" until other projects have been updated. See #3958.
 using System;
 using System.Globalization;
 using System.Threading;
+#pragma warning restore IDE0005
 
 namespace OpenTelemetry.Internal
 {
diff --git a/src/OpenTelemetry.Api/Internal/Guard.cs b/src/OpenTelemetry.Api/Internal/Guard.cs
index 7ff9b57d8..cafb516a6 100644
--- a/src/OpenTelemetry.Api/Internal/Guard.cs
+++ b/src/OpenTelemetry.Api/Internal/Guard.cs
@@ -14,11 +14,13 @@
 // limitations under the License.
 // </copyright>
 
+#pragma warning disable IDE0005 // Temporarily suppressing "Using directive is unnecessary" until other projects have been updated. See #3958.
 using System;
 using System.Diagnostics;
 using System.Globalization;
 using System.Runtime.CompilerServices;
 using System.Threading;
+#pragma warning restore IDE0005
 
 #if !NET6_0_OR_GREATER
 namespace System.Runtime.CompilerServices
diff --git a/src/OpenTelemetry.Exporter.Console/ConsoleActivityExporter.cs b/src/OpenTelemetry.Exporter.Console/ConsoleActivityExporter.cs
index 5594efc16..068757841 100644
--- a/src/OpenTelemetry.Exporter.Console/ConsoleActivityExporter.cs
+++ b/src/OpenTelemetry.Exporter.Console/ConsoleActivityExporter.cs
@@ -15,7 +15,6 @@
 // </copyright>
 
 using System.Diagnostics;
-using System.Linq;
 using OpenTelemetry.Resources;
 using OpenTelemetry.Trace;
 
diff --git a/src/OpenTelemetry.Exporter.Console/ConsoleExporterHelperExtensions.cs b/src/OpenTelemetry.Exporter.Console/ConsoleExporterHelperExtensions.cs
index 850533edf..4393e779c 100644
--- a/src/OpenTelemetry.Exporter.Console/ConsoleExporterHelperExtensions.cs
+++ b/src/OpenTelemetry.Exporter.Console/ConsoleExporterHelperExtensions.cs
@@ -14,7 +14,6 @@
 // limitations under the License.
 // </copyright>
 
-using System;
 using Microsoft.Extensions.DependencyInjection;
 using Microsoft.Extensions.Options;
 using OpenTelemetry.Exporter;
diff --git a/src/OpenTelemetry.Exporter.Console/ConsoleExporterLoggingExtensions.cs b/src/OpenTelemetry.Exporter.Console/ConsoleExporterLoggingExtensions.cs
index 3754eb089..50b81a549 100644
--- a/src/OpenTelemetry.Exporter.Console/ConsoleExporterLoggingExtensions.cs
+++ b/src/OpenTelemetry.Exporter.Console/ConsoleExporterLoggingExtensions.cs
@@ -14,7 +14,6 @@
 // limitations under the License.
 // </copyright>
 
-using System;
 using OpenTelemetry.Exporter;
 using OpenTelemetry.Internal;
 
diff --git a/src/OpenTelemetry.Exporter.Console/ConsoleExporterMetricsExtensions.cs b/src/OpenTelemetry.Exporter.Console/ConsoleExporterMetricsExtensions.cs
index e0c84632f..2dee3c20f 100644
--- a/src/OpenTelemetry.Exporter.Console/ConsoleExporterMetricsExtensions.cs
+++ b/src/OpenTelemetry.Exporter.Console/ConsoleExporterMetricsExtensions.cs
@@ -14,8 +14,6 @@
 // limitations under the License.
 // </copyright>
 
-using System;
-using System.Threading;
 using Microsoft.Extensions.DependencyInjection;
 using Microsoft.Extensions.Options;
 using OpenTelemetry.Exporter;
diff --git a/src/OpenTelemetry.Exporter.Console/ConsoleExporterOutputTargets.cs b/src/OpenTelemetry.Exporter.Console/ConsoleExporterOutputTargets.cs
index 85a8da81e..fcb184d38 100644
--- a/src/OpenTelemetry.Exporter.Console/ConsoleExporterOutputTargets.cs
+++ b/src/OpenTelemetry.Exporter.Console/ConsoleExporterOutputTargets.cs
@@ -14,8 +14,6 @@
 // limitations under the License.
 // </copyright>
 
-using System;
-
 namespace OpenTelemetry.Exporter
 {
     [Flags]
diff --git a/src/OpenTelemetry.Exporter.Console/ConsoleLogRecordExporter.cs b/src/OpenTelemetry.Exporter.Console/ConsoleLogRecordExporter.cs
index 8cb88b810..cea2ba526 100644
--- a/src/OpenTelemetry.Exporter.Console/ConsoleLogRecordExporter.cs
+++ b/src/OpenTelemetry.Exporter.Console/ConsoleLogRecordExporter.cs
@@ -14,8 +14,6 @@
 // limitations under the License.
 // </copyright>
 
-using System;
-using System.Collections.Generic;
 using OpenTelemetry.Internal;
 using OpenTelemetry.Logs;
 using OpenTelemetry.Resources;
diff --git a/src/OpenTelemetry.Exporter.Console/ConsoleTagTransformer.cs b/src/OpenTelemetry.Exporter.Console/ConsoleTagTransformer.cs
index e87862e5b..a5a29588b 100644
--- a/src/OpenTelemetry.Exporter.Console/ConsoleTagTransformer.cs
+++ b/src/OpenTelemetry.Exporter.Console/ConsoleTagTransformer.cs
@@ -14,7 +14,6 @@
 // limitations under the License.
 // </copyright>
 
-using System;
 using OpenTelemetry.Internal;
 
 namespace OpenTelemetry.Exporter;
diff --git a/src/OpenTelemetry.Exporter.Console/OpenTelemetry.Exporter.Console.csproj b/src/OpenTelemetry.Exporter.Console/OpenTelemetry.Exporter.Console.csproj
index 849cc8c5d..f67383e6b 100644
--- a/src/OpenTelemetry.Exporter.Console/OpenTelemetry.Exporter.Console.csproj
+++ b/src/OpenTelemetry.Exporter.Console/OpenTelemetry.Exporter.Console.csproj
@@ -9,7 +9,6 @@
 
     <!-- this is temporary. will remove in future PR. -->
     <Nullable>disable</Nullable>
-    <ImplicitUsings>disable</ImplicitUsings>
   </PropertyGroup>
 
   <PropertyGroup>
diff --git a/src/OpenTelemetry.Exporter.InMemory/InMemoryExporter.cs b/src/OpenTelemetry.Exporter.InMemory/InMemoryExporter.cs
index c862379ca..2f940c7d6 100644
--- a/src/OpenTelemetry.Exporter.InMemory/InMemoryExporter.cs
+++ b/src/OpenTelemetry.Exporter.InMemory/InMemoryExporter.cs
@@ -14,9 +14,6 @@
 // limitations under the License.
 // </copyright>
 
-using System;
-using System.Collections.Generic;
-
 namespace OpenTelemetry.Exporter
 {
     public class InMemoryExporter<T> : BaseExporter<T>
diff --git a/src/OpenTelemetry.Exporter.InMemory/InMemoryExporterHelperExtensions.cs b/src/OpenTelemetry.Exporter.InMemory/InMemoryExporterHelperExtensions.cs
index 199ca33db..289ac2871 100644
--- a/src/OpenTelemetry.Exporter.InMemory/InMemoryExporterHelperExtensions.cs
+++ b/src/OpenTelemetry.Exporter.InMemory/InMemoryExporterHelperExtensions.cs
@@ -14,7 +14,6 @@
 // limitations under the License.
 // </copyright>
 
-using System.Collections.Generic;
 using System.Diagnostics;
 using OpenTelemetry.Exporter;
 using OpenTelemetry.Internal;
diff --git a/src/OpenTelemetry.Exporter.InMemory/InMemoryExporterLoggingExtensions.cs b/src/OpenTelemetry.Exporter.InMemory/InMemoryExporterLoggingExtensions.cs
index c0cea4de6..4b722830c 100644
--- a/src/OpenTelemetry.Exporter.InMemory/InMemoryExporterLoggingExtensions.cs
+++ b/src/OpenTelemetry.Exporter.InMemory/InMemoryExporterLoggingExtensions.cs
@@ -14,7 +14,6 @@
 // limitations under the License.
 // </copyright>
 
-using System.Collections.Generic;
 using OpenTelemetry.Exporter;
 using OpenTelemetry.Internal;
 
diff --git a/src/OpenTelemetry.Exporter.InMemory/InMemoryExporterMetricsExtensions.cs b/src/OpenTelemetry.Exporter.InMemory/InMemoryExporterMetricsExtensions.cs
index 56335d6a0..f2440daaa 100644
--- a/src/OpenTelemetry.Exporter.InMemory/InMemoryExporterMetricsExtensions.cs
+++ b/src/OpenTelemetry.Exporter.InMemory/InMemoryExporterMetricsExtensions.cs
@@ -14,9 +14,6 @@
 // limitations under the License.
 // </copyright>
 
-using System;
-using System.Collections.Generic;
-using System.Threading;
 using Microsoft.Extensions.DependencyInjection;
 using Microsoft.Extensions.Options;
 using OpenTelemetry.Exporter;
diff --git a/src/OpenTelemetry.Exporter.InMemory/MetricSnapshot.cs b/src/OpenTelemetry.Exporter.InMemory/MetricSnapshot.cs
index 635e35493..736980554 100644
--- a/src/OpenTelemetry.Exporter.InMemory/MetricSnapshot.cs
+++ b/src/OpenTelemetry.Exporter.InMemory/MetricSnapshot.cs
@@ -14,8 +14,6 @@
 // limitations under the License.
 // </copyright>
 
-using System.Collections.Generic;
-
 namespace OpenTelemetry.Metrics
 {
     /// <summary>
diff --git a/src/OpenTelemetry.Exporter.InMemory/OpenTelemetry.Exporter.InMemory.csproj b/src/OpenTelemetry.Exporter.InMemory/OpenTelemetry.Exporter.InMemory.csproj
index 35e1d93d3..20909e3de 100644
--- a/src/OpenTelemetry.Exporter.InMemory/OpenTelemetry.Exporter.InMemory.csproj
+++ b/src/OpenTelemetry.Exporter.InMemory/OpenTelemetry.Exporter.InMemory.csproj
@@ -9,7 +9,6 @@
 
     <!-- this is temporary. will remove in future PR. -->
     <Nullable>disable</Nullable>
-    <ImplicitUsings>disable</ImplicitUsings>
   </PropertyGroup>
 
   <PropertyGroup>
diff --git a/src/OpenTelemetry/Internal/OpenTelemetrySdkEventSource.cs b/src/OpenTelemetry/Internal/OpenTelemetrySdkEventSource.cs
index 063e2fcbe..efaa4d990 100644
--- a/src/OpenTelemetry/Internal/OpenTelemetrySdkEventSource.cs
+++ b/src/OpenTelemetry/Internal/OpenTelemetrySdkEventSource.cs
@@ -14,6 +14,7 @@
 // limitations under the License.
 // </copyright>
 
+#pragma warning disable IDE0005 // Temporarily suppressing "Using directive is unnecessary" until other projects have been updated. See #3958.
 using System;
 #if DEBUG
 using System.Collections.Generic;
@@ -22,6 +23,7 @@ using System.Linq;
 using System.Diagnostics;
 using System.Diagnostics.Tracing;
 using System.Security;
+#pragma warning restore IDE0005
 
 namespace OpenTelemetry.Internal
 {
diff --git a/src/OpenTelemetry/Internal/TagTransformer.cs b/src/OpenTelemetry/Internal/TagTransformer.cs
index f2a0cee9c..1766ed1a8 100644
--- a/src/OpenTelemetry/Internal/TagTransformer.cs
+++ b/src/OpenTelemetry/Internal/TagTransformer.cs
@@ -14,9 +14,11 @@
 // limitations under the License.
 // </copyright>
 
+#pragma warning disable IDE0005 // Temporarily suppressing "Using directive is unnecessary" until other projects have been updated. See #3958.
 using System;
 using System.Collections.Generic;
 using System.Linq;
+#pragma warning restore IDE0005
 
 namespace OpenTelemetry.Internal;