open-telemetry
/
opentelemetry-dotnet
mirror of https://github.com/open-telemetry/opentelemetry-dotnet.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix and disable HttpWebRequest test (#797)

This commit is contained in:
Cijo Thomas 2020-07-10 08:55:41 -07:00 committed by GitHub
parent d237438115
commit 4abc57d02e
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 8 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
test/OpenTelemetry.Instrumentation.Dependencies.Tests/HttpWebRequestTests.Basic.netfx.cs
View File

@ -171,14 +171,15 @@ namespace OpenTelemetry.Instrumentation.Dependencies.Tests
Assert.Equal(0, activityProcessor.Invocations.Count);
}
[Fact]
[Fact(Skip = "HttpWebRequest instrumentation has no way to pass options and no ability to filter now.")]
public async Task HttpDependenciesInstrumentationFiltersOutRequests()
{
var spanProcessor = new Mock<SpanProcessor>();
var tracer = TracerFactory.Create(b => b
.AddProcessorPipeline(p => p.AddProcessor(_ => spanProcessor.Object)))
.GetTracer(null);
var activityProcessor = new Mock<ActivityProcessor>();
using var shutdownSignal = OpenTelemetrySdk.EnableOpenTelemetry(b =>
{
b.AddProcessorPipeline(c => c.AddProcessor(ap => activityProcessor.Object));
b.AddHttpWebRequestDependencyInstrumentation();
});
var options = new HttpClientInstrumentationOptions((activityName, arg1, _)
=> !(activityName == HttpWebRequestActivitySource.ActivityName &&
@ -188,7 +189,7 @@ namespace OpenTelemetry.Instrumentation.Dependencies.Tests
using var c = new HttpClient();
await c.GetAsync(this.url);
Assert.Equal(0, spanProcessor.Invocations.Count);
Assert.Equal(0, activityProcessor.Invocations.Count);
}
}
}