open-telemetry
/
opentelemetry-dotnet
mirror of https://github.com/open-telemetry/opentelemetry-dotnet.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Removing some remaining references to net46- support (#2293)

This commit is contained in:
Michael Maxwell 2021-08-30 17:32:06 -07:00 committed by GitHub
parent 69c6bf2de9
commit 4d3756e205
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
6 changed files with 6 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
CONTRIBUTING.md
View File

@ -51,13 +51,13 @@ On all platforms, the minimum requirements are:
* Visual Studio for Mac or Visual Studio Code
Mono might be required by your IDE but is not required by this project. This is
because unit tests targeting .NET Framework (i.e: `net46`) are disabled outside
because unit tests targeting .NET Framework (i.e: `net461`) are disabled outside
of Windows.
### Windows
* Visual Studio 2017+ or Visual Studio Code
* .NET Framework 4.6+
* .NET Framework 4.6.1+
### Public API

2
src/OpenTelemetry.Api/OpenTelemetry.Api.csproj
View File

@ -8,7 +8,7 @@
<MinVerTagPrefix>core-</MinVerTagPrefix>
</PropertyGroup>
<!--Do not run ApiCopmat for net461 as this is newly added. There is no existing contract for net461 against which we could compare the implementation.
<!--Do not run ApiCompat for net461 as this is newly added. There is no existing contract for net461 against which we could compare the implementation.
Remove this property once we have released a stable net461 version.-->
<PropertyGroup Condition="'$(TargetFramework)' == 'net461'">
<RunApiCompat>false</RunApiCompat>

2
src/OpenTelemetry.Exporter.Jaeger/OpenTelemetry.Exporter.Jaeger.csproj
View File

@ -7,7 +7,7 @@
<MinVerTagPrefix>core-</MinVerTagPrefix>
</PropertyGroup>
<!--Do not run ApiCopmat for net461 as this is newly added. There is no existing contract for net461 against which we could compare the implementation.
<!--Do not run ApiCompat for net461 as this is newly added. There is no existing contract for net461 against which we could compare the implementation.
Remove this property once we have released a stable net461 version.-->
<PropertyGroup Condition="'$(TargetFramework)' == 'net461'">
<RunApiCompat>false</RunApiCompat>

2
src/OpenTelemetry.Exporter.Jaeger/README.md
View File

@ -14,7 +14,7 @@ the Compact Thrift API port, and as such only supports Thrift over UDP.
This package supports all the officially supported versions of [.NET
Core](https://dotnet.microsoft.com/download/dotnet-core).
For .NET Framework, versions 4.6 and above are supported.
For .NET Framework, versions 4.6.1 and above are supported.
## Prerequisite

2
src/OpenTelemetry.Exporter.OpenTelemetryProtocol/OpenTelemetry.Exporter.OpenTelemetryProtocol.csproj
View File

@ -6,7 +6,7 @@
<MinVerTagPrefix>core-</MinVerTagPrefix>
</PropertyGroup>
<!--Do not run ApiCopmat for net461 as this is newly added. There is no existing contract for net461 against which we could compare the implementation.
<!--Do not run ApiCompat for net461 as this is newly added. There is no existing contract for net461 against which we could compare the implementation.
Remove this property once we have released a stable net461 version.-->
<PropertyGroup Condition="'$(TargetFramework)' == 'net461'">
<RunApiCompat>false</RunApiCompat>

3
src/OpenTelemetry.Exporter.Prometheus/Implementation/PrometheusMetricBuilder.cs
View File

@ -19,9 +19,6 @@ using System.Globalization;
using System.IO;
using System.Linq;
using System.Text;
#if NET452
using OpenTelemetry.Internal;
#endif
namespace OpenTelemetry.Exporter.Prometheus.Implementation
{