open-telemetry
/
opentelemetry-dotnet
mirror of https://github.com/open-telemetry/opentelemetry-dotnet.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fixing zipkin payload (#1112) 

* Fixing zipkin payload

* adding more types to convert to string

* adding some comments

Co-authored-by: Cijo Thomas <cithomas@microsoft.com>
This commit is contained in:
Eddy Nakamura 2020-08-20 20:37:10 -03:00 committed by GitHub
parent cd435cdd4c
commit 595c3bd0c3
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 25 additions and 20 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

45
src/OpenTelemetry.Exporter.Zipkin/Implementation/ZipkinSpan.cs
View File

@ -18,7 +18,9 @@ using System.Collections.Generic;
#if NET452
using Newtonsoft.Json;
#else
using System.Globalization;
using System.Text.Json;
using System.Threading;
#endif
using OpenTelemetry.Internal;
@ -280,37 +282,40 @@ namespace OpenTelemetry.Exporter.Zipkin.Implementation
writer.WritePropertyName("tags");
writer.WriteStartObject();
// this will be used when we convert int, double, int[], double[] to string
var originalUICulture = Thread.CurrentThread.CurrentUICulture;
Thread.CurrentThread.CurrentUICulture = CultureInfo.InvariantCulture;
foreach (var tag in this.Tags.Value)
{
if (tag.Value is int intValue)
switch (tag.Value)
{
writer.WriteNumber(tag.Key, intValue);
}
else if (tag.Value is bool boolVal)
{
writer.WriteBoolean(tag.Key, boolVal);
}
else if (tag.Value is double doubleVal)
{
writer.WriteNumber(tag.Key, doubleVal);
}
else if (tag.Value is string stringVal)
{
writer.WriteString(tag.Key, stringVal);
}
else
{
// Should we try to convert to string? Or
// just drop it?
writer.WriteString(tag.Key, tag.Value.ToString());
case string stringVal:
writer.WriteString(tag.Key, stringVal);
break;
case int[] intArrayValue:
writer.WriteString(tag.Key, string.Join(",", intArrayValue));
break;
case double[] doubleArrayValue:
writer.WriteString(tag.Key, string.Join(",", doubleArrayValue));
break;
case bool[] boolArrayValue:
writer.WriteString(tag.Key, string.Join(",", boolArrayValue));
break;
default:
writer.WriteString(tag.Key, tag.Value.ToString());
break;
}
}
Thread.CurrentThread.CurrentUICulture = originalUICulture;
writer.WriteEndObject();
}
writer.WriteEndObject();
}
#endif
}
}