open-telemetry
/
opentelemetry-dotnet
mirror of https://github.com/open-telemetry/opentelemetry-dotnet.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Refactor AspNetCore Metrics instrumentation (#2998)

This commit is contained in:
Utkarsh Umesan Pillai 2022-03-08 20:23:27 -08:00 committed by GitHub
parent 98cb28974a
commit 5bb9f26100
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 6 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
src/OpenTelemetry.Instrumentation.AspNetCore/Implementation/HttpInMetricsListener.cs
View File

@ -14,7 +14,6 @@
// limitations under the License.
// </copyright>
using System.Collections.Generic;
using System.Diagnostics;
using System.Diagnostics.Metrics;
using Microsoft.AspNetCore.Http;
@ -26,8 +25,7 @@ namespace OpenTelemetry.Instrumentation.AspNetCore.Implementation
{
private readonly PropertyFetcher<HttpContext> stopContextFetcher = new PropertyFetcher<HttpContext>("HttpContext");
private readonly Meter meter;
private Histogram<double> httpServerDuration;
private readonly Histogram<double> httpServerDuration;
public HttpInMetricsListener(string name, Meter meter)
: base(name)
@ -55,12 +53,12 @@ namespace OpenTelemetry.Instrumentation.AspNetCore.Implementation
// TODO: This is just a minimal set of attributes. See the spec for additional attributes:
// https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/metrics/semantic_conventions/http-metrics.md#http-server
var tags = new KeyValuePair<string, object>[]
var tags = new TagList
{
new KeyValuePair<string, object>(SemanticConventions.AttributeHttpMethod, context.Request.Method),
new KeyValuePair<string, object>(SemanticConventions.AttributeHttpScheme, context.Request.Scheme),
new KeyValuePair<string, object>(SemanticConventions.AttributeHttpStatusCode, context.Response.StatusCode),
new KeyValuePair<string, object>(SemanticConventions.AttributeHttpFlavor, context.Request.Protocol),
{ SemanticConventions.AttributeHttpMethod, context.Request.Method },
{ SemanticConventions.AttributeHttpScheme, context.Request.Scheme },
{ SemanticConventions.AttributeHttpStatusCode, context.Response.StatusCode },
{ SemanticConventions.AttributeHttpFlavor, context.Request.Protocol },
};
this.httpServerDuration.Record(activity.Duration.TotalMilliseconds, tags);