open-telemetry
/
opentelemetry-dotnet
mirror of https://github.com/open-telemetry/opentelemetry-dotnet.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Remove non-working example from readme (#621) 

* Remove non-working example from readme

* revert unintended changes

Co-authored-by: Sergey Kanzhelev <S.Kanzhelev@live.com>
This commit is contained in:
Cijo Thomas 2020-04-22 18:07:59 -07:00 committed by GitHub
parent 8a22eaf81e
commit 8983b41255
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 8 additions and 38 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

32
README.md
View File

@ -175,37 +175,7 @@ using (tracer.StartActiveSpan("incoming HTTP request", SpanKind.Server, out var
### Context propagation out of process
When instrumenting transport-layer operations, instrumentation should support context propagation.
```csharp
// this extracts W3C trace-context from incoming HTTP request
// context may be valid if present and correct in the headers
// or invalid if there was no context (or it was not valid)
// instrumentation code should not care about it
var context = tracer.TextFormat.Extract(incomingRequest.Headers, (headers, name) => headers[name]);
var incomingSpan = tracer.StartSpan("incoming http request", context, SpanKind.Server);
var outgoingRequest = new HttpRequestMessage(HttpMethod.Get, "http://microsoft.com");
var outgoingSpan = tracer.StartSpan("outgoing http request", SpanKind.Client);
// now that we have outgoing span, we can inject it's context
// Note that if there is no SDK configured, tracer is noop -
// it creates noop spans with invalid context. we should not propagate it.
if (outgoingSpan.Context.IsValid)
{
tracer.TextFormat.Inject(
outgoingSpan.Context,
outgoingRequest.Headers,
(headers, name, value) => headers.Add(name, value));
}
// make outgoing call
// ...
outgoingSpan.End();
incomingSpan.End();
```
Examples will be added once [Global Propagators API is added.](https://github.com/open-telemetry/opentelemetry-dotnet/issues/581)
### Auto-adapter implementation for Activity/DiagnosticSource

14
src/OpenTelemetry/Trace/TracerSdk.cs
View File

@ -79,16 +79,16 @@ namespace OpenTelemetry.Trace
}
/// <inheritdoc/>
public override TelemetrySpan StartSpan(string operationName, TelemetrySpan parent, SpanKind kind, SpanCreationOptions options)
public override TelemetrySpan StartSpan(string operationName, TelemetrySpan parentSpan, SpanKind kind, SpanCreationOptions options)
{
if (parent == null)
if (parentSpan == null)
{
parent = this.CurrentSpan;
parentSpan = this.CurrentSpan;
}
return SpanSdk.CreateFromParentSpan(
operationName,
parent,
parentSpan,
kind,
options,
this.sampler,
@ -98,13 +98,13 @@ namespace OpenTelemetry.Trace
}
/// <inheritdoc/>
public override TelemetrySpan StartSpan(string operationName, in SpanContext parent, SpanKind kind, SpanCreationOptions options)
public override TelemetrySpan StartSpan(string operationName, in SpanContext parentContext, SpanKind kind, SpanCreationOptions options)
{
if (parent.IsValid)
if (parentContext.IsValid)
{
return SpanSdk.CreateFromParentContext(
operationName,
parent,
parentContext,
kind,
options,
this.sampler,