From 97f21802a39d6ce85773f0ef3c04e9bd1d30290f Mon Sep 17 00:00:00 2001 From: Cijo Thomas Date: Thu, 10 Mar 2022 10:52:25 -0800 Subject: [PATCH] Modify example asp.net core app to config prometheus options (#2988) --- examples/AspNetCore/Startup.cs | 2 ++ examples/AspNetCore/appsettings.json | 3 +++ .../Implementation/PrometheusExporterHttpServer.cs | 2 +- 3 files changed, 6 insertions(+), 1 deletion(-) diff --git a/examples/AspNetCore/Startup.cs b/examples/AspNetCore/Startup.cs index 9a60cd3b0..ffb15e824 100644 --- a/examples/AspNetCore/Startup.cs +++ b/examples/AspNetCore/Startup.cs @@ -147,6 +147,8 @@ namespace Examples.AspNetCore break; } }); + + services.Configure(this.Configuration.GetSection("Prometheus")); } public void Configure(IApplicationBuilder app, IWebHostEnvironment env) diff --git a/examples/AspNetCore/appsettings.json b/examples/AspNetCore/appsettings.json index e2826c577..ae7b27441 100644 --- a/examples/AspNetCore/appsettings.json +++ b/examples/AspNetCore/appsettings.json @@ -17,6 +17,9 @@ "Endpoint": "http://localhost:14268", "Protocol": "UdpCompactThrift" }, + "Prometheus": { + "ScrapeResponseCacheDurationMilliseconds": 5000 + }, "Zipkin": { "ServiceName": "zipkin-test", "Endpoint": "http://localhost:9411/api/v2/spans" diff --git a/src/OpenTelemetry.Exporter.Prometheus/Implementation/PrometheusExporterHttpServer.cs b/src/OpenTelemetry.Exporter.Prometheus/Implementation/PrometheusExporterHttpServer.cs index b84ad3f17..7e074e1de 100644 --- a/src/OpenTelemetry.Exporter.Prometheus/Implementation/PrometheusExporterHttpServer.cs +++ b/src/OpenTelemetry.Exporter.Prometheus/Implementation/PrometheusExporterHttpServer.cs @@ -66,7 +66,7 @@ namespace OpenTelemetry.Exporter.Prometheus } /// - /// Start exporter. + /// Start Http Server. /// /// An optional that can be used to stop the HTTP server. public void Start(CancellationToken token = default)