From 9b5c4836518ae3838f9f8491c16b3cab63c4c21c Mon Sep 17 00:00:00 2001 From: Mikel Blanchard Date: Thu, 1 Jun 2023 12:27:38 -0700 Subject: [PATCH] [hosting-logs] Don't register ILogger when calling WithLogging (#4535) --- .../OpenTelemetryBuilder.cs | 14 ++------------ 1 file changed, 2 insertions(+), 12 deletions(-) diff --git a/src/OpenTelemetry.Extensions.Hosting/OpenTelemetryBuilder.cs b/src/OpenTelemetry.Extensions.Hosting/OpenTelemetryBuilder.cs index b0cc40ead..1f50f7663 100644 --- a/src/OpenTelemetry.Extensions.Hosting/OpenTelemetryBuilder.cs +++ b/src/OpenTelemetry.Extensions.Hosting/OpenTelemetryBuilder.cs @@ -15,7 +15,6 @@ // using Microsoft.Extensions.DependencyInjection; -using Microsoft.Extensions.Logging; using OpenTelemetry.Internal; using OpenTelemetry.Logs; using OpenTelemetry.Metrics; @@ -141,15 +140,9 @@ public sealed class OpenTelemetryBuilder /// Adds logging services into the builder. /// /// - /// Notes: - /// - /// This is safe to be called multiple times and by library authors. + /// Note: This is safe to be called multiple times and by library authors. /// Only a single will be created for a given - /// . - /// This operation enables integration - /// automatically by calling . - /// + /// . /// /// The supplied for chaining /// calls. @@ -168,9 +161,6 @@ public sealed class OpenTelemetryBuilder { Guard.ThrowIfNull(configure); - // Note: This enables ILogger integration - this.Services.AddLogging().AddOpenTelemetry(); - var builder = new LoggerProviderBuilderBase(this.Services); configure(builder);