open-telemetry
/
opentelemetry-dotnet
mirror of https://github.com/open-telemetry/opentelemetry-dotnet.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Updated LogLevel for events logging exceptions (#1635) 

Co-authored-by: Cijo Thomas <cithomas@microsoft.com>
This commit is contained in:
Utkarsh Umesan Pillai 2020-12-01 16:36:37 -08:00 committed by GitHub
parent 479fb50f77
commit a01063cdbc
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/OpenTelemetry/Internal/OpenTelemetrySdkEventSource.cs
View File

@ -38,7 +38,7 @@ namespace OpenTelemetry.Internal
[NonEvent]
public void SpanProcessorException(string evnt, Exception ex)
{
if (this.IsEnabled(EventLevel.Warning, (EventKeywords)(-1)))
if (this.IsEnabled(EventLevel.Error, (EventKeywords)(-1)))
{
this.SpanProcessorException(evnt, ex.ToInvariantString());
}
@ -119,7 +119,7 @@ namespace OpenTelemetry.Internal
[NonEvent]
public void TracerProviderException(string evnt, Exception ex)
{
if (this.IsEnabled(EventLevel.Warning, (EventKeywords)(-1)))
if (this.IsEnabled(EventLevel.Error, (EventKeywords)(-1)))
{
this.TracerProviderException(evnt, ex.ToInvariantString());
}
@ -143,7 +143,7 @@ namespace OpenTelemetry.Internal
this.WriteEvent(3, exportResult.ToString());
}
[Event(4, Message = "Unknown error in SpanProcessor event '{0}': '{1}'.", Level = EventLevel.Warning)]
[Event(4, Message = "Unknown error in SpanProcessor event '{0}': '{1}'.", Level = EventLevel.Error)]
public void SpanProcessorException(string evnt, string ex)
{
this.WriteEvent(4, evnt, ex);
@ -281,7 +281,7 @@ namespace OpenTelemetry.Internal
this.WriteEvent(27, resourceDetector, issue);
}
[Event(28, Message = "Unknown error in TracerProvider '{0}': '{1}'.", Level = EventLevel.Warning)]
[Event(28, Message = "Unknown error in TracerProvider '{0}': '{1}'.", Level = EventLevel.Error)]
public void TracerProviderException(string evnt, string ex)
{
this.WriteEvent(28, evnt, ex);

2
src/OpenTelemetry/SimpleExportProcessor.cs
View File

@ -48,7 +48,7 @@ namespace OpenTelemetry
}
catch (Exception ex)
{
OpenTelemetrySdkEventSource.Log.SpanProcessorException(nameof(this.OnEnd), ex);
OpenTelemetrySdkEventSource.Log.SpanProcessorException(nameof(this.OnExport), ex);
}
}
}