From a8c579757dc8dcb483d3b7c13127286f82ad8ce7 Mon Sep 17 00:00:00 2001 From: Eddy Nakamura Date: Thu, 29 Oct 2020 15:53:49 -0300 Subject: [PATCH] Jaeger Process is internal (#1421) * Jaeger Process is internal * updating changelog --- src/OpenTelemetry.Exporter.Jaeger/CHANGELOG.md | 3 +++ .../{ => Implementation}/Process.cs | 5 ++--- src/OpenTelemetry.Exporter.Jaeger/JaegerExporter.cs | 3 ++- test/Benchmarks/Exporter/JaegerExporterBenchmarks.cs | 2 +- 4 files changed, 8 insertions(+), 5 deletions(-) rename src/OpenTelemetry.Exporter.Jaeger/{ => Implementation}/Process.cs (96%) diff --git a/src/OpenTelemetry.Exporter.Jaeger/CHANGELOG.md b/src/OpenTelemetry.Exporter.Jaeger/CHANGELOG.md index ddf67aacd..f82c93604 100644 --- a/src/OpenTelemetry.Exporter.Jaeger/CHANGELOG.md +++ b/src/OpenTelemetry.Exporter.Jaeger/CHANGELOG.md @@ -2,6 +2,9 @@ ## Unreleased +* Moving Jaeger Process from public to internal. + ([#1421](https://github.com/open-telemetry/opentelemetry-dotnet/pull/1421)) + ## 0.7.0-beta.1 Released 2020-Oct-16 diff --git a/src/OpenTelemetry.Exporter.Jaeger/Process.cs b/src/OpenTelemetry.Exporter.Jaeger/Implementation/Process.cs similarity index 96% rename from src/OpenTelemetry.Exporter.Jaeger/Process.cs rename to src/OpenTelemetry.Exporter.Jaeger/Implementation/Process.cs index 7501d266f..b8e7cee3d 100644 --- a/src/OpenTelemetry.Exporter.Jaeger/Process.cs +++ b/src/OpenTelemetry.Exporter.Jaeger/Implementation/Process.cs @@ -17,13 +17,12 @@ using System.Collections.Generic; using System.Linq; using System.Text; -using OpenTelemetry.Exporter.Jaeger.Implementation; using Thrift.Protocol; using Thrift.Protocol.Entities; -namespace OpenTelemetry.Exporter.Jaeger +namespace OpenTelemetry.Exporter.Jaeger.Implementation { - public class Process + internal class Process { public Process(string serviceName) { diff --git a/src/OpenTelemetry.Exporter.Jaeger/JaegerExporter.cs b/src/OpenTelemetry.Exporter.Jaeger/JaegerExporter.cs index 991853da7..4f89a3e8e 100644 --- a/src/OpenTelemetry.Exporter.Jaeger/JaegerExporter.cs +++ b/src/OpenTelemetry.Exporter.Jaeger/JaegerExporter.cs @@ -23,6 +23,7 @@ using OpenTelemetry.Resources; using OpenTelemetry.Trace; using Thrift.Protocol; using Thrift.Transport; +using Process = OpenTelemetry.Exporter.Jaeger.Implementation.Process; namespace OpenTelemetry.Exporter.Jaeger { @@ -55,7 +56,7 @@ namespace OpenTelemetry.Exporter.Jaeger this.Process = new Process(options.ServiceName, options.ProcessTags); } - public Process Process { get; internal set; } + internal Process Process { get; set; } internal Dictionary CurrentBatches { get; } = new Dictionary(); diff --git a/test/Benchmarks/Exporter/JaegerExporterBenchmarks.cs b/test/Benchmarks/Exporter/JaegerExporterBenchmarks.cs index b474536c9..60e81ca51 100644 --- a/test/Benchmarks/Exporter/JaegerExporterBenchmarks.cs +++ b/test/Benchmarks/Exporter/JaegerExporterBenchmarks.cs @@ -50,7 +50,7 @@ namespace Benchmarks.Exporter new JaegerExporterOptions(), new BlackHoleTransport()) { - Process = new OpenTelemetry.Exporter.Jaeger.Process("TestService"), + Process = new OpenTelemetry.Exporter.Jaeger.Implementation.Process("TestService"), }; for (int i = 0; i < this.NumberOfBatches; i++)