From b6d45ccb4631cab2b3727b5be8cfa9e1dc188658 Mon Sep 17 00:00:00 2001 From: Cijo Thomas Date: Sat, 29 Jan 2022 17:20:11 -0800 Subject: [PATCH] Minor improvement to duplicate instrument test (#2833) --- .../Metrics/MetricAPITest.cs | 27 ++++++++++++------- 1 file changed, 17 insertions(+), 10 deletions(-) diff --git a/test/OpenTelemetry.Tests/Metrics/MetricAPITest.cs b/test/OpenTelemetry.Tests/Metrics/MetricAPITest.cs index 3fa313073..6c08490aa 100644 --- a/test/OpenTelemetry.Tests/Metrics/MetricAPITest.cs +++ b/test/OpenTelemetry.Tests/Metrics/MetricAPITest.cs @@ -171,21 +171,28 @@ namespace OpenTelemetry.Metrics.Tests using var meterProvider = meterProviderBuilder.Build(); - // Expecting one metric stream. var counterLong = meter.CreateCounter("name1"); + var anotherCounterSameName = meter.CreateCounter("name1"); + counterLong.Add(10); + anotherCounterSameName.Add(20); + counterLong.Add(10); + anotherCounterSameName.Add(20); + meterProvider.ForceFlush(MaxTimeToAllowForFlush); Assert.Single(exportedItems); - // The following will be ignored as - // metric of same name exists. - // Metric stream will remain one. - var anotherCounterSameName = meter.CreateCounter("name1"); - anotherCounterSameName.Add(10); - counterLong.Add(10); - exportedItems.Clear(); - meterProvider.ForceFlush(MaxTimeToAllowForFlush); - Assert.Single(exportedItems); + var metric = exportedItems[0]; + Assert.Equal("name1", metric.Name); + List metricPoints = new List(); + foreach (ref readonly var mp in metric.GetMetricPoints()) + { + metricPoints.Add(mp); + } + + Assert.Single(metricPoints); + var metricPoint1 = metricPoints[0]; + Assert.Equal(20, metricPoint1.GetSumLong()); } [Theory]