From be72b175704ecfa4cc4ee1be2c20c3d8e645c7a1 Mon Sep 17 00:00:00 2001 From: Eddy Nakamura Date: Wed, 11 Nov 2020 21:54:48 -0300 Subject: [PATCH] Updating Jaeger tags based on spec (#1513) * Updating Jaeger tags based on spec * updating changelog Co-authored-by: Cijo Thomas --- src/OpenTelemetry.Exporter.Jaeger/CHANGELOG.md | 4 ++++ .../Implementation/JaegerActivityExtensions.cs | 4 ++-- .../Implementation/JaegerActivityConversionTest.cs | 2 +- 3 files changed, 7 insertions(+), 3 deletions(-) diff --git a/src/OpenTelemetry.Exporter.Jaeger/CHANGELOG.md b/src/OpenTelemetry.Exporter.Jaeger/CHANGELOG.md index 224f43ae6..3fad0ec95 100644 --- a/src/OpenTelemetry.Exporter.Jaeger/CHANGELOG.md +++ b/src/OpenTelemetry.Exporter.Jaeger/CHANGELOG.md @@ -2,6 +2,10 @@ ## Unreleased +* Jaeger tags used for InstrumentationLibrary changed from library.name, + library.version to otel.library.name, otel.library.version respectively. + ([#1513](https://github.com/open-telemetry/opentelemetry-dotnet/pull/1513)) + ## 0.8.0-beta.1 Released 2020-Nov-5 diff --git a/src/OpenTelemetry.Exporter.Jaeger/Implementation/JaegerActivityExtensions.cs b/src/OpenTelemetry.Exporter.Jaeger/Implementation/JaegerActivityExtensions.cs index cb5f2fa07..036393127 100644 --- a/src/OpenTelemetry.Exporter.Jaeger/Implementation/JaegerActivityExtensions.cs +++ b/src/OpenTelemetry.Exporter.Jaeger/Implementation/JaegerActivityExtensions.cs @@ -95,10 +95,10 @@ namespace OpenTelemetry.Exporter.Jaeger.Implementation var activitySource = activity.Source; if (!string.IsNullOrEmpty(activitySource.Name)) { - PooledList.Add(ref jaegerTags.Tags, new JaegerTag("library.name", JaegerTagType.STRING, vStr: activitySource.Name)); + PooledList.Add(ref jaegerTags.Tags, new JaegerTag("otel.library.name", JaegerTagType.STRING, vStr: activitySource.Name)); if (!string.IsNullOrEmpty(activitySource.Version)) { - PooledList.Add(ref jaegerTags.Tags, new JaegerTag("library.version", JaegerTagType.STRING, vStr: activitySource.Version)); + PooledList.Add(ref jaegerTags.Tags, new JaegerTag("otel.library.version", JaegerTagType.STRING, vStr: activitySource.Version)); } } diff --git a/test/OpenTelemetry.Exporter.Jaeger.Tests/Implementation/JaegerActivityConversionTest.cs b/test/OpenTelemetry.Exporter.Jaeger.Tests/Implementation/JaegerActivityConversionTest.cs index c73ec5abd..2c83ce810 100644 --- a/test/OpenTelemetry.Exporter.Jaeger.Tests/Implementation/JaegerActivityConversionTest.cs +++ b/test/OpenTelemetry.Exporter.Jaeger.Tests/Implementation/JaegerActivityConversionTest.cs @@ -327,7 +327,7 @@ namespace OpenTelemetry.Exporter.Jaeger.Tests.Implementation // The last tag should be library.name in this case tag = tags[tags.Length - 1]; Assert.Equal(JaegerTagType.STRING, tag.VType); - Assert.Equal("library.name", tag.Key); + Assert.Equal("otel.library.name", tag.Key); Assert.Equal(nameof(CreateTestActivity), tag.VStr); var logs = jaegerSpan.Logs.ToArray();