From cb0c161a897a6af2b35d4af6a7181f8f2aace9fa Mon Sep 17 00:00:00 2001 From: Cijo Thomas Date: Fri, 4 Sep 2020 12:14:13 -0700 Subject: [PATCH] ParentBasedSampler fix checking if root or not (#1237) * AspNet Instrumentation docs * Revert "AspNet Instrumentation docs" This reverts commit 4cbb620533ed06bc74a70c3f24bfcf289ff8e12c. * Modify ParentBasedSampler to determine if root based on parentcontext being default * traceid --- src/OpenTelemetry/Trace/ParentBasedSampler.cs | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/OpenTelemetry/Trace/ParentBasedSampler.cs b/src/OpenTelemetry/Trace/ParentBasedSampler.cs index e4e39fc0c..a9381db3f 100644 --- a/src/OpenTelemetry/Trace/ParentBasedSampler.cs +++ b/src/OpenTelemetry/Trace/ParentBasedSampler.cs @@ -41,8 +41,7 @@ namespace OpenTelemetry.Trace public override SamplingResult ShouldSample(in SamplingParameters samplingParameters) { var parentContext = samplingParameters.ParentContext; - if (/* TODO: TraceId is always provided due to AutoGenerateRootContextTraceId. That is being removed in RC1 and this can be put back. - parentContext.TraceId == default ||*/ parentContext.SpanId == default) + if (parentContext.TraceId == default) { // If no parent, use the delegate to determine sampling. return this.delegateSampler.ShouldSample(samplingParameters);