open-telemetry
/
opentelemetry-dotnet
mirror of https://github.com/open-telemetry/opentelemetry-dotnet.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Adding array of primitives to TelemetrySpan (#999) 

* Adding array of primitives to TelemetrySpan

* updating tests

* removing baggage methods
This commit is contained in:
Eddy Nakamura 2020-08-04 17:57:48 -03:00 committed by GitHub
parent 80edb939e4
commit da8cd0d5c8
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 72 additions and 23 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

53
src/OpenTelemetry.Api/Trace/TelemetrySpan.cs
View File

@ -15,7 +15,6 @@
// </copyright>
using System;
using System.Collections;
using System.Collections.Generic;
using System.Diagnostics;
using System.Runtime.CompilerServices;
@ -149,7 +148,57 @@ namespace OpenTelemetry.Trace
return this;
}
// TODO: SetAttribute(string key, array of primitives)
/// <summary>
/// Sets a new attribute on the span.
/// </summary>
/// <param name="key">Attribute key.</param>
/// <param name="values">Attribute values.</param>
/// <returns>The <see cref="TelemetrySpan"/> instance for chaining.</returns>
[MethodImpl(MethodImplOptions.AggressiveInlining)]
public TelemetrySpan SetAttribute(string key, string[] values)
{
this.Activity?.SetTag(key, values);
return this;
}
/// <summary>
/// Sets a new attribute on the span.
/// </summary>
/// <param name="key">Attribute key.</param>
/// <param name="values">Attribute values.</param>
/// <returns>The <see cref="TelemetrySpan"/> instance for chaining.</returns>
[MethodImpl(MethodImplOptions.AggressiveInlining)]
public TelemetrySpan SetAttribute(string key, int[] values)
{
this.Activity?.SetTag(key, values);
return this;
}
/// <summary>
/// Sets a new attribute on the span.
/// </summary>
/// <param name="key">Attribute key.</param>
/// <param name="values">Attribute values.</param>
/// <returns>The <see cref="TelemetrySpan"/> instance for chaining.</returns>
[MethodImpl(MethodImplOptions.AggressiveInlining)]
public TelemetrySpan SetAttribute(string key, bool[] values)
{
this.Activity?.SetTag(key, values);
return this;
}
/// <summary>
/// Sets a new attribute on the span.
/// </summary>
/// <param name="key">Attribute key.</param>
/// <param name="values">Attribute values.</param>
/// <returns>The <see cref="TelemetrySpan"/> instance for chaining.</returns>
[MethodImpl(MethodImplOptions.AggressiveInlining)]
public TelemetrySpan SetAttribute(string key, double[] values)
{
this.Activity?.SetTag(key, values);
return this;
}
/// <summary>
/// Adds a single Event to the <see cref="TelemetrySpan"/>.

6
src/OpenTelemetry.Shims.OpenTracing/SpanShim.cs
View File

@ -188,7 +188,7 @@ namespace OpenTelemetry.Shims.OpenTracing
}
else
{
this.Span.SetAttribute(key, value.ToString());
this.Span.SetAttribute(key, value);
}
return this;
@ -202,7 +202,7 @@ namespace OpenTelemetry.Shims.OpenTracing
throw new ArgumentNullException(nameof(key));
}
this.Span.SetAttribute(key, value.ToString());
this.Span.SetAttribute(key, value);
return this;
}
@ -214,7 +214,7 @@ namespace OpenTelemetry.Shims.OpenTracing
throw new ArgumentNullException(nameof(key));
}
this.Span.SetAttribute(key, value.ToString());
this.Span.SetAttribute(key, value);
return this;
}

36
test/OpenTelemetry.Shims.OpenTracing.Tests/SpanShimTests.cs
View File

@ -228,8 +228,8 @@ namespace OpenTelemetry.Shims.OpenTracing.Tests
shim.SetTag("foo", true);
shim.SetTag(global::OpenTracing.Tag.Tags.Error.Key, true);
Assert.Equal("foo", shim.Span.Activity.Tags.First().Key);
Assert.True(bool.Parse(shim.Span.Activity.Tags.First().Value));
Assert.Equal("foo", shim.Span.Activity.TagObjects.First().Key);
Assert.True((bool)shim.Span.Activity.TagObjects.First().Value);
// A boolean tag named "error" is a special case that must be checked
Assert.Equal(Status.Unknown, shim.Span.Activity.GetStatus());
@ -249,9 +249,9 @@ namespace OpenTelemetry.Shims.OpenTracing.Tests
shim.SetTag("foo", 1);
Assert.Single(shim.Span.Activity.Tags);
Assert.Equal("foo", shim.Span.Activity.Tags.First().Key);
Assert.Equal(1L, int.Parse(shim.Span.Activity.Tags.First().Value));
Assert.Single(shim.Span.Activity.TagObjects);
Assert.Equal("foo", shim.Span.Activity.TagObjects.First().Key);
Assert.Equal(1L, (int)shim.Span.Activity.TagObjects.First().Value);
}
[Fact]
@ -264,9 +264,9 @@ namespace OpenTelemetry.Shims.OpenTracing.Tests
shim.SetTag("foo", 1D);
Assert.Single(shim.Span.Activity.Tags);
Assert.Equal("foo", shim.Span.Activity.Tags.First().Key);
Assert.Equal(1, double.Parse(shim.Span.Activity.Tags.First().Value));
Assert.Single(shim.Span.Activity.TagObjects);
Assert.Equal("foo", shim.Span.Activity.TagObjects.First().Key);
Assert.Equal(1, (double)shim.Span.Activity.TagObjects.First().Value);
}
[Fact]
@ -280,8 +280,8 @@ namespace OpenTelemetry.Shims.OpenTracing.Tests
shim.SetTag(new BooleanTag("foo"), true);
shim.SetTag(new BooleanTag(global::OpenTracing.Tag.Tags.Error.Key), true);
Assert.Equal("foo", shim.Span.Activity.Tags.First().Key);
Assert.True(bool.Parse(shim.Span.Activity.Tags.First().Value));
Assert.Equal("foo", shim.Span.Activity.TagObjects.First().Key);
Assert.True((bool)shim.Span.Activity.TagObjects.First().Value);
// A boolean tag named "error" is a special case that must be checked
Assert.Equal(Status.Unknown, shim.Span.Activity.GetStatus());
@ -316,9 +316,9 @@ namespace OpenTelemetry.Shims.OpenTracing.Tests
shim.SetTag(new IntTag("foo"), 1);
Assert.Single(shim.Span.Activity.Tags);
Assert.Equal("foo", shim.Span.Activity.Tags.First().Key);
Assert.Equal(1L, int.Parse(shim.Span.Activity.Tags.First().Value));
Assert.Single(shim.Span.Activity.TagObjects);
Assert.Equal("foo", shim.Span.Activity.TagObjects.First().Key);
Assert.Equal(1L, (int)shim.Span.Activity.TagObjects.First().Value);
}
[Fact]
@ -332,13 +332,13 @@ namespace OpenTelemetry.Shims.OpenTracing.Tests
shim.SetTag(new IntOrStringTag("foo"), 1);
shim.SetTag(new IntOrStringTag("bar"), "baz");
Assert.Equal(2, shim.Span.Activity.Tags.Count());
Assert.Equal(2, shim.Span.Activity.TagObjects.Count());
Assert.Equal("foo", shim.Span.Activity.Tags.First().Key);
Assert.Equal(1L, int.Parse(shim.Span.Activity.Tags.First().Value));
Assert.Equal("foo", shim.Span.Activity.TagObjects.First().Key);
Assert.Equal(1L, (int)shim.Span.Activity.TagObjects.First().Value);
Assert.Equal("bar", shim.Span.Activity.Tags.Last().Key);
Assert.Equal("baz", shim.Span.Activity.Tags.Last().Value);
Assert.Equal("bar", shim.Span.Activity.TagObjects.Last().Key);
Assert.Equal("baz", shim.Span.Activity.TagObjects.Last().Value);
}
}
}