open-telemetry
/
opentelemetry-dotnet
mirror of https://github.com/open-telemetry/opentelemetry-dotnet.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Rename Baggage Header name to baggage (#2003) 

* Rename Baggage Header name to baggage

* Updated CHANGELOG.md
This commit is contained in:
Utkarsh Umesan Pillai 2021-04-20 16:42:37 -07:00 committed by GitHub
parent ca5a93dd78
commit eb42939cd5
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
4 changed files with 7 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/OpenTelemetry.Api/CHANGELOG.md
View File

@ -9,6 +9,10 @@ please check the latest changes
## Unreleased
* `BaggagePropagator` now uses `baggage` as the header name instead of `Baggage`
to `Extract` from and `Inject` to `carrier`
([#2003](https://github.com/open-telemetry/opentelemetry-dotnet/pull/2003))
## 1.1.0-beta1
Released 2021-Mar-19

2
src/OpenTelemetry.Api/Context/Propagation/BaggagePropagator.cs
View File

@ -28,7 +28,7 @@ namespace OpenTelemetry.Context.Propagation
/// </summary>
public class BaggagePropagator : TextMapPropagator
{
internal const string BaggageHeaderName = "Baggage";
internal const string BaggageHeaderName = "baggage";
private const int MaxBaggageLength = 8192;
private const int MaxBaggageItems = 180;

2
test/OpenTelemetry.Instrumentation.Http.Tests/HttpClientTests.Basic.netcore31.cs
View File

@ -392,7 +392,7 @@ namespace OpenTelemetry.Instrumentation.Http.Tests
Assert.True(request.Headers.TryGetValues("traceparent", out var traceparents));
Assert.True(request.Headers.TryGetValues("tracestate", out var tracestates));
Assert.True(request.Headers.TryGetValues("Baggage", out var baggages));
Assert.True(request.Headers.TryGetValues("baggage", out var baggages));
Assert.Single(traceparents);
Assert.Single(tracestates);
Assert.Single(baggages);

2
test/OpenTelemetry.Instrumentation.Http.Tests/HttpWebRequestActivitySourceTests.netfx.cs
View File

@ -816,7 +816,7 @@ namespace OpenTelemetry.Instrumentation.Http.Tests
private static void ValidateBaggage(HttpWebRequest request)
{
string[] baggage = request.Headers["Baggage"].Split(',');
string[] baggage = request.Headers["baggage"].Split(',');
Assert.Equal(3, baggage.Length);
Assert.Contains("key=value", baggage);