Commit Graph

579 Commits

Author SHA1 Message Date
Reiley Yang 71bb3635f5
ILogger integration - part 3 (#1328)
* extract common part

* make process/exporter generic

* update dependencies

* update all the tests and docs

* clean up

* changelog

* update readme

* prevent LogRecord to be inherited

* simplify example

* simplify the code

* revert accidental change
2020-10-07 09:55:54 -07:00
Eddy Nakamura 6348f387f2
Cleaning files (#1323)
* Cleaning files

* applying fxcop suggestions

* fixing taskscheduler warning

removing fxcop
2020-10-06 20:24:32 -07:00
Reiley Yang 04eb1d877d
remove duplicated public keys (#1326)
Co-authored-by: Cijo Thomas <cithomas@microsoft.com>
2020-10-06 17:08:42 -07:00
Reiley Yang 77315f223f
Add a value type version of CircularBuffer (#1325)
* copy the CircularBuffer class

* adapt to value type

* nit
2020-10-06 16:29:46 -07:00
Eddy Nakamura 874f9d7863
CustomProperty improvements (#1261)
* CustomProperty improvements

updating tests

updating to RuntimeContextSlot

updating to runtimeContext

adding runtime/subscibe/flag benchmark

updating aspnet and http

updating ramaining instrumentation

* adding try/catch&log

* improve docs for enrich action

* Checking enrichment with sampler

* removing unneeded using

* updating changelog

* updating changelog

Co-authored-by: Cijo Thomas <cithomas@microsoft.com>
2020-10-06 13:27:00 -07:00
Reiley Yang 30f011456e
Consolidate log and trace processor (#1322)
* consolidate log and trace processor

* avoid OpenTelemetry.Common namespace

* add benchmarks

* skip test for netcoreapp2.1

* restrict log benchmark to netcoreapp3.1 for now
2020-10-06 08:24:19 -07:00
Reiley Yang d1a3f53324
ILogger integration - part 2 (#1315)
* add log processor

* fix changelog

* macros

* more conditional compilations

* improve struct

* remove duplicated stuff

* remove Sdk.CreateLoggerProviderBuilder

* clean up

* update changelog

Co-authored-by: Cijo Thomas <cithomas@microsoft.com>
2020-10-05 10:13:03 -07:00
Mikel Blanchard 1f04397c26
Added Activity.EnumerateEvents extension (#1319)
* Added EnumerateEvents extension on Activity. Updated Jaeger + Zipkin to use it. Added benchmarks & tests.

* Updated CHANGELOG.
2020-10-04 09:43:10 -07:00
Mikel Blanchard 8e7ba79def
Added Activity.EnumerateLinks extension (#1314)
* Added extension for enumeration Activity links.

* Updated CHANGELOG.

* Unit tests.

* Updated test to enumerate more than one record.
2020-10-02 11:16:19 -07:00
Mikel Blanchard 6633dc846e
Fixed a couple bugs in Jaeger Exporter. (#1310) 2020-09-26 09:38:40 -07:00
Reiley Yang 6529c43bfb
ILogger integration - part 1 (#1308)
* ilogger integration

* update changelog

* s/name/categoryName/g

* TODO comment
2020-09-25 14:32:44 -07:00
Pär Dahlman 56a34f371b
Fix sumary comment for 'CreateDoubleCounter' (#1307)
Co-authored-by: Cijo Thomas <cithomas@microsoft.com>
2020-09-25 09:16:34 -07:00
Eddy Nakamura 2037a45f57
Fixing NullReferenceException in SpanAttributes (#1304)
Testing null reference

Co-authored-by: Cijo Thomas <cithomas@microsoft.com>
2020-09-24 11:35:29 -07:00
xiang17 f79376d163
Add SelfDiagnostics module to provide infrastructure to log EventSource events - part 1 (#1234)
* Add SelfDiagnostics class which will provide infrastructure to log EventSource events.

* Change the location and access modifier.

* Remove UTF-8 BOM

* update description comment

Co-authored-by: Cijo Thomas <cithomas@microsoft.com>
2020-09-24 11:21:32 -07:00
Mikel Blanchard a61e48978f
Jaeger Exporter Tweaks (#1262)
* Fixed bug in Jaeger Exporter where it was using a buffer from the pool after it was returned.

* Combined the process cache creation with the library resource processing.

* Code review.

Co-authored-by: Cijo Thomas <cithomas@microsoft.com>
2020-09-23 10:55:51 -07:00
Mikel Blanchard 401c111c1a
Jaeger/Zipkin Exporter Performance (#1274)
* Fixed broken ZipkinExporter benchmarks & switched to batching.

* Zipkin Exporter performance tweaks.

* Code review.

* Updated CHANGELOGs.

* Renamed maxPacketSize in JaegerExporter. Added some validation in ZipkinExporter.

* Fixed build break.

* Attempting to get 2.1 tests passing.

* Fixed messed up syntax.

* Revert build definition change.

* adding rsync in linux (again)

Co-authored-by: Cijo Thomas <cithomas@microsoft.com>
Co-authored-by: Eddy Nakamura <ednakamu@microsoft.com>
2020-09-22 12:41:07 -07:00
Eddy Nakamura f1ebf05ecb
Renaming SamplingDecision options (#1297)
* Renaming enum

* updating changelog
2020-09-21 16:57:29 -07:00
Cijo Thomas 987c5ac79e
Correct check for activity is root in OTLP (#1295)
* Correct check for activity is root in OTLP

* comment about runtime issue

* removing sync linux

* adding TODO and removing rsync section

Co-authored-by: Eddy Nakamura <ednakamu@microsoft.com>
2020-09-21 15:35:08 -07:00
Tom Tan 36d747d0b3
Correct resource URL in comment (#1290)
Co-authored-by: Mikel Blanchard <mblanchard@macrosssoftware.com>
2020-09-19 10:24:53 -07:00
Reiley Yang b38adb4343
Update Exporter.Shutdown to meet with the latest spec (#1285)
* exporter.Shutdown returns bool

* update changelog

Co-authored-by: Cijo Thomas <cithomas@microsoft.com>
Co-authored-by: Mikel Blanchard <mblanchard@macrosssoftware.com>
2020-09-19 10:12:50 -07:00
Eddy Nakamura c7429d25c9
Normalizing format (#1289)
updating gitattributes

updating

updating

updating

Revert "Normalizing format"

This reverts commit b571e430a73f65605481ef0a622a372bc8a787ae.

Updating everything to utf-8

applying lf

Revert "applying lf"

This reverts commit a54947f24ba69eecc931525f2a69647040fdc28d.

updating config

Co-authored-by: Mikel Blanchard <mblanchard@macrosssoftware.com>
2020-09-19 09:45:29 -07:00
christopher-taormina-zocdoc d802472a36
Adding null check for incoming request port in aspnetcore (#1263)
Co-authored-by: Sergey Kanzhelev <S.Kanzhelev@live.com>
2020-09-18 15:47:33 -07:00
Cijo Thomas 4f41542624
Fix a bug in ASPNETCore instrumentation where it ignored activity by AspNetCore (#1286) 2020-09-17 13:33:02 -07:00
Reiley Yang 8a4621c71f
Update Processor.Shutdown to meet with the latest spec (#1282)
* processor.Shutdown returns bool according to the spec

* update changelog
2020-09-17 09:26:19 -07:00
Cijo Thomas f04fcd6297
Update changelog for 0.6.0-beta release (#1270) 2020-09-15 17:07:42 -07:00
Eddy Nakamura 91ee24f417
Updating DiagnosticSource to 5.0.0-rc.1.20451.14 (#1265)
* Updating DiagnosticSource to 5.0.0-rc.1.20451.14

* adding link to changelog

* commenting dotnet5 feed

Co-authored-by: Cijo Thomas <cithomas@microsoft.com>
2020-09-14 18:12:29 -07:00
Alan West a5a2eb0a8a
Remove tags added by gRPC library in favor of OpenTelemetry tags (#1260)
* Remove grpc.method and grpc.status_code tags

* Remove unused usings

* Remove TODO that is probably a WONTDO

Co-authored-by: Cijo Thomas <cithomas@microsoft.com>
2020-09-14 18:01:40 -07:00
Mikel Blanchard 768eaa3c96
PropertyFetcher API Improvements (#1238)
* Trying to improve the PropertyFetcher API.

* Cleanup.

* Cleanup.

* updating files, adding propertyFetcherTest

* CHANGELOG update.

* Attempting to fix line endings.

Co-authored-by: Eddy Nakamura <ednakamu@microsoft.com>
Co-authored-by: Cijo Thomas <cithomas@microsoft.com>
2020-09-11 17:05:04 -07:00
Mikel Blanchard d8c3ea32fd
Jaeger Exporter Performance (#1254)
* Fixed broken jaeger benchmarks.

* Setting up benchmarks for improvement testing.

* Removed the double-batching going on with the Jaeger Exporter. Added in some perf improvements.

* Fixing tests.

* Porting JaegerUdpBatcher tests to JaegerExporterTests.

* Fixed some whitespace.

* Updated CHANGELOG.
2020-09-11 07:23:53 -07:00
Reiley Yang a6795c224f
sanitize EOL for *.md files (#1257) 2020-09-10 09:47:32 -07:00
Alan West 8b8731c3c8
Document StackExchange.Redis instrumentation options (#1256)
* Document StackExchange.Redis instrumentation options

* Fix markdown
2020-09-10 09:30:30 -07:00
Rajkumar Rangaraj 4ae9104ec5
Add SuppressInstrumentation to Grpc client (#1184)
* Added SuppressInstrumentation to Grpc client

* Modified DiagnosticSourceListener

* Remove comment

* PR Comments

* Revert change to TracerProviderSdk

* renamed parameter

Co-authored-by: Cijo Thomas <cithomas@microsoft.com>
2020-09-09 22:12:36 -07:00
Alan West a2966474fd
Instrumentation docs Part #3 - SqlClient options (#1252)
* Document SqlClient instrumentation options

* Remove en-us

* Clarify behavior of SetTextCommandContent for .NET Framework

Co-authored-by: Cijo Thomas <cithomas@microsoft.com>
2020-09-09 21:53:27 -07:00
Cijo Thomas 82ae3a9947
ActivitySource adapter to populate sampler attributes to activity (#1247) 2020-09-09 20:45:40 -07:00
Reiley Yang dab9198d7c
sanitize EOL for *.csproj files (#1253) 2020-09-09 20:36:36 -07:00
Reiley Yang 5e41c62327
enforce EOL=LF in CI (#1250)
Co-authored-by: Cijo Thomas <cithomas@microsoft.com>
2020-09-09 17:14:26 -07:00
Cijo Thomas a3731ea02d
Document supported versions of .NET (#1249)
* Document supported versions of .NET

* Apply suggestions from code review

Co-authored-by: Reiley Yang <reyang@microsoft.com>

* Apply suggestions from code review

Co-authored-by: Reiley Yang <reyang@microsoft.com>

* line breaks

Co-authored-by: Reiley Yang <reyang@microsoft.com>
2020-09-09 13:28:22 -07:00
Alan West c1c181b98c
Rename HttpWebRequestInstrumentationOptions InstrumentationFilter to Filter (#1241) 2020-09-08 16:47:01 -07:00
Alan West 7772c44d6e
Update dependency instrumentation documentation (#1239) 2020-09-08 09:55:10 -07:00
Eddy Nakamura d0d33ed30a
Exposing PropertyFetcher as a public API from OpenTelemetry package (#1232)
* Removing duplicated PropertyFetcher

* Adding PropertyFetcher to changelog

* adding docs

Co-authored-by: Cijo Thomas <cithomas@microsoft.com>
Co-authored-by: Mikel Blanchard <mblanchard@macrosssoftware.com>
2020-09-06 10:35:17 -07:00
Eddy Nakamura c025116c3e
Replacing Tags for TagObjects and AddTag for SetTag (#1227)
* Replacing Tags for TagObjects and AddTag for SetTag

updating tests

updating tests

* removing toString from stackExchange test method

* tentative to solve redis test failure

* updating tests

* updating test

* checking for only one element

* Trying GetTagValue extension in http-in unit test projects.

* Grpc now uses GetTagValue.

* Updated new unit tests to use SetTag.

* Updated Http instrumentation for GetTagValue.

* Update Sql instrumentation to use GetTagValue.

* Updated Redis instrumentation to use GetTagValue.

* Removed references from test projects that weren't needed.

Co-authored-by: Mikel Blanchard <mblanchard@macrosssoftware.com>
2020-09-06 10:13:08 -07:00
Mikel Blanchard 9fb5be50ba
Added EnumerateTagValues Activity Extension (#1236)
* Added EnumerateTagValues extension on Activity for enumerating tags.

* Refactor.

* Unit tests and changelog.

Co-authored-by: Cijo Thomas <cithomas@microsoft.com>
2020-09-06 09:32:34 -07:00
Cijo Thomas cb0c161a89
ParentBasedSampler fix checking if root or not (#1237)
* AspNet Instrumentation docs

* Revert "AspNet Instrumentation docs"

This reverts commit 4cbb620533.

* Modify ParentBasedSampler to determine if root based on parentcontext being default

* traceid
2020-09-04 12:14:13 -07:00
Cijo Thomas 4993ec61ed
Asp.Net Core instrumentation docs (#1228)
* AspNet Instrumentation docs

* Revert "AspNet Instrumentation docs"

This reverts commit 4cbb620533.

* Asp.Net Core instrumentation examples

* Update src/OpenTelemetry.Instrumentation.AspNetCore/README.md

Co-authored-by: Reiley Yang <reyang@microsoft.com>

* Update src/OpenTelemetry.Instrumentation.AspNetCore/README.md

Co-authored-by: Reiley Yang <reyang@microsoft.com>

* markdown

Co-authored-by: Reiley Yang <reyang@microsoft.com>
2020-09-03 14:44:16 -07:00
Alan West dbe43b4b99
Grpc.Net.Client instrumentation documentation (#1213)
* Grpc.Net.Client instrumentation documentation

* Update src/OpenTelemetry.Instrumentation.GrpcNetClient/README.md

Co-authored-by: Reiley Yang <reyang@microsoft.com>

* Feedback

Co-authored-by: Reiley Yang <reyang@microsoft.com>
Co-authored-by: Cijo Thomas <cithomas@microsoft.com>
2020-09-03 11:58:06 -07:00
Kelly Birr a3f1c98bc5
Support multiple spans (activities) within the same Trace for StackExchangeRedis (#1153)
* - Add support multiple spans (activities) within the same TraceId.
- Use C# value tupples in cache keys and values to reduce heap allocations and ensure proper key comparison.
- Value names in C# tupples to make code slightly easier to read.

* Fix code formatting error

Fixing the code formatting issue being reported by code scanner.

* Added Unit test for multi-span in Redis

* fixed formatting that stylecop didn't like

Co-authored-by: Cijo Thomas <cithomas@microsoft.com>
2020-09-03 11:56:59 -07:00
Mikel Blanchard 623ad06d61
Added GetTagValue Activity Extension (#1221)
* Added GetTagValue, benchmarks, and tests.

* Changelog update.

* Updated a couple spots using Linq to find tags to use the new extension.

* Nits.
2020-09-03 10:57:43 -07:00
Reiley Yang 6efe758b55
Add doc on how to correlate ILogger with trace (#1214)
* add doc for ILogger correlation with trace

* fix links

* mention that ILogger correlation only works for .NET5, clarify the options

* distinguish ILogger and Microsoft.Extensions.Logging

Co-authored-by: Cijo Thomas <cithomas@microsoft.com>
2020-09-01 07:15:39 -07:00
Cijo Thomas 88e978fb1f
Minor changes based on leftover comments from early PRs (#1216)
* AspNet Instrumentation docs

* Revert "AspNet Instrumentation docs"

This reverts commit 4cbb620533.

* Minor rewording based on PR coments.

* remove duplicated entry
2020-08-31 20:42:36 -07:00
Alan West 19f834fc82
Jaeger: Include net.peer.port in peer.service attribute (#1195)
* Include net.peer.port in peer.service attribute when applicable

* Update changelog

* Small change to if statement

Co-authored-by: Cijo Thomas <cithomas@microsoft.com>
2020-08-31 20:09:58 -07:00