Commit Graph

115 Commits

Author SHA1 Message Date
xiang17 9b60e1fe8f
Enable integration tests for .NET 5.0 (#1694)
* Enable integration tests for .NET 5.0

* Change configuration for other packages (StackExchangeRedis and SqlClient)

Co-authored-by: Cijo Thomas <cithomas@microsoft.com>
2021-01-14 09:31:15 -08:00
Alan West 4e4f95bb53
OTLP exporter: use Grpc.Net.Client for netstandard2.1 (#1662)
* Use Grpc.Net.Client for netstandard2.1

* Fix AspNetCore example app

* Better comment for Http2UnencryptedSupport switch

* Update PublicAPI

* Update changelog

* Fix line endings

* Suppress instrumentation on export

Co-authored-by: Cijo Thomas <cithomas@microsoft.com>
2021-01-04 11:45:21 -08:00
Austin Tan 92ec254342
Extracting package versions to common.props (#1538)
* Most of the common props stuff

* remove coverlet from Zpages Test

* Clean up other mention of coverlet in comment

* Moving appropriate package versions to nonprod

* Common.props removal of packagevers

* reverting some changes to a grpc package

* Fixing tabs and adding one more packagae referecne

Co-authored-by: Cijo Thomas <cithomas@microsoft.com>
Co-authored-by: Eddy Nakamura <ednakamu@microsoft.com>
2020-11-16 14:30:45 -08:00
Cijo Thomas 1a308a6bd2
Net5.0 cleanup (#1506)
* Net5.0 cleanup

* more
2020-11-11 06:52:03 -08:00
Cijo Thomas a29e031bf5
Use GA version of DiagnosticSource (#1500)
* Use GA version of DiagnosticSource

* fix space

* Update bcl backages to be utpo 6.0 version
2020-11-10 11:17:56 -08:00
Mikel Blanchard b956a5f7e9
Resource allocation improvement (#1463)
* Introduces the concept of IProviderContainer which allows injection of a TracerProvider into lower levels (Processor, Exporter, etc.).

* Removed IProviderContainer and fixed the provider types.

* Removed log provider example.

* Working on getting everything working with the new API.

* Attempting to get all the tests passing.

* Added concept of BaseProvider. Updated public API.

* Project fixup.

* Removed OnParentProviderSet.

* Updated changelog.

* Test fixup.

* Test fixup.

* Cleanup.
2020-11-09 13:39:25 -08:00
Eddy Nakamura 052ecc44b2
Enable .net5.0 (#1486)
* Enable .net5.0

* fixing build issues

* updating sanity

* fixing windows pipelines

* adding aspnetcore5.0

* adding net5 workaround

* skipping Flackytest

* updating to latest stable version

* updating code coverage to latest preview
2020-11-09 12:34:03 -08:00
Eddy Nakamura bebc80f307
Enable publicApi for OT (#806)
updating projects, adding options parameter

Applying suggestions

Apply suggestions from code review

Co-authored-by: Paulo Janotti <pjanotti@splunk.com>

code review - cijo

removing aspnetcore "metapackage"

Co-authored-by: Cijo Thomas <cithomas@microsoft.com>

updating public apis

updating public api, adding tool to migrate

Apply suggestions from code review

Co-authored-by: Sergey Kanzhelev <S.Kanzhelev@live.com>

Adding tool to migrate unshipped to shipped

updating contributing guidelines

updating lint

adding publicapi to shims

updating publicapi files

removing publicapi that works only for debug

updating publicapi

updating publicapi

removing extra file (merge problem)

updating publicapi

updating to latest version

updating spacing

updating contribution guideline

markdownlint

markdownlint

updating public api

updating publicapi

updating

updating

updating apis

Enable publicApi for OT

updating projects, adding options parameter

Applying suggestions

Apply suggestions from code review

Co-authored-by: Paulo Janotti <pjanotti@splunk.com>

code review - cijo

removing aspnetcore "metapackage"

Co-authored-by: Cijo Thomas <cithomas@microsoft.com>

updating public apis

updating public api, adding tool to migrate

Apply suggestions from code review

Co-authored-by: Sergey Kanzhelev <S.Kanzhelev@live.com>

Adding tool to migrate unshipped to shipped

updating contributing guidelines

updating lint

adding publicapi to shims

updating publicapi files

removing publicapi that works only for debug

updating publicapi

updating publicapi

removing extra file (merge problem)

updating publicapi

updating to latest version

updating spacing

updating contribution guideline

markdownlint

markdownlint

updating public api

updating publicapi

updating

solving merge issue

updating - 01

updating - 02

updating - 03

updating - 04

updating - 05

updating - 06

updating - 07

updating - 08

updating - 09

updating - 09

updating - 10

updating - 11

updating - 12

updating - 12

updating encoding

updating

updating - 13

updating - 14

updating - 15

updating - 16

fixing spacing

updating - 17

fixing spacing

updating - 18

adding suppression

simplifying changes

fixing merge issues

updates after merge

updating public api files

fixing build after merge

fixing build issues

Co-authored-by: Cijo Thomas <cithomas@microsoft.com>
2020-11-06 09:28:01 -08:00
Reiley Yang 1170f3f20d
catch up the latest version of .NET RC (#1362)
Co-authored-by: Cijo Thomas <cithomas@microsoft.com>
2020-10-17 15:53:06 -07:00
Eddy Nakamura 5c85552310
Updating DiagnosticSource to version 5.0.0-rc.2.20475.5 (#1346)
* Updating DiagnosticSource to version 5.0.0-rc.2.20475.5

* updating changelog link
2020-10-13 14:31:39 -07:00
Reiley Yang 6529c43bfb
ILogger integration - part 1 (#1308)
* ilogger integration

* update changelog

* s/name/categoryName/g

* TODO comment
2020-09-25 14:32:44 -07:00
Eddy Nakamura ec14f92be9
Adding multitarget to integration tests (#1266)
* Adding multitarget to integration tests

changing to ENV

updating to multiline

removing multiline

updating version of docker-compose

updating dockerfile

updating pipeline

testing again

testing

updating version to 3.7

updating dockerfile

testing

updating to env

adding .env to test

updating docker compose

removing default value

docker compose with options

updating dockerfile to isntall netcore 2.1

adding info to check what are the versions installed

updating script

adding condition to download only in netcoreapp2.1

updating condition

updating dockerfile

adding arg

updating files to enable netcoreapp2.1 and 3.1 test

updating version

removing duplicated files, adding to build folder

updating project to tests

updating project to tests

updating to tests

adding sdk as tag

updating dockerfile

removing sdk_version fixed value

updating arg order

updating files

* removing fixed version

* Attempting to get redis integration tests up and running.

* Attempting to get SqlClient integration tests working on 2.1 + 3.1.

* Attempting to get W3C integration tests running on 2.1 & 3.1.

* Added version to Microsoft.AspNetCore.App 2.1 refs.

* Comment cleanup.

* Attempting to fix explicit reference warnings.

Co-authored-by: Mikel Blanchard <mblanchard@macrosssoftware.com>
2020-09-19 10:00:30 -07:00
Eddy Nakamura 2fd54cdc4a
Adding upper bound to prevent compilation issues (#1293) 2020-09-19 09:36:15 -07:00
Cijo Thomas 7863cee67a
Update to DiagnoticSource RC2 (#1273) 2020-09-15 23:09:11 -07:00
Eddy Nakamura 91ee24f417
Updating DiagnosticSource to 5.0.0-rc.1.20451.14 (#1265)
* Updating DiagnosticSource to 5.0.0-rc.1.20451.14

* adding link to changelog

* commenting dotnet5 feed

Co-authored-by: Cijo Thomas <cithomas@microsoft.com>
2020-09-14 18:12:29 -07:00
Reiley Yang a6795c224f
sanitize EOL for *.md files (#1257) 2020-09-10 09:47:32 -07:00
Reiley Yang dab9198d7c
sanitize EOL for *.csproj files (#1253) 2020-09-09 20:36:36 -07:00
Reiley Yang 5e41c62327
enforce EOL=LF in CI (#1250)
Co-authored-by: Cijo Thomas <cithomas@microsoft.com>
2020-09-09 17:14:26 -07:00
Alan West 255889f84a
Centralize package versions for example projects (#1230)
Co-authored-by: Cijo Thomas <cithomas@microsoft.com>
2020-09-04 13:25:59 -07:00
Reiley Yang 6efe758b55
Add doc on how to correlate ILogger with trace (#1214)
* add doc for ILogger correlation with trace

* fix links

* mention that ILogger correlation only works for .NET5, clarify the options

* distinguish ILogger and Microsoft.Extensions.Logging

Co-authored-by: Cijo Thomas <cithomas@microsoft.com>
2020-09-01 07:15:39 -07:00
Cijo Thomas f679960e03
Update diagnosticsource to rc1 (#1203)
* Step1 of updating to Rc1 of diagnostic source

* Update parent.spanid to parent.traceid as traceid will be default for root.

* add samplingatributes to activity tags

* updating to isremote=true

* updating tests

* changelogs

Co-authored-by: Eddy Nakamura <ednakamu@microsoft.com>
2020-08-31 17:22:45 -07:00
Cijo Thomas c7e6c89e21
Update diagnostic source version to the newest preview from nuget. (#1167)
* Update to the diagnosticsource from nuget

* changelog
2020-08-25 14:45:39 -07:00
Reiley Yang fa8a052352
more sanity check (#1164)
Co-authored-by: Mikel Blanchard <mblanchard@macrosssoftware.com>
2020-08-24 21:50:58 -07:00
Reiley Yang 552728a7bc
use OpenTelemetry and otel consistently (#1158) 2020-08-24 18:06:39 -07:00
Eddy Nakamura 50c60af259
Enable FxCop - part 05 (#1141)
* Enable FxCop - part 05

* removing using tag

* updating zpages and adding supression

* adding supressions

* undoing traceprovider change
2020-08-24 10:15:59 -07:00
Eddy Nakamura 46907830e2
Updating VSTest nuget (#1074)
* Updating VSTest nuget

* updating to stable version

* updating nuget

Co-authored-by: Cijo Thomas <cithomas@microsoft.com>
Co-authored-by: Mikel Blanchard <mblanchard@macrosssoftware.com>
2020-08-20 09:26:51 -07:00
Eddy Nakamura a3bf19d450
Removing Todos (#1029)
* Removing Todos

renaming parameter

adding tests

updating spanbuilderShim

updating to internal

renaming to spanAttributes

solving build issue

adding spec reference

Continue Refactoring TracerProvider. (#1035)

* optimize the flow

* fix instrumenataion

* move mroe things to provider ctor

* move logic arounds

Co-authored-by: Reiley Yang <reyang@microsoft.com>

changing to class and following spec to replace value

replacing from default to null

updating package

adding xunit.runner

renaming method

* removing duplicated files

* adding some tests and updating to default constructor

* removing to be compliant to spec

Co-authored-by: Cijo Thomas <cithomas@microsoft.com>
2020-08-11 07:50:53 -07:00
Reiley Yang fb5eec094d
mini bencmark (#1039)
Co-authored-by: Cijo Thomas <cithomas@microsoft.com>
2020-08-10 22:49:32 -07:00
Eddy Nakamura 1c15164b14
Updating CodeCoverage and deterministic build (#1010)
* Testing CodeCoverage

solving build issue

updating file to debug

updating function

updating script

updating filters

removing upload

removing unused tag

* updating order

* adding blank line

* Update .github/workflows/dotnet-core-cov.yml

Co-authored-by: Reiley Yang <reyang@microsoft.com>

Co-authored-by: Reiley Yang <reyang@microsoft.com>
Co-authored-by: Mikel Blanchard <mblanchard@macrosssoftware.com>
2020-08-05 10:33:40 -07:00
Eddy Nakamura c3500d2ff1
Enable FxCop - part 01 (#997)
* Enable FxCop

* removing useless toString()

* Enable FxCop - 1

* updating order

Co-authored-by: Cijo Thomas <cithomas@microsoft.com>
2020-08-04 20:04:28 -07:00
Reiley Yang ca368e9748
treat warning as warning for debug build (#990) 2020-08-03 17:31:49 -07:00
Reiley Yang 90c5b3af11
Improve docs structure (#983)
* improve docs structure

* revert line ending

* adopt .net5-preview-8

* remove unused using
2020-08-03 16:46:48 -07:00
Cijo Thomas d2c93610e8
Update to preview 8 of DiagnosticSource and associated changes - part1 (#954)
* Initial make build fix commit

* change Link public API to accept ActivityTagsCollection

* Add more SetAttribute overload to support int bool float and bool

* changelog

* Replace AddTag with SetTag in Activity

* disable a test for temporary progress

* reformat

* url fix

* Update Diagnosticourcepackage

* version fix

* ActivityTagsCollection

* console exporter fix

* one basic test

* minor
2020-08-03 11:25:24 -07:00
Reiley Yang 2e4b081f6d
Consolidate package version (#971)
* consolidate package version for src folder

* fix CI

* clean up

* clean up test package version

* clean up

* fix nits

* clean up using
2020-08-02 06:20:44 -07:00
Reiley Yang c612b40da4
Improve project props management (#966)
* improve project props management

* use less strict version

* add comment

* workaround redis test

* reduce the scope of change

* Revert "reduce the scope of change"

This reverts commit 059ef3a6ef956978c61b101ed5914203b214c2a0.

* revert

* try to fix docker

* try to fix docker

* manually update the sln file
2020-08-01 18:23:53 -07:00
Reiley Yang 755f727df0
Add sanity check for non-ASCII character and trailing spaces (#927)
* add CI sanity check for non-ASCII encoding and trailing spaces

* check TAB too

* fix ordering

* rename sanity to sanitycheck
2020-07-27 07:52:26 -07:00
Eddy Nakamura 14255acb6d
Trigger pipeline when tag (#926)
Co-authored-by: Mikel Blanchard <mblanchard@macrosssoftware.com>
2020-07-25 06:44:57 -07:00
Reiley Yang cc331fab76
docfx improvement (#922)
Co-authored-by: Cijo Thomas <cithomas@microsoft.com>
2020-07-24 16:08:38 -07:00
Eddy Nakamura 8fbf6fa3de
Updating file version (#904)
* Updating file version

* adding version and fileversion
2020-07-23 17:13:06 -07:00
Eddy Nakamura 3aca129967
Moving benchmark to test folder (#885)
* Moving benchmark to test folder

updating namespaces

updating path

Reiley comments

* updating paranthesis
2020-07-22 17:09:28 -07:00
Reiley Yang eb42d6b6d1
Add markdown sanity check CI (#837)
* markdown sanity check

* minor adjustment to the folder structure

* clean up Jaeger README.md
2020-07-18 07:31:01 -07:00
Eddy Nakamura 5b34e3b3f8
Adding metapackages (#810)
Adding IsPackable to test.props, updating test nuget versions

updating projects, adding options parameter

Applying suggestions

Apply suggestions from code review

Co-authored-by: Paulo Janotti <pjanotti@splunk.com>

code review - cijo

removing aspnetcore "metapackage"

Co-authored-by: Cijo Thomas <cithomas@microsoft.com>
2020-07-15 23:31:57 -07:00
Mikel Blanchard 9298e0ef3f
Redis instrumentation with ActivitySource by Eddy & Mike (#800)
* Attempting to get Redis instrumentation up and working using ActivitySource API.

* updating tests

* renaming and updating tests

* Test fixes.

* Fixed Redis net461 tests failing on connection.

* Redis integration tests and bug fixes.

* Adding tests

* Put back redis connection options.

* Updates for changes in master.

* adding comments to testRedis

* updating based on comments

* updating summary

* Switched a couple spots using string keys to constants.

* Redis integration tests

* Small tweak to the GitHub action to make it more consistent with the others.

* Made instrumentation internal. Updated README.

* rename MaxFlushInterval to FlushInterval, adding flushInterval to samples

* Removed running of non-integration tests from Redis dockerfile.

Co-authored-by: Eddy Nakamura <eddynaka@gmail.com>
Co-authored-by: Cijo Thomas <cithomas@microsoft.com>
2020-07-14 08:47:59 -07:00
Eddy Nakamura 2b2dd85cf8
Solving minver issue (#804) 2020-07-13 11:44:28 -07:00
Eddy Nakamura 938343c85f
Enable codecov for windows (#777)
cleaning props/targets

updating to new version of codecov

adding env_vars

updating yml

adding env_vars

solving compilation issue

adding source root

adding source root

fixing wrong tag

commenting sourceroot

enabling deterministic for packs only

changing job titles

Co-authored-by: Cijo Thomas <cithomas@microsoft.com>
2020-07-07 06:29:45 -07:00
Eddy Nakamura f95f3730fb
updating minver version (#768)
adding target after minver

adding correct revision number

Co-authored-by: Cijo Thomas <cithomas@microsoft.com>
2020-07-06 21:59:10 -07:00
Paulo Janotti 8ed37a6f59
Organize StyleCop Settings and enable StyleCop on Tests (#715)
* Enable StyleCop rules for Test projects

This enables most of the StyleCop for test projects cleaning up any
errors as appropriate.

* Enable StyleCop rules for Test projects

This enables most of the StyleCop for test projects cleaning up any
errors as appropriate.

* Add line break at end of ruleset files

* Correct multi-line parameter after rebase
2020-06-10 12:12:13 -07:00
Paulo Janotti 601ded5b6b
Treat warnings as errors for test projects (#714) 2020-06-03 18:10:37 -07:00
Paulo Janotti 1b1902e356
Disable Code Coverage from `dotnet test` on Windows (#682)
* Disable code coverage on Windows

* Update CONTRIBUTING.md
2020-05-18 17:21:42 -07:00
Cijo Thomas 30f841b2ef
Remove year from Copyright header (#671)
* Remove year from Copyright header

* some projects were unloaded and hence change didnt apply. this commit fixed it
2020-05-07 11:53:43 -07:00
Paulo Janotti d31d485067
Fix code coverage (#666)
* Fix code coverage

Update tools and fix command.

* Disable code coverage on AzurePipelines
2020-05-06 17:11:38 -07:00
Mikel Blanchard 4729e8c154
Fixed up some inconsistency in the meta showing up in package managers. (#659)
Co-authored-by: Sergey Kanzhelev <S.Kanzhelev@live.com>
2020-05-04 14:22:32 -07:00
Liudmila Molkova 40a51b69bc
Move test infra to .NET Core 3.0 (#403)
* Add W3C TraceContext validation test app

* fix linux build

* some fixes

* Use ASP.NET Core test app as W3C test suite example

* broken solution

* remove new project

* move tests to 3.0

* update minver

* fix http tests to force 2.0

* minver is in common props, remove from projects

* move lightstep tests to 3.1
2019-12-19 13:46:57 -08:00
Sergey Kanzhelev cb0630c8f9
icon is in the package (#325) 2019-11-06 11:19:23 -08:00
Sergey Kanzhelev 5b9b43cad3
Re-enable 1591 on Abstractions (#311)
* documentation in Abstractions

* a few docs after merge
2019-10-23 14:49:50 -07:00
Bruno Garcia d48e702286 ref: Move using outside namespace (#277) 2019-10-12 10:03:45 -07:00
Bruno Garcia 5eeb809963 strong name in all platforms (#208)
* strong name in all platforms

* Generate docs in all platforms
2019-09-18 15:16:43 -07:00
Bruno Garcia 1c6d191281 ref: Rename Open Census to Open Telemetry (#188) 2019-08-19 13:26:42 -07:00
Liudmila Molkova 4b0b2c29e7
Disable code coverage in CI: reportgenerator does not work (#159) 2019-07-23 19:13:26 -07:00
Michael Ingold 843fc3e225 Code Cleanups (#131)
* reordered all usings (SA1208)

* Use trailing comma in multi-line initializers (SA1413)

* SA1005	Single line comment should begin with a space.

* SA1028	Code should not contain trailing whitespace

* A1101	Prefix local calls with this

* SA1500	Braces for multi-line statements should not share line

* SA1505	An opening brace should not be followed by a blank line.

* SA1513	Closing brace should be followed by blank line

* SA1517	Code should not contain blank lines at start of file

* A1507	Code should not contain multiple blank lines in a row

* SA1503	Braces should not be omitted

* SA1508	A closing brace should not be preceded by a blank line

* SA1210	Using directives should be ordered alphabetically by the namespaces

* IDE0065 Removed unnecessary usings

* SA1633    The file header is missing or not located at the top of the file.

* IDE0044    Make field readonly

* SA1311	Static readonly fields should begin with upper-case letter

* IDE0060	Remove unused parameter 'options' if it is not part of a shipped public API

* various IDE warnings cleaned up

* SA1400	Element should declare an access modifier

* SA1402	File may only contain a single type

* SA1638	File header file name documentation should match file name

* SA1629	Documentation text should end with a period

* various code uncommon style warnings fixes

* SA1137	Elements should have the same indentation
* SA1648	inheritdoc should be used with inheriting class

* SA1616	Element return value documentation should have text

* SA1310    Field should not contain an underscore

* Various documentation rule violations fixed

* SA1614	Element parameter documentation should have text
* SA1137	Elements should have the same indentation

* Various documentation rule violations fixed

* CS1574	XML comment has cref attribute that could not be
resolved
* CS1572	XML comment has a param tag for, but there is no
parameter by that name
* SA1204	Static members should appear before non-static members
* SA1201	A property should not follow a method
* SA1201	A constructor should not follow a property
* SA1202	'public' members should come before 'private' members
* SA1202	'internal' members should come before 'private' members
* SA1202	'protected' members should come before 'private' members
* CS0168	The variable 'ex' is declared but never used

* Moved to implicit version resolution, as stated in the warning from the
dotnet sdk

* various cleanups and project structure

* CS1591 disabled for the entire solution
* removed `[assembly: System.CLSCompliant(true)]` from contributed
projects
* Fixed various async snafus.

* removed version.props from proj file

* enabled TreatWarningsAsErrors
2019-07-08 22:32:22 -07:00
Stuart Blackler aec6feb6f4 Cleaned up infrastructure. Added code coverage (#105)
* Cleaned up infrastructure. Added code coverage

* PR Feedback
2019-06-12 23:39:31 -07:00
Sergey Kanzhelev f2e5307f75
fix few warnings (#39) 2019-05-22 13:50:52 -07:00
Sergey Kanzhelev 68421615fe
minor clean up (#26) 2019-05-13 13:13:03 -07:00
Sergey Kanzhelev b11593d2d6 find and replace OpenCensus -> OpenTelemetry 2019-05-10 10:30:04 -07:00
Sergey Kanzhelev 0c01f9f0aa copy of OpenCensus at 0474607a16282252697f989113d68bdf71959070 2019-05-08 12:32:06 -07:00