Commit Graph

1022 Commits

Author SHA1 Message Date
mbakalov d18e0765a2
Fix syntax in README code snippets (#1633) 2020-11-30 08:16:18 -08:00
kevinmckinley 2eed6d5b26
Filter() docs: Clarify 'collect telemetry' vs 'instrumentation' (#1629)
* Clarify 'collect telemetry' vs 'instrumentation'

* ..."that determines whether or not"... - aspnet Filter()

* Filter definition clarify - AspNetCore

* Filter definition clarify - Http

* Filter definition clarify - Http netfx
2020-11-29 21:01:53 -08:00
kevinmckinley 27b57ea058
Filter() description and code snippet clarity and consistency (#1628)
* Update code snippet description and code formatting consistency

* code snippet param names and tab spacing

* Filter description and snippet changed for clarity

* Filter description and snippet changed for clarity

Co-authored-by: Cijo Thomas <cithomas@microsoft.com>
2020-11-27 19:26:59 -08:00
Mikel Blanchard 1bab62cb71
Exporter spec fixup 2 (#1620)
* Jaeger & Zipkin status enums are now uppercase. Zipkin error tag is an empty string.

* Updated CHANGELOGs.

* Attempting to fix build.

Co-authored-by: Cijo Thomas <cithomas@microsoft.com>
2020-11-27 18:43:29 -08:00
Utkarsh Umesan Pillai fe9e90d367
Add Unit Tests for Logs (#1613)
* Added UnitTests for Logs

* Added unit test for BatchExportProcessor for Logs

* Update LogLevels test

* Update the description for RecordOnly and RecordAndSample

* Addressed PR comments

* Addressed PR comments

* Addressed PR comments

Co-authored-by: Cijo Thomas <cithomas@microsoft.com>
2020-11-25 11:14:03 -08:00
Alan West fc8520abdf
Remove net46 target from OpenTracing shim (#1624) 2020-11-25 10:59:15 -08:00
Utkarsh Umesan Pillai 7deee54564
Refactor ConsoleExporter (#1593)
* Refactored ConsoleExporter

* Refactored ConsoleExporter

* Addressed PR comments

* Removed unnecessary using staatements

* Addressed PR comments

Co-authored-by: Cijo Thomas <cithomas@microsoft.com>
2020-11-25 10:04:17 -08:00
kevinmckinley 72026f6a1c
Set Filter description to describe what the filter allows instead of … (#1615)
* Set Filter description to describe what the filter allows instead of what is filtered out

* adjust line length

* clarify: it doesn't collect telemetry for request

* clarify example comment

* adjust line length

Co-authored-by: Cijo Thomas <cithomas@microsoft.com>
2020-11-25 09:39:58 -08:00
Alan West 4ccdb6e281
Make OpenTracing shim classes internal? (#1619)
* Make OpenTracing shim classes internal

* Update changelog
2020-11-25 09:30:47 -08:00
mbakalov 9e2669980a
SqlClient instrumentation to support Microsoft.Data.SqlClient EventSource (#1599)
* Listen to MDS EvenSource as well

* Use SqlEventSourceListener on NETFRAMEWORK only

Separate SqlClientInstrumentationOptions for netcore and netfx.
Upgrade MDS nuget to the newer version that actually uses the new
EventSource name.
Don't reference the diagnostic listener from the sql even source code.

* Better comments

* CHANGELOG updates + minor code clarity

* Run EventSource tests for MDS source as well

* Default capture text to true

Capturing doesn't depend on commandtype.

* Update readme for new SetStatementText behavior

* Minor md formatting fix

* Default command text capture to false

* Markdown cleanup

Co-authored-by: Cijo Thomas <cithomas@microsoft.com>
2020-11-24 14:39:04 -08:00
Prashant Srivastava 04f35ef90f
Using a new private Write method to write to Console or Debug (#1618) 2020-11-24 13:32:22 -08:00
Eddy Nakamura 2785ffbbaa
Metrics are obsolete (#1611)
* Metrics are obsolete

* updating changelog

* updating changelog
2020-11-24 09:45:36 -08:00
Mikel Blanchard d3edc476e7
Exporter spec updates. (#1609)
* Exporter spec updates.

* CHANGELOG updates.

Co-authored-by: Cijo Thomas <cithomas@microsoft.com>
2020-11-23 10:24:35 -08:00
mbakalov 9f27b4cfe4
Document SqlClientInstrumentation Enrich behavior (#1604)
Co-authored-by: Cijo Thomas <cithomas@microsoft.com>
2020-11-23 07:18:06 -08:00
Utkarsh Umesan Pillai 0abe85dcd6
Updated docs for logs (#1586)
* Updated docs for logs

* Remove extra space

* Corrected the propertyname to TargetFrameworks

* Updated TargetFrameworks property

* Addressed PR comments

Co-authored-by: Cijo Thomas <cithomas@microsoft.com>
2020-11-22 16:33:00 -08:00
mbakalov daa83ca0d7
Use fully-qualified type in RecordException (#1603)
Co-authored-by: Cijo Thomas <cithomas@microsoft.com>
2020-11-22 16:02:49 -08:00
kevinmckinley 81ffcf2030
Review Docs: Clarify usage and default endpoint (#1598)
* Default value for `Endpoint`; Usage instruction

* Update README.md

* Update src/OpenTelemetry.Exporter.Zipkin/README.md

Co-authored-by: Reiley Yang <reyang@microsoft.com>

* Endpoint default is localhost

* remove line number link (due to fragility with future changes)

* set default in docs to HTTP (not https) to match implementation

ref aec8a7df7c/src/OpenTelemetry.Exporter.Zipkin/ZipkinExporterOptions.cs (L43)

Co-authored-by: Reiley Yang <reyang@microsoft.com>
Co-authored-by: Cijo Thomas <cithomas@microsoft.com>
2020-11-22 15:43:14 -08:00
xiang17 cfe794bebb
Write one line when opening a new Self Diagnostics log file (#1594)
* Write one line on opening new Self Diagnostics log file

* Move log file position cursor.

Co-authored-by: Cijo Thomas <cithomas@microsoft.com>
2020-11-22 15:35:07 -08:00
Ove Bastiansen 8d33d011c9
No need to try to open the selfdiagnostic file if it does not exist (#1608) 2020-11-22 15:22:40 -08:00
Austin Tan aec8a7df7c
Update to API ReadMes (#1596)
* Update to API ReadMes

* String error instead of enum error

* Explicitly mention strings

* Update src/OpenTelemetry.Api/README.md

Co-authored-by: Cijo Thomas <cithomas@microsoft.com>
2020-11-20 12:08:54 -08:00
Austin Tan 5066600110
Updating ReadMEs for Jaeger, Zipkin, OTLP exporters (#1591)
* Adding new options to the ReadMes

* Remove spaces for markdownlint

* Updating link to better represent processors

* Zipkin clarifying processor name - about to update Jaeger and Otlp

Co-authored-by: Cijo Thomas <cithomas@microsoft.com>

* base exporter to exporting processor

Co-authored-by: Cijo Thomas <cithomas@microsoft.com>
2020-11-19 13:27:14 -08:00
Austin Tan e17b459c66
Otlp exporter options (#1587)
* Enable Batch or Simple exporter in Otlp

* Updating api metadata

* Correction to comment

* Update src/OpenTelemetry.Exporter.OpenTelemetryProtocol/OtlpExporterOptions.cs

Co-authored-by: Alan West <3676547+alanwest@users.noreply.github.com>

Co-authored-by: Cijo Thomas <cithomas@microsoft.com>
Co-authored-by: Alan West <3676547+alanwest@users.noreply.github.com>
2020-11-18 21:07:16 -08:00
Austin Tan dc3752f55d
Jaeger exporter options (#1584)
* Changes to exporter to include option

* Update to APIs

* Updating changelog

* Fix markdownlint, blank line missing
2020-11-18 15:07:00 -08:00
Alan West b710c314ae
Use consistent pattern for namespace of extension methods (#1576)
* Change PrometheusRouteBuilderExtensions namespace to Microsoft.AspNetCore.Builder

* Change ConsoleExporterLoggingExtensions namespace to OpenTelemetry.Logs

* Change namespace in example app

* Change namespace of extension methods for InMemoryExporter

* Change ResourceBuilderExtensions namespace to OpenTelemetry.Resources

* Add comment for extension methods not contained in namespace of type they are extending

* Update comment

* Update changelog

Co-authored-by: Cijo Thomas <cithomas@microsoft.com>
2020-11-18 11:26:22 -08:00
George Chakhidze 5995fd96d1
Fix spelling of event messages: 'thrw' -> 'threw' (#1583) 2020-11-18 07:37:30 -08:00
Cijo Thomas 9661a7c4dd
Filtering processor (#1559)
* Filtering processor

* fixes

* pr feedbacs

* readonle
2020-11-18 00:15:25 -08:00
Mikel Blanchard 932c2587d2
Status Improvements (#1579)
* Send StatusCode as a string. Send error flag in Zipkin & Jaeger when StatusCode == Error.

* Missed one spot.

* Removed code setting otel.status_description to http status description.

* Unit test fixup.

* Update CHANGELOG.

* Updated http instrumentation CHANGELOG.

* Code review.

Co-authored-by: Cijo Thomas <cithomas@microsoft.com>
2020-11-17 23:39:28 -08:00
Cijo Thomas 5dc3b11568
Release for RC1 (#1577) 2020-11-17 21:07:10 -08:00
Utkarsh Umesan Pillai b247b3d70e
Added Activity.IsRecorded check for Export (#1574)
* Added Activity.IsRecorded check for Export

* Updated CHANGELOG.md

* Remove extra space

* Add unit tests to check for Activity.IsRecorded for ExportProcessor

* Updated CHANGELOG.md

Co-authored-by: Cijo Thomas <cithomas@microsoft.com>
2020-11-17 20:51:54 -08:00
xiang17 9e90fce29c
Enable self diagnostics module (#1573)
* Enable self diagnostics module

* remove duplicate space

Co-authored-by: Cijo Thomas <cithomas@microsoft.com>
2020-11-17 17:55:57 -08:00
Utkarsh Umesan Pillai 502f751f75
Clean up CHANGELOG.md (#1575)
Co-authored-by: Cijo Thomas <cithomas@microsoft.com>
2020-11-17 17:42:05 -08:00
xiang17 c6ade39ec7
Remove tests on NonEventMethods (#1568)
Co-authored-by: Cijo Thomas <cithomas@microsoft.com>
2020-11-17 17:37:24 -08:00
Alan West fd812eea04
Remove ServiceName from JaegerExporterOptions (#1572)
* Remove ServiceName from JaegerExporterOptions

* Update changelog

Co-authored-by: Cijo Thomas <cithomas@microsoft.com>
2020-11-17 14:55:11 -08:00
Cijo Thomas 7a91923fb7
Remove Resource public ctor as Provider expects ResourceBuilder now (#1566)
* Remove Resource public ctor as Provider expects ResourceBuilder now

* changelog

* more apis removed.

* build fix
2020-11-17 14:26:23 -08:00
Alan West 0e3081731a
Remove ServiceName from OtlpExporterOptions (#1557)
* Remove ServiceName from OtlpExporterOptions

* Update PublicAPI

* Update changelog

* Add back default service name when resource does not have service.name

* Fix test

* Fix examples post merge
2020-11-17 14:08:51 -08:00
Cijo Thomas 3c49d35cf1
Cleanup logging docs (#1563)
* Cleanup logging docs

* remove dead link

* fix link
2020-11-17 08:07:45 -08:00
Cijo Thomas 68adae64f4
httpwebrequest context propagation when filter is applied (#1562) 2020-11-17 07:25:57 -08:00
Mikel Blanchard d24a042964
ResourceBuilder API (#1533)
* Attempting to improve the Resource API.

* XML comment change.

* Updated Resource API based on feedback.

* CHANGELOG update.

* Tweaked variable name.

* CHANGELOG updates.

* Removed OtelEnvResourceDetector from default Resource. Fixed some XML comments.

* Past tense fix for CHANGELOG.

* CHANGELOG formatting.

* Removed the ability to change the environment variable name for OtelEnvResourceDetector.

* Updates for recent refactors.

* Code review.

* Example updates.

* Cleanup.

Co-authored-by: Cijo Thomas <cithomas@microsoft.com>
2020-11-17 06:55:09 -08:00
Utkarsh Umesan Pillai 65762cd792
Moved SpanHelper to internal (#1555)
* Moved SpanHelper to internal

* Updated CHANGELOG.md

* Updated method to public from internal

Co-authored-by: Cijo Thomas <cithomas@microsoft.com>
2020-11-16 15:33:56 -08:00
Austin Tan 92ec254342
Extracting package versions to common.props (#1538)
* Most of the common props stuff

* remove coverlet from Zpages Test

* Clean up other mention of coverlet in comment

* Moving appropriate package versions to nonprod

* Common.props removal of packagevers

* reverting some changes to a grpc package

* Fixing tabs and adding one more packagae referecne

Co-authored-by: Cijo Thomas <cithomas@microsoft.com>
Co-authored-by: Eddy Nakamura <ednakamu@microsoft.com>
2020-11-16 14:30:45 -08:00
Eddy Nakamura f8a4e6c010
Fixing status description behavior (#1550)
* Fixing status description behavior

* fixing SetStatus behavior onStop method

* Addressing Cijo's comment
2020-11-16 12:19:27 -08:00
Alan West d958505b9c
Conform gRPC span name to spec (#1551)
* Conform gRPC span name to spec

* Update changelog

* Use TrimStart
2020-11-16 11:42:32 -08:00
Eddy Nakamura a944d940c4
Fixing enrich order (#1548) 2020-11-16 10:27:46 -08:00
Cijo Thomas 51806b723a
Mark Activity extension methods not required by spec as internal (#1545)
* Mark activity extensions as internal

* format

* test proj adjustments

* more cleanups

* temporarily remove benchmark. this should be brought back after splitting the project into multiple projects

* fix w3ctracecontext tes

* fix grpctest refs

* Update src/OpenTelemetry.Api/CHANGELOG.md

Co-authored-by: Reiley Yang <reyang@microsoft.com>

Co-authored-by: Reiley Yang <reyang@microsoft.com>
2020-11-15 16:21:00 -08:00
Alan West 4c7d2aef33
Make ZipkinExporter and JaegerExporter internal (#1540)
* Make ZipkinExporter internal

* Make JaegerExporter internal

* Update changelog

Co-authored-by: Cijo Thomas <cithomas@microsoft.com>
2020-11-13 17:35:47 -08:00
Utkarsh Umesan Pillai c409b893f6
Update comments for ServiceName property in ZipkinExporterOptions (#1539)
* Updated Service Name description

* Updated Service Name description
2020-11-13 17:13:45 -08:00
Cijo Thomas 8a76f801e5
Allow users to override instrumentation tags and status (#1537) 2020-11-13 14:26:07 -08:00
Cijo Thomas bf57502ae3
Refactor TracerProviderBuilder to API (#1536)
* Refactor TracerProviderBuilder to API

* REDIS TEST fix
2020-11-13 13:13:43 -08:00
Utkarsh Umesan Pillai 941a0b9413
Implement TracerProvider Shutdown (#1489)
* Add Shutdown method to TracerProvider

* Updated CHANGELOG.md

* Updated the PublicAPI.Unshipped txt files to include the TracerProvider Shutdown andOnShutdown methods

* Updated the OnShutdown method to move listener dispose after processor dispose

* Fixed build issues

* Address PR changes

* Added Instrumentations Dispoe to TracerProviderSdk OnShutdown method

Co-authored-by: Cijo Thomas <cithomas@microsoft.com>
2020-11-13 07:05:23 -08:00
Reiley Yang 6cc8e44d4d
remove unused using statements (#1534) 2020-11-13 06:33:02 -08:00