From f77457174e1420a860468df978eb5de3c47e536e Mon Sep 17 00:00:00 2001 From: Krzesimir Nowak Date: Tue, 5 May 2020 17:46:44 +0200 Subject: [PATCH] Fix issues raised by golangci-lint (#29) These popped up when invoking `make`. Co-authored-by: Liz Fong-Jones --- exporters/metric/datadog/datadog.go | 1 + exporters/metric/datadog/example_test.go | 1 + exporters/metric/dogstatsd/go.mod | 1 - exporters/metric/dogstatsd/go.sum | 3 --- exporters/metric/dogstatsd/labels_test.go | 5 ----- 5 files changed, 2 insertions(+), 9 deletions(-) diff --git a/exporters/metric/datadog/datadog.go b/exporters/metric/datadog/datadog.go index f20e323d4..dfd7541aa 100644 --- a/exporters/metric/datadog/datadog.go +++ b/exporters/metric/datadog/datadog.go @@ -6,6 +6,7 @@ import ( "regexp" "github.com/DataDog/datadog-go/statsd" + "go.opentelemetry.io/otel/api/core" export "go.opentelemetry.io/otel/sdk/export/metric" "go.opentelemetry.io/otel/sdk/export/metric/aggregator" diff --git a/exporters/metric/datadog/example_test.go b/exporters/metric/datadog/example_test.go index e9a86e5c5..24ce4f4e9 100644 --- a/exporters/metric/datadog/example_test.go +++ b/exporters/metric/datadog/example_test.go @@ -5,6 +5,7 @@ import ( "time" "github.com/DataDog/sketches-go/ddsketch" + "go.opentelemetry.io/contrib/exporters/metric/datadog" "go.opentelemetry.io/otel/api/global" "go.opentelemetry.io/otel/api/metric" diff --git a/exporters/metric/dogstatsd/go.mod b/exporters/metric/dogstatsd/go.mod index 33254fd05..7647beeb2 100644 --- a/exporters/metric/dogstatsd/go.mod +++ b/exporters/metric/dogstatsd/go.mod @@ -6,4 +6,3 @@ require ( github.com/stretchr/testify v1.5.1 go.opentelemetry.io/otel v0.4.3 ) - diff --git a/exporters/metric/dogstatsd/go.sum b/exporters/metric/dogstatsd/go.sum index 92e2b9ecd..c637bbbfc 100644 --- a/exporters/metric/dogstatsd/go.sum +++ b/exporters/metric/dogstatsd/go.sum @@ -34,9 +34,6 @@ github.com/stretchr/objx v0.1.0/go.mod h1:HFkY916IF+rwdDfMAkV7OtwuqBVzrE8GR6GFx+ github.com/stretchr/testify v1.4.0/go.mod h1:j7eGeouHqKxXV5pUuKE4zz7dFj8WfuZ+81PSLYec5m4= github.com/stretchr/testify v1.5.1 h1:nOGnQDM7FYENwehXlg/kFVnos3rEvtKTjRvOWSzb6H4= github.com/stretchr/testify v1.5.1/go.mod h1:5W2xD1RspED5o8YsWQXVCued0rvSQ+mT+I5cxcmMvtA= -go.opentelemetry.io v0.1.0 h1:EANZoRCOP+A3faIlw/iN6YEWoYb1vleZRKm1EvH8T48= -go.opentelemetry.io/otel v0.4.2 h1:nT+GOqqRR1cIY92xmo1DeiXLHtIlXH1KLRgnsnhuNrs= -go.opentelemetry.io/otel v0.4.2/go.mod h1:OgNpQOjrlt33Ew6Ds0mGjmcTQg/rhUctsbkRdk/g1fw= go.opentelemetry.io/otel v0.4.3 h1:CroUX/0O1ZDcF0iWOO8gwYFWb5EbdSF0/C1yosO+Vhs= go.opentelemetry.io/otel v0.4.3/go.mod h1:jzBIgIzK43Iu1BpDAXwqOd6UPsSAk+ewVZ5ofSXw4Ek= golang.org/x/crypto v0.0.0-20190308221718-c2843e01d9a2/go.mod h1:djNgcEr1/C05ACkg1iLfiJU5Ep61QUkGW8qpdssI0+w= diff --git a/exporters/metric/dogstatsd/labels_test.go b/exporters/metric/dogstatsd/labels_test.go index 63f67370c..0103c296e 100644 --- a/exporters/metric/dogstatsd/labels_test.go +++ b/exporters/metric/dogstatsd/labels_test.go @@ -31,11 +31,6 @@ var testLabels = []core.KeyValue{ key.Float64("E", 1.5), } -var testResources = []core.KeyValue{ - key.String("R1", "V1"), - key.String("R2", "V2"), -} - func TestLabelSyntax(t *testing.T) { encoder := dogstatsd.NewLabelEncoder()