* Upgrade to semconv/v1.17.0
* Add changes to changelog
* Upgrade remaining semconv
* Update changes to changelog
* Remove stale comment
* Update to head of main for semconvs
* Use DialContext instead of Dial for otelgrpc/test
* Verify no goroutine leaks with t.Cleanup
* Use bufconn to stub a ContextDialer
* Add status code to HTTP metrics
* Update instrumentation/github.com/gorilla/mux/otelmux/mux.go
Co-authored-by: Anthony Mirabella <a9@aneurysm9.com>
---------
Co-authored-by: Anthony Mirabella <a9@aneurysm9.com>
* Implemented aws.ecs.* resource attributes in go.opentelemetry.io/detectors/aws/ecs
* Update detectors/aws/ecs/ecs_test.go
Co-authored-by: Chester Cheung <cheung.zhy.csu@gmail.com>
* Update detectors/aws/ecs/ecs_test.go
Co-authored-by: Chester Cheung <cheung.zhy.csu@gmail.com>
* fix: lower-case the value of aws.ecs.launchtype
* Add aws.logs.* support, remove spurious /aws prefix from log group
* Add tests for V4 on Fargate launch type
* Rebase
* Fix integration tests, fix behavior on Windows
After a surreal session of debugging, it turns out that httptest.NewServer fails on Windows by failing to bind the server socket unless the GoLang package name contains "test". To deal with that, I split the tests between "integration tests" needing a HTTP server into "ecs/test", and the other in "ecs".
In order to work around the need of being resilient to the lack of /proc/self/cgroup (which happens in our tests but, above all, when running containers on Windows), the ECVS detector is now more lenient to not finding the container id.
Co-authored-by: Chester Cheung <cheung.zhy.csu@gmail.com>
* Make go 1.19 the default version for CI, add to version matrix
Signed-off-by: Anthony J Mirabella <a9@aneurysm9.com>
* Replace uses of io/ioutil package
Signed-off-by: Anthony J Mirabella <a9@aneurysm9.com>
* gofmt fixes
Signed-off-by: Anthony J Mirabella <a9@aneurysm9.com>
* Update CHANGELOG and README
Signed-off-by: Anthony J Mirabella <a9@aneurysm9.com>
* Replace use of unmaintained `esc` with `go:embed`
Signed-off-by: Anthony J Mirabella <a9@aneurysm9.com>
* Ensure open files are closed before cleaning them up
Signed-off-by: Anthony J Mirabella <a9@aneurysm9.com>
Signed-off-by: Anthony J Mirabella <a9@aneurysm9.com>
* Make ECS detector not error when not on platform
The OpenTelemetry specification states "failure to detect any resource
information MUST NOT be considered an error". Update the ECS detector to
not return an error when not running on the ECS platform.
Additionally, return nil instead of an empty resource to accommodate a
quick merge when this detector is used. A nil value means the other
resource this will be merged with will be returned immediately instead
of working through the actual merge.
* Add changes to changelog
* Match ECS detector tests with expected behavior
* Add PR number to changelog
* Remove unused errNotOnECS
* add ECS resource Detector
* add comments to methods
* refactored naming convention and methods to use mocking client
* added comments to tests
* refactor env variables with more clearer names
* update changelog and rename variables
Taka Nishida
Tyler Yahn
Andrew Hobson
Michele Mancioppi
Anthony Mirabella
Abi Hafshin Alfarouq
Bhautik Pipaliya
Kelvin Lo