Commit Graph

3 Commits

Author SHA1 Message Date
Tyler Yahn 0fe41992b2
Update AWS detector assert dependency (#574)
* Update AWS detector assert dependency

Use the stretchr testify assert package.

* Update Go module dependencies
2021-02-18 08:36:48 -08:00
Bhautik Pipaliya bd90f3e3b2
Eks resource detector bugfix (#575)
* added failure scenario when getting container fails

* fix test case failure

* add changelog

* fix ecs resource detector bug

* fix struct name as per golint suggestion

* minor changes

* added NewResourceDetector func and interface assertions

* fix golint failure

* minor changes to address review comments

* fix eks resource detector bug

* comment changes

* fix typo

Co-authored-by: Anthony Mirabella <a9@aneurysm9.com>
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
2021-02-16 07:26:32 -08:00
Wilbert Guo b02fae7b25
Add Amazon EKS Resource Detector (#465)
* Add EKS Resource Detector

* Remove getK8sCredHeader() from detectorUtils interface

* Change implementation for getContainerId() to be consistent with ecs resource detector

* Change code to use resource.Empty()

* Add comments to functions

* Update error handling with useful messages

* Delete unused variables in EKS resource detector tests

* Add whitespace around operators

* Add space around "-" operator

* Update comments for functions to be more descriptive

* Update CHANGELOG.md

* Fix spaces around operators.

* Change "GET" to use http.MethodGet

Co-authored-by: Anthony Mirabella <a9@aneurysm9.com>

* Update error message for retrieving auth configmap

Co-authored-by: Anthony Mirabella <a9@aneurysm9.com>

* Update error message for HTTP request

Co-authored-by: Anthony Mirabella <a9@aneurysm9.com>

* Update error message for executing HTTP request

Co-authored-by: Anthony Mirabella <a9@aneurysm9.com>

* Update error message for HTTP response

Co-authored-by: Anthony Mirabella <a9@aneurysm9.com>

* Update error message for getClusterName

Co-authored-by: Anthony Mirabella <a9@aneurysm9.com>

* Update error message for parsing JSON for clusterName

Co-authored-by: Anthony Mirabella <a9@aneurysm9.com>

* Update error message for reading file

Co-authored-by: Anthony Mirabella <a9@aneurysm9.com>

* Fix build errors

* Change JSON parsing to use map[string]interface{}

* Add check for HTTP response status code in error handling

* Refactor millisecondTimeOut variable name to timeoutMillis

* Update CHANGELOG.md

Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>

* Update detectors/aws/eks/go.mod

Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>

* Update detectors/aws/go.sum

Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>

* Update detectors/aws/eks/go.mod

Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>

* Update detectors/aws/eks/eks_resource_detector.go

Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>

* Update detectors/aws/eks/eks_resource_detector.go

Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>

* Update detectors/aws/eks/eks_resource_detector.go

Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>

* Update detectors/aws/eks/eks_resource_detector.go

Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>

* Update detectors/aws/eks/eks_resource_detector.go

Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>

* Update detectors/aws/eks/eks_resource_detector.go

Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>

* Update detectors/aws/eks/eks_resource_detector.go

Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>

* Update detectors/aws/eks/eks_resource_detector.go

Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>

* Update detectors/aws/eks/eks_resource_detector.go

Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>

* Update detectors/aws/eks/eks_resource_detector.go

Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>

* Update detectors/aws/eks/eks_resource_detector.go

Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>

* Update detectors/aws/eks/eks_resource_detector.go

Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>

* Update detectors/aws/eks/eks_resource_detector_test.go

Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>

* Update detectors/aws/eks/eks_resource_detector_test.go

Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>

* Update detectors/aws/eks/eks_resource_detector_test.go

Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>

* Update detectors/aws/eks/eks_resource_detector_test.go

Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>

* Fix build error and address changes to PR

* Change getContainerID() to use regex

* Update detectors/aws/eks/detector.go

Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>

* Update detectors/aws/eks/detector.go

Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>

Co-authored-by: Anthony Mirabella <a9@aneurysm9.com>
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
2020-12-04 12:56:06 -08:00