From 5c6ac6fa1165054e213ba5c90d6d75fdf0ee2857 Mon Sep 17 00:00:00 2001 From: Jean Bisutti Date: Wed, 18 Oct 2023 17:53:59 +0200 Subject: [PATCH] Rename runtime attach method (#1077) --- runtime-attach/README.md | 2 +- .../opentelemetry/contrib/attach/core/CoreRuntimeAttach.java | 2 +- .../java/io/opentelemetry/contrib/attach/RuntimeAttach.java | 4 ++-- .../attach/AgentDisabledByEnvironmentVariableTest.java | 2 +- .../contrib/attach/AgentDisabledBySystemPropertyTest.java | 2 +- .../opentelemetry/contrib/attach/RunTimeAttachBasicTest.java | 2 +- 6 files changed, 7 insertions(+), 7 deletions(-) diff --git a/runtime-attach/README.md b/runtime-attach/README.md index 695124f8..294345a7 100644 --- a/runtime-attach/README.md +++ b/runtime-attach/README.md @@ -39,7 +39,7 @@ We give below an example for Spring Boot applications: public class SpringBootApp { public static void main(String[] args) { - RuntimeAttach.attachJavaagentToCurrentJVM(); + RuntimeAttach.attachJavaagentToCurrentJvm(); SpringApplication.run(SpringBootApp.class, args); } diff --git a/runtime-attach/runtime-attach-core/src/main/java/io/opentelemetry/contrib/attach/core/CoreRuntimeAttach.java b/runtime-attach/runtime-attach-core/src/main/java/io/opentelemetry/contrib/attach/core/CoreRuntimeAttach.java index dab3217f..ee5545f7 100644 --- a/runtime-attach/runtime-attach-core/src/main/java/io/opentelemetry/contrib/attach/core/CoreRuntimeAttach.java +++ b/runtime-attach/runtime-attach-core/src/main/java/io/opentelemetry/contrib/attach/core/CoreRuntimeAttach.java @@ -35,7 +35,7 @@ public final class CoreRuntimeAttach { * beginning of the main method. */ @SuppressWarnings("MemberName") - public void attachJavaagentToCurrentJVM() { + public void attachJavaagentToCurrentJvm() { if (!shouldAttach()) { return; } diff --git a/runtime-attach/runtime-attach/src/main/java/io/opentelemetry/contrib/attach/RuntimeAttach.java b/runtime-attach/runtime-attach/src/main/java/io/opentelemetry/contrib/attach/RuntimeAttach.java index 9c97720a..2d1e1ff1 100644 --- a/runtime-attach/runtime-attach/src/main/java/io/opentelemetry/contrib/attach/RuntimeAttach.java +++ b/runtime-attach/runtime-attach/src/main/java/io/opentelemetry/contrib/attach/RuntimeAttach.java @@ -15,11 +15,11 @@ public final class RuntimeAttach { * beginning of the main method. */ @SuppressWarnings("MemberName") - public static void attachJavaagentToCurrentJVM() { + public static void attachJavaagentToCurrentJvm() { CoreRuntimeAttach distroRuntimeAttach = new CoreRuntimeAttach("/otel-agent.jar"); - distroRuntimeAttach.attachJavaagentToCurrentJVM(); + distroRuntimeAttach.attachJavaagentToCurrentJvm(); } private RuntimeAttach() {} diff --git a/runtime-attach/runtime-attach/src/test/java/io/opentelemetry/contrib/attach/AgentDisabledByEnvironmentVariableTest.java b/runtime-attach/runtime-attach/src/test/java/io/opentelemetry/contrib/attach/AgentDisabledByEnvironmentVariableTest.java index 5ad6f71a..41571a2e 100644 --- a/runtime-attach/runtime-attach/src/test/java/io/opentelemetry/contrib/attach/AgentDisabledByEnvironmentVariableTest.java +++ b/runtime-attach/runtime-attach/src/test/java/io/opentelemetry/contrib/attach/AgentDisabledByEnvironmentVariableTest.java @@ -14,7 +14,7 @@ public class AgentDisabledByEnvironmentVariableTest extends AbstractAttachmentTe @Test void shouldNotAttachWhenAgentDisabledWithEnvVariable() { - RuntimeAttach.attachJavaagentToCurrentJVM(); + RuntimeAttach.attachJavaagentToCurrentJvm(); verifyNoAttachment(); } diff --git a/runtime-attach/runtime-attach/src/test/java/io/opentelemetry/contrib/attach/AgentDisabledBySystemPropertyTest.java b/runtime-attach/runtime-attach/src/test/java/io/opentelemetry/contrib/attach/AgentDisabledBySystemPropertyTest.java index 39a071ee..a24c8129 100644 --- a/runtime-attach/runtime-attach/src/test/java/io/opentelemetry/contrib/attach/AgentDisabledBySystemPropertyTest.java +++ b/runtime-attach/runtime-attach/src/test/java/io/opentelemetry/contrib/attach/AgentDisabledBySystemPropertyTest.java @@ -14,7 +14,7 @@ public class AgentDisabledBySystemPropertyTest extends AbstractAttachmentTest { @Test void shouldNotAttachWhenAgentDisabledWithProperty() { - RuntimeAttach.attachJavaagentToCurrentJVM(); + RuntimeAttach.attachJavaagentToCurrentJvm(); verifyNoAttachment(); } diff --git a/runtime-attach/runtime-attach/src/test/java/io/opentelemetry/contrib/attach/RunTimeAttachBasicTest.java b/runtime-attach/runtime-attach/src/test/java/io/opentelemetry/contrib/attach/RunTimeAttachBasicTest.java index 3f043647..5d8f201a 100644 --- a/runtime-attach/runtime-attach/src/test/java/io/opentelemetry/contrib/attach/RunTimeAttachBasicTest.java +++ b/runtime-attach/runtime-attach/src/test/java/io/opentelemetry/contrib/attach/RunTimeAttachBasicTest.java @@ -14,7 +14,7 @@ public class RunTimeAttachBasicTest extends AbstractAttachmentTest { @Test void shouldAttach() { - RuntimeAttach.attachJavaagentToCurrentJVM(); + RuntimeAttach.attachJavaagentToCurrentJvm(); verifyAttachment(); }