open-telemetry
/
opentelemetry-java-instrumentation
mirror of https://github.com/open-telemetry/opentelemetry-java-instrumentation.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Better span names for cassandra (#237)

This commit is contained in:
Trask Stalnaker 2020-03-19 10:33:39 -07:00 committed by GitHub
parent 56a1227afe
commit 07c5923f20
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

0
instrumentation/cassandra-3.0/.toDelete Normal file
View File

2
instrumentation/cassandra-3.0/src/main/java/io/opentelemetry/auto/instrumentation/datastax/cassandra/TracingSession.java
View File

@ -260,7 +260,7 @@ public class TracingSession implements Session {
} }
private Span startSpan(final String query) { private Span startSpan(final String query) {
final Span span = TRACER.spanBuilder("cassandra.query").setSpanKind(CLIENT).startSpan(); final Span span = TRACER.spanBuilder(query).setSpanKind(CLIENT).startSpan();
DECORATE.afterStart(span); DECORATE.afterStart(span);
DECORATE.onConnection(span, session); DECORATE.onConnection(span, session);
DECORATE.onStatement(span, query); DECORATE.onStatement(span, query);

2
instrumentation/cassandra-3.0/src/test/groovy/CassandraClientTest.groovy
View File

@ -125,7 +125,7 @@ class CassandraClientTest extends AgentTestRunner {
def cassandraSpan(TraceAssert trace, int index, String statement, String keyspace, boolean renameService, Object parentSpan = null, Throwable exception = null) { def cassandraSpan(TraceAssert trace, int index, String statement, String keyspace, boolean renameService, Object parentSpan = null, Throwable exception = null) {
trace.span(index) { trace.span(index) {
operationName "cassandra.query" operationName statement
spanKind CLIENT spanKind CLIENT
if (parentSpan == null) { if (parentSpan == null) {
parent() parent()