open-telemetry
/
opentelemetry-java-instrumentation
mirror of https://github.com/open-telemetry/opentelemetry-java-instrumentation.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Catch `AbstractMethodError` when trying to unwrap jdbc connection 

jdts throws this exception since they just have 'stub' umplementation.
This commit is contained in:
Nikolay Martynov 2018-11-01 09:57:18 -04:00
parent 8a066de772
commit 15024915bf
2 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
dd-java-agent/instrumentation/jdbc/src/main/java/datadog/trace/instrumentation/jdbc/PreparedStatementInstrumentation.java
View File

@ -70,9 +70,10 @@ public final class PreparedStatementInstrumentation extends Instrumenter.Default
if (connection.isWrapperFor(Connection.class)) { if (connection.isWrapperFor(Connection.class)) {
connection = connection.unwrap(Connection.class); connection = connection.unwrap(Connection.class);
} }
} catch (final Exception e) { } catch (final Exception | AbstractMethodError e) {
// perhaps wrapping isn't supported? // perhaps wrapping isn't supported?
// ex: org.h2.jdbc.JdbcConnection v1.3.175 // ex: org.h2.jdbc.JdbcConnection v1.3.175
// or: jdts.jdbc which always throws `AbstractMethodError` (at least up to version 1.3)
// Stick with original connection. // Stick with original connection.
} }
} catch (final Throwable e) { } catch (final Throwable e) {

3
dd-java-agent/instrumentation/jdbc/src/main/java/datadog/trace/instrumentation/jdbc/StatementInstrumentation.java
View File

@ -71,9 +71,10 @@ public final class StatementInstrumentation extends Instrumenter.Default {
if (connection.isWrapperFor(Connection.class)) { if (connection.isWrapperFor(Connection.class)) {
connection = connection.unwrap(Connection.class); connection = connection.unwrap(Connection.class);
} }
} catch (final Exception e) { } catch (final Exception | AbstractMethodError e) {
// perhaps wrapping isn't supported? // perhaps wrapping isn't supported?
// ex: org.h2.jdbc.JdbcConnection v1.3.175 // ex: org.h2.jdbc.JdbcConnection v1.3.175
// or: jdts.jdbc which always throws `AbstractMethodError` (at least up to version 1.3)
// Stick with original connection. // Stick with original connection.
} }
} catch (final Throwable e) { } catch (final Throwable e) {