From 1d388dd43305d38abb1e4cead73abf071c574248 Mon Sep 17 00:00:00 2001 From: Guillaume Polaert Date: Wed, 3 May 2017 10:06:01 +0200 Subject: [PATCH] [PR #1] cleaning --- src/main/java/com/datadoghq/trace/impl/DDSpan.java | 1 + src/main/java/com/datadoghq/trace/impl/DDTracer.java | 2 -- .../java/com/datadoghq/trace/writer/impl/DDAgentWriter.java | 1 + 3 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/main/java/com/datadoghq/trace/impl/DDSpan.java b/src/main/java/com/datadoghq/trace/impl/DDSpan.java index c5162d820b..e8cb1b70dd 100644 --- a/src/main/java/com/datadoghq/trace/impl/DDSpan.java +++ b/src/main/java/com/datadoghq/trace/impl/DDSpan.java @@ -80,6 +80,7 @@ public class DDSpan implements io.opentracing.Span { this.context.getTrace().add(this); // check DD attributes required + // FIXME Remove IAE if (this.context.getServiceName() == null) { throw new IllegalArgumentException("No ServiceName provided"); } diff --git a/src/main/java/com/datadoghq/trace/impl/DDTracer.java b/src/main/java/com/datadoghq/trace/impl/DDTracer.java index cad48be638..5d6733fa6d 100644 --- a/src/main/java/com/datadoghq/trace/impl/DDTracer.java +++ b/src/main/java/com/datadoghq/trace/impl/DDTracer.java @@ -228,10 +228,8 @@ public class DDTracer implements io.opentracing.Tracer { return context; } - } - @Override public String toString() { return "DDTracer{" + diff --git a/src/main/java/com/datadoghq/trace/writer/impl/DDAgentWriter.java b/src/main/java/com/datadoghq/trace/writer/impl/DDAgentWriter.java index 817dd0b2eb..9df88b485a 100644 --- a/src/main/java/com/datadoghq/trace/writer/impl/DDAgentWriter.java +++ b/src/main/java/com/datadoghq/trace/writer/impl/DDAgentWriter.java @@ -75,6 +75,7 @@ public class DDAgentWriter implements Writer { */ public void write(List trace) { //Try to add a new span in the queue + //FIXME oldest? boolean proceed = tokens.tryAcquire(trace.size()); if (proceed) {