diff --git a/dd-java-agent/instrumentation/kafka-clients-0.11/src/main/java/datadog/trace/instrumentation/kafka_clients/KafkaDecorator.java b/dd-java-agent/instrumentation/kafka-clients-0.11/src/main/java/datadog/trace/instrumentation/kafka_clients/KafkaDecorator.java index 8d02bc7d0d..cbd222383a 100644 --- a/dd-java-agent/instrumentation/kafka-clients-0.11/src/main/java/datadog/trace/instrumentation/kafka_clients/KafkaDecorator.java +++ b/dd-java-agent/instrumentation/kafka-clients-0.11/src/main/java/datadog/trace/instrumentation/kafka_clients/KafkaDecorator.java @@ -12,11 +12,6 @@ import org.apache.kafka.clients.producer.ProducerRecord; public abstract class KafkaDecorator extends ClientDecorator { public static final KafkaDecorator PRODUCER_DECORATE = new KafkaDecorator() { - @Override - protected String service() { - return "kafka"; - } - @Override protected String spanKind() { return Tags.SPAN_KIND_PRODUCER; @@ -30,16 +25,6 @@ public abstract class KafkaDecorator extends ClientDecorator { public static final KafkaDecorator CONSUMER_DECORATE = new KafkaDecorator() { - @Override - protected String service() { - /* - Use default service name. Common use-case here is to have consumer span parent - children spans in instrumented application. Since service name is inherited it makes - sense to default that to application service name rather than 'kafka'. - */ - return null; - } - @Override protected String spanKind() { return Tags.SPAN_KIND_CONSUMER; @@ -56,6 +41,11 @@ public abstract class KafkaDecorator extends ClientDecorator { return new String[] {"kafka"}; } + @Override + protected String service() { + return "kafka"; + } + @Override protected String component() { return "java-kafka"; diff --git a/dd-java-agent/instrumentation/kafka-clients-0.11/src/test/groovy/KafkaClientTest.groovy b/dd-java-agent/instrumentation/kafka-clients-0.11/src/test/groovy/KafkaClientTest.groovy index 49238f8357..b22b6c30e4 100644 --- a/dd-java-agent/instrumentation/kafka-clients-0.11/src/test/groovy/KafkaClientTest.groovy +++ b/dd-java-agent/instrumentation/kafka-clients-0.11/src/test/groovy/KafkaClientTest.groovy @@ -94,7 +94,7 @@ class KafkaClientTest extends AgentTestRunner { trace(1, 1) { // CONSUMER span 0 span(0) { - serviceName "unnamed-java-app" + serviceName "kafka" operationName "kafka.consume" resourceName "Consume Topic $SHARED_TOPIC" spanType "queue" diff --git a/dd-java-agent/instrumentation/kafka-streams-0.11/src/test/groovy/KafkaStreamsTest.groovy b/dd-java-agent/instrumentation/kafka-streams-0.11/src/test/groovy/KafkaStreamsTest.groovy index cc8a7ce2c1..d74433ec11 100644 --- a/dd-java-agent/instrumentation/kafka-streams-0.11/src/test/groovy/KafkaStreamsTest.groovy +++ b/dd-java-agent/instrumentation/kafka-streams-0.11/src/test/groovy/KafkaStreamsTest.groovy @@ -80,13 +80,13 @@ class KafkaStreamsTest extends AgentTestRunner { KStream textLines = builder.stream(STREAM_PENDING) def values = textLines .mapValues(new ValueMapper() { - @Override - String apply(String textLine) { - TEST_WRITER.waitForTraces(1) // ensure consistent ordering of traces - getTestTracer().activeSpan().setTag("asdf", "testing") - return textLine.toLowerCase() - } - }) + @Override + String apply(String textLine) { + TEST_WRITER.waitForTraces(1) // ensure consistent ordering of traces + getTestTracer().activeSpan().setTag("asdf", "testing") + return textLine.toLowerCase() + } + }) KafkaStreams streams try { @@ -172,7 +172,7 @@ class KafkaStreamsTest extends AgentTestRunner { trace(2, 1) { // CONSUMER span 0 span(0) { - serviceName "unnamed-java-app" + serviceName "kafka" operationName "kafka.consume" resourceName "Consume Topic $STREAM_PROCESSED" spanType "queue" diff --git a/dd-java-agent/instrumentation/rabbitmq-amqp-2.7/src/main/java/datadog/trace/instrumentation/rabbitmq/amqp/RabbitDecorator.java b/dd-java-agent/instrumentation/rabbitmq-amqp-2.7/src/main/java/datadog/trace/instrumentation/rabbitmq/amqp/RabbitDecorator.java index 10160b6488..66b3122f5b 100644 --- a/dd-java-agent/instrumentation/rabbitmq-amqp-2.7/src/main/java/datadog/trace/instrumentation/rabbitmq/amqp/RabbitDecorator.java +++ b/dd-java-agent/instrumentation/rabbitmq-amqp-2.7/src/main/java/datadog/trace/instrumentation/rabbitmq/amqp/RabbitDecorator.java @@ -27,16 +27,6 @@ public class RabbitDecorator extends ClientDecorator { public static final RabbitDecorator CONSUMER_DECORATE = new RabbitDecorator() { - @Override - protected String service() { - /* - Use default service name. Common use-case here is to have consumer span parent - children spans in instrumented application. Since service name is inherited it makes - sense to default that to application service name rather than 'rabbitmq'. - */ - return null; - } - @Override protected String spanKind() { return Tags.SPAN_KIND_CONSUMER; diff --git a/dd-java-agent/instrumentation/rabbitmq-amqp-2.7/src/test/groovy/RabbitMQTest.groovy b/dd-java-agent/instrumentation/rabbitmq-amqp-2.7/src/test/groovy/RabbitMQTest.groovy index 558520c17a..fe1db12e0b 100644 --- a/dd-java-agent/instrumentation/rabbitmq-amqp-2.7/src/test/groovy/RabbitMQTest.groovy +++ b/dd-java-agent/instrumentation/rabbitmq-amqp-2.7/src/test/groovy/RabbitMQTest.groovy @@ -341,14 +341,7 @@ class RabbitMQTest extends AgentTestRunner { String errorMsg = null ) { trace.span(index) { - switch (span.tags["amqp.command"]) { - case "basic.get": - case "basic.deliver": - serviceName "unnamed-java-app" - break - default: - serviceName "rabbitmq" - } + serviceName "rabbitmq" operationName "amqp.command" resourceName resource switch (span.tags["amqp.command"]) {