Merge pull request #481 from DataDog/gary/muzzle-spring-web

Muzzle Spring Web Instrumentation
This commit is contained in:
Gary Huang 2018-09-10 20:00:46 -04:00 committed by GitHub
commit 202deaa0a6
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 8 additions and 19 deletions

View File

@ -1,15 +1,11 @@
//apply plugin: 'version-scan'
//
//versionScan {
// group = 'org.springframework'
// module = 'spring-webmvc'
// legacyModule = "servlet-api"
// versions = "[3.0,)"
// verifyPresent = [
// "javax.servlet.AsyncEvent" : null,
// "javax.servlet.AsyncListener": null,
// ]
//}
muzzle {
pass {
group = 'org.springframework'
module = 'javax.servlet.api'
versions = "[3.0.0.RELEASE,)"
extraDependency "javax.servlet:javax.servlet.api:3.0.0"
}
}
apply from: "${rootDir}/gradle/java.gradle"

View File

@ -1,7 +1,6 @@
package datadog.trace.instrumentation.springweb;
import static datadog.trace.agent.tooling.ByteBuddyElementMatchers.safeHasSuperType;
import static datadog.trace.agent.tooling.ClassLoaderMatcher.classLoaderHasClassWithField;
import static io.opentracing.log.Fields.ERROR_OBJECT;
import static net.bytebuddy.matcher.ElementMatchers.isInterface;
import static net.bytebuddy.matcher.ElementMatchers.isMethod;
@ -46,12 +45,6 @@ public final class HandlerAdapterInstrumentation extends Instrumenter.Default {
.and(safeHasSuperType(named("org.springframework.web.servlet.HandlerAdapter")));
}
@Override
public ElementMatcher<ClassLoader> classLoaderMatcher() {
return classLoaderHasClassWithField(
"org.springframework.web.servlet.HandlerMapping", "BEST_MATCHING_PATTERN_ATTRIBUTE");
}
@Override
public Map<ElementMatcher, String> transformers() {
return Collections.<ElementMatcher, String>singletonMap(