open-telemetry
/
opentelemetry-java-instrumentation
mirror of https://github.com/open-telemetry/opentelemetry-java-instrumentation.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Make HttpStatusConverter package private (#5268)

This commit is contained in:
Mateusz Rzeszutek 2022-01-31 08:35:48 +01:00 committed by GitHub
parent aa2ac33b70
commit 236a42f111
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 22 additions and 54 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

25
instrumentation-api/src/main/java/io/opentelemetry/instrumentation/api/instrumenter/http/HttpClientStatusConverter.java
View File

@ -1,25 +0,0 @@
/*
* Copyright The OpenTelemetry Authors
* SPDX-License-Identifier: Apache-2.0
*/
package io.opentelemetry.instrumentation.api.instrumenter.http;
import io.opentelemetry.api.trace.StatusCode;
final class HttpClientStatusConverter implements HttpStatusConverter {
static final HttpStatusConverter INSTANCE = new HttpClientStatusConverter();
// https://github.com/open-telemetry/opentelemetry-specification/blob/master/specification/trace/semantic_conventions/http.md#status
@Override
public StatusCode statusFromHttpStatus(int httpStatus) {
if (httpStatus >= 100 && httpStatus < 400) {
return StatusCode.UNSET;
}
return StatusCode.ERROR;
}
private HttpClientStatusConverter() {}
}

25
instrumentation-api/src/main/java/io/opentelemetry/instrumentation/api/instrumenter/http/HttpServerStatusConverter.java
View File

@ -1,25 +0,0 @@
/*
* Copyright The OpenTelemetry Authors
* SPDX-License-Identifier: Apache-2.0
*/
package io.opentelemetry.instrumentation.api.instrumenter.http;
import io.opentelemetry.api.trace.StatusCode;
final class HttpServerStatusConverter implements HttpStatusConverter {
static final HttpStatusConverter INSTANCE = new HttpServerStatusConverter();
// https://github.com/open-telemetry/opentelemetry-specification/blob/master/specification/trace/semantic_conventions/http.md#status
@Override
public StatusCode statusFromHttpStatus(int httpStatus) {
if (httpStatus >= 100 && httpStatus < 500) {
return StatusCode.UNSET;
}
return StatusCode.ERROR;
}
private HttpServerStatusConverter() {}
}

30
instrumentation-api/src/main/java/io/opentelemetry/instrumentation/api/instrumenter/http/HttpStatusConverter.java
View File

@ -7,10 +7,28 @@ package io.opentelemetry.instrumentation.api.instrumenter.http;
import io.opentelemetry.api.trace.StatusCode;
public interface HttpStatusConverter {
HttpStatusConverter SERVER = HttpServerStatusConverter.INSTANCE;
HttpStatusConverter CLIENT = HttpClientStatusConverter.INSTANCE;
StatusCode statusFromHttpStatus(int httpStatus);
// https://github.com/open-telemetry/opentelemetry-specification/blob/master/specification/trace/semantic_conventions/http.md#status
enum HttpStatusConverter {
SERVER {
@Override
StatusCode statusFromHttpStatus(int httpStatus) {
if (httpStatus >= 100 && httpStatus < 500) {
return StatusCode.UNSET;
}
return StatusCode.ERROR;
}
},
CLIENT {
@Override
StatusCode statusFromHttpStatus(int httpStatus) {
if (httpStatus >= 100 && httpStatus < 400) {
return StatusCode.UNSET;
}
return StatusCode.ERROR;
}
};
abstract StatusCode statusFromHttpStatus(int httpStatus);
}