Rename propagation modules (#1706)

* Rename propagation modules

* Fix test
This commit is contained in:
Trask Stalnaker 2020-11-20 05:05:30 -08:00 committed by GitHub
parent 55a6a858f7
commit 238e2ddca5
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
23 changed files with 21 additions and 19 deletions

View File

@ -3,7 +3,7 @@
* SPDX-License-Identifier: Apache-2.0 * SPDX-License-Identifier: Apache-2.0
*/ */
package io.opentelemetry.javaagent.instrumentation.akkaconcurrent; package io.opentelemetry.javaagent.instrumentation.akkaactor;
import static java.util.Arrays.asList; import static java.util.Arrays.asList;
@ -18,9 +18,9 @@ import java.util.Map;
import java.util.concurrent.Callable; import java.util.concurrent.Callable;
@AutoService(InstrumentationModule.class) @AutoService(InstrumentationModule.class)
public class AkkaContextPropagationInstrumentationModule extends InstrumentationModule { public class AkkaActorInstrumentationModule extends InstrumentationModule {
public AkkaContextPropagationInstrumentationModule() { public AkkaActorInstrumentationModule() {
super("akka-context-propagation", "akka-context-propagation-2.5"); super("akka-actor", "akka-actor-2.5");
} }
@Override @Override

View File

@ -3,7 +3,7 @@
* SPDX-License-Identifier: Apache-2.0 * SPDX-License-Identifier: Apache-2.0
*/ */
package io.opentelemetry.javaagent.instrumentation.akkaconcurrent; package io.opentelemetry.javaagent.instrumentation.akkaactor;
import static net.bytebuddy.matcher.ElementMatchers.nameMatches; import static net.bytebuddy.matcher.ElementMatchers.nameMatches;
import static net.bytebuddy.matcher.ElementMatchers.named; import static net.bytebuddy.matcher.ElementMatchers.named;

View File

@ -3,7 +3,7 @@
* SPDX-License-Identifier: Apache-2.0 * SPDX-License-Identifier: Apache-2.0
*/ */
package io.opentelemetry.javaagent.instrumentation.akkaconcurrent; package io.opentelemetry.javaagent.instrumentation.akkaactor;
import static io.opentelemetry.javaagent.tooling.ClassLoaderMatcher.hasClassesNamed; import static io.opentelemetry.javaagent.tooling.ClassLoaderMatcher.hasClassesNamed;
import static io.opentelemetry.javaagent.tooling.bytebuddy.matcher.AgentElementMatchers.extendsClass; import static io.opentelemetry.javaagent.tooling.bytebuddy.matcher.AgentElementMatchers.extendsClass;

View File

@ -7,7 +7,7 @@ import io.opentelemetry.instrumentation.test.AgentTestRunner
class AkkaActorTest extends AgentTestRunner { class AkkaActorTest extends AgentTestRunner {
// TODO this test doesn't really depend on otel.instrumentation.akka_context_propagation.enabled=true // TODO this test doesn't really depend on otel.instrumentation.akka-actor.enabled=true
// but setting this property here is needed when running both this test // but setting this property here is needed when running both this test
// and AkkaExecutorInstrumentationTest in the run, otherwise get // and AkkaExecutorInstrumentationTest in the run, otherwise get
// "class redefinition failed: attempted to change superclass or interfaces" // "class redefinition failed: attempted to change superclass or interfaces"
@ -16,7 +16,7 @@ class AkkaActorTest extends AgentTestRunner {
// instrumentation in this module, is it just to verify that the instrumentation doesn't break // instrumentation in this module, is it just to verify that the instrumentation doesn't break
// this scenario?) // this scenario?)
static { static {
System.setProperty("otel.instrumentation.akka_context_propagation.enabled", "true") System.setProperty("otel.instrumentation.akka-actor.enabled", "true")
} }
def "akka #testMethod"() { def "akka #testMethod"() {

View File

@ -25,7 +25,7 @@ import spock.lang.Shared
class AkkaExecutorInstrumentationTest extends AgentTestRunner { class AkkaExecutorInstrumentationTest extends AgentTestRunner {
static { static {
System.setProperty("otel.instrumentation.akka_context_propagation.enabled", "true") System.setProperty("otel.instrumentation.akka-actor.enabled", "true")
} }
@Shared @Shared

View File

@ -3,7 +3,7 @@
* SPDX-License-Identifier: Apache-2.0 * SPDX-License-Identifier: Apache-2.0
*/ */
package io.opentelemetry.javaagent.instrumentation.kotlincoroutines; package io.opentelemetry.javaagent.instrumentation.kotlinxcoroutines;
import static java.util.Collections.singletonList; import static java.util.Collections.singletonList;
import static net.bytebuddy.matcher.ElementMatchers.named; import static net.bytebuddy.matcher.ElementMatchers.named;
@ -53,7 +53,7 @@ public class KotlinCoroutinesInstrumentationModule extends InstrumentationModule
*/ */
public KotlinCoroutinesInstrumentationModule() { public KotlinCoroutinesInstrumentationModule() {
super("kotlin-coroutines"); super("kotlinx-coroutines");
} }
@Override @Override
@ -134,6 +134,7 @@ public class KotlinCoroutinesInstrumentationModule extends InstrumentationModule
this.contextWrapper = new CoroutineContextWrapper(proxy.getContext()); this.contextWrapper = new CoroutineContextWrapper(proxy.getContext());
} }
@Override
public String toString() { public String toString() {
return proxy.toString(); return proxy.toString();
} }
@ -188,6 +189,7 @@ public class KotlinCoroutinesInstrumentationModule extends InstrumentationModule
return proxy.plus(coroutineContext); return proxy.plus(coroutineContext);
} }
@Override
public String toString() { public String toString() {
return proxy.toString(); return proxy.toString();
} }

View File

@ -3,9 +3,9 @@
* SPDX-License-Identifier: Apache-2.0 * SPDX-License-Identifier: Apache-2.0
*/ */
package io.opentelemetry.javaagent.instrumentation.scalaconcurrent; package io.opentelemetry.javaagent.instrumentation.scalaexecutors;
import static io.opentelemetry.javaagent.instrumentation.scalaconcurrent.ScalaForkJoinTaskInstrumentation.TASK_CLASS_NAME; import static io.opentelemetry.javaagent.instrumentation.scalaexecutors.ScalaForkJoinTaskInstrumentation.TASK_CLASS_NAME;
import static java.util.Arrays.asList; import static java.util.Arrays.asList;
import com.google.auto.service.AutoService; import com.google.auto.service.AutoService;
@ -21,7 +21,7 @@ import java.util.concurrent.Callable;
@AutoService(InstrumentationModule.class) @AutoService(InstrumentationModule.class)
public class ScalaConcurrentInstrumentationModule extends InstrumentationModule { public class ScalaConcurrentInstrumentationModule extends InstrumentationModule {
public ScalaConcurrentInstrumentationModule() { public ScalaConcurrentInstrumentationModule() {
super("scala-concurrent"); super("scala-executors");
} }
@Override @Override

View File

@ -3,7 +3,7 @@
* SPDX-License-Identifier: Apache-2.0 * SPDX-License-Identifier: Apache-2.0
*/ */
package io.opentelemetry.javaagent.instrumentation.scalaconcurrent; package io.opentelemetry.javaagent.instrumentation.scalaexecutors;
import static net.bytebuddy.matcher.ElementMatchers.nameMatches; import static net.bytebuddy.matcher.ElementMatchers.nameMatches;
import static net.bytebuddy.matcher.ElementMatchers.named; import static net.bytebuddy.matcher.ElementMatchers.named;

View File

@ -3,7 +3,7 @@
* SPDX-License-Identifier: Apache-2.0 * SPDX-License-Identifier: Apache-2.0
*/ */
package io.opentelemetry.javaagent.instrumentation.scalaconcurrent; package io.opentelemetry.javaagent.instrumentation.scalaexecutors;
import static io.opentelemetry.javaagent.tooling.ClassLoaderMatcher.hasClassesNamed; import static io.opentelemetry.javaagent.tooling.ClassLoaderMatcher.hasClassesNamed;
import static io.opentelemetry.javaagent.tooling.bytebuddy.matcher.AgentElementMatchers.extendsClass; import static io.opentelemetry.javaagent.tooling.bytebuddy.matcher.AgentElementMatchers.extendsClass;

View File

@ -53,7 +53,7 @@ include ':utils:test-utils'
// smoke tests // smoke tests
include ':smoke-tests' include ':smoke-tests'
include ':instrumentation:akka-context-propagation-2.5' include ':instrumentation:akka-actor-2.5'
include ':instrumentation:akka-http-10.0' include ':instrumentation:akka-http-10.0'
include ':instrumentation:apache-camel-2.20' include ':instrumentation:apache-camel-2.20'
include ':instrumentation:apache-httpasyncclient-4.0' include ':instrumentation:apache-httpasyncclient-4.0'
@ -125,7 +125,7 @@ include ':instrumentation:jsp-2.3'
include ':instrumentation:kafka-clients-0.11' include ':instrumentation:kafka-clients-0.11'
include ':instrumentation:kafka-streams-0.11' include ':instrumentation:kafka-streams-0.11'
include ':instrumentation:khttp-0.1' include ':instrumentation:khttp-0.1'
include ':instrumentation:kotlin-coroutines' include ':instrumentation:kotlinx-coroutines'
include ':instrumentation:kubernetes-client-7.0' include ':instrumentation:kubernetes-client-7.0'
include ':instrumentation:lettuce:lettuce-common' include ':instrumentation:lettuce:lettuce-common'
include ':instrumentation:lettuce:lettuce-4.0' include ':instrumentation:lettuce:lettuce-4.0'
@ -169,7 +169,7 @@ include ':instrumentation:redisson-3.0'
include ':instrumentation:rmi' include ':instrumentation:rmi'
include ':instrumentation:rxjava-1.0' include ':instrumentation:rxjava-1.0'
include ':instrumentation:rxjava-1.0' include ':instrumentation:rxjava-1.0'
include ':instrumentation:scala-concurrent' include ':instrumentation:scala-executors'
include ':instrumentation:servlet:glassfish-testing' include ':instrumentation:servlet:glassfish-testing'
include ':instrumentation:servlet:servlet-common' include ':instrumentation:servlet:servlet-common'
include ':instrumentation:servlet:servlet-2.2' include ':instrumentation:servlet:servlet-2.2'