From 2c044253e80c2f0cce9514de69e454bffcff3426 Mon Sep 17 00:00:00 2001 From: Trask Stalnaker Date: Wed, 8 Sep 2021 07:55:21 -0700 Subject: [PATCH] HttpURLConnection response code edge case (#4062) --- .../HttpUrlConnectionInstrumentation.java | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/instrumentation/http-url-connection/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/httpurlconnection/HttpUrlConnectionInstrumentation.java b/instrumentation/http-url-connection/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/httpurlconnection/HttpUrlConnectionInstrumentation.java index f02bb0f7fa..c12f876ff8 100644 --- a/instrumentation/http-url-connection/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/httpurlconnection/HttpUrlConnectionInstrumentation.java +++ b/instrumentation/http-url-connection/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/httpurlconnection/HttpUrlConnectionInstrumentation.java @@ -124,7 +124,12 @@ public class HttpUrlConnectionInstrumentation implements TypeInstrumentation { // to be consistent with the telemetry for other http clients. instrumenter().end(httpUrlState.context, connection, responseCode, null); } else { - instrumenter().end(httpUrlState.context, connection, null, throwable); + instrumenter() + .end( + httpUrlState.context, + connection, + responseCode > 0 ? responseCode : null, + throwable); } httpUrlState.finished = true; } else if (methodName.equals("getInputStream") && responseCode > 0) {