open-telemetry
/
opentelemetry-java-instrumentation
mirror of https://github.com/open-telemetry/opentelemetry-java-instrumentation.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Add a comment for a special case to this netty version

This commit is contained in:
Brian Devins-Suresh 2020-03-20 05:45:09 -04:00
parent baf02ff526
commit 2d84dd7eec
1 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
dd-java-agent/instrumentation/netty-3.9/src/main/java/datadog/trace/instrumentation/netty39/NettyChannelPipelineInstrumentation.java
View File

@ -147,6 +147,9 @@ public class NettyChannelPipelineInstrumentation extends Instrumenter.Default {
public static int checkDepth( public static int checkDepth(
@Advice.This final ChannelPipeline pipeline, @Advice.This final ChannelPipeline pipeline,
@Advice.Argument(1) final ChannelHandler handler) { @Advice.Argument(1) final ChannelHandler handler) {
// Pipelines are created once as a factory and then copied multiple times using the same add
// methods as we are hooking. If our handler has already been added we need to remove it so we
// don't end up with duplicates (this throws an exception)
if (pipeline.get(handler.getClass().getName()) != null) { if (pipeline.get(handler.getClass().getName()) != null) {
pipeline.remove(handler.getClass().getName()); pipeline.remove(handler.getClass().getName());
} }
@ -174,6 +177,9 @@ public class NettyChannelPipelineInstrumentation extends Instrumenter.Default {
public static int checkDepth( public static int checkDepth(
@Advice.This final ChannelPipeline pipeline, @Advice.This final ChannelPipeline pipeline,
@Advice.Argument(2) final ChannelHandler handler) { @Advice.Argument(2) final ChannelHandler handler) {
// Pipelines are created once as a factory and then copied multiple times using the same add
// methods as we are hooking. If our handler has already been added we need to remove it so we
// don't end up with duplicates (this throws an exception)
if (pipeline.get(handler.getClass().getName()) != null) { if (pipeline.get(handler.getClass().getName()) != null) {
pipeline.remove(handler.getClass().getName()); pipeline.remove(handler.getClass().getName());
} }