From 2f0364e78dc8b77a56a592056ed358717bd50c00 Mon Sep 17 00:00:00 2001 From: Lauri Tulmin Date: Thu, 19 Sep 2024 13:12:06 +0300 Subject: [PATCH] Replace field with local variable in grizzly test (#12297) --- .../grizzly/GrizzlyFilterchainServerTest.java | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/instrumentation/grizzly-2.3/javaagent/src/test/java/io/opentelemetry/javaagent/instrumentation/grizzly/GrizzlyFilterchainServerTest.java b/instrumentation/grizzly-2.3/javaagent/src/test/java/io/opentelemetry/javaagent/instrumentation/grizzly/GrizzlyFilterchainServerTest.java index 0e6705839e..37bc838b8d 100644 --- a/instrumentation/grizzly-2.3/javaagent/src/test/java/io/opentelemetry/javaagent/instrumentation/grizzly/GrizzlyFilterchainServerTest.java +++ b/instrumentation/grizzly-2.3/javaagent/src/test/java/io/opentelemetry/javaagent/instrumentation/grizzly/GrizzlyFilterchainServerTest.java @@ -50,12 +50,10 @@ class GrizzlyFilterchainServerTest extends AbstractHttpServerTest { @RegisterExtension static final InstrumentationExtension testing = HttpServerInstrumentationExtension.forAgent(); - private TCPNIOTransport transport; - @Override protected Transport setupServer() throws Exception { FilterChain filterChain = setUpFilterChain(); - setUpTransport(filterChain); + TCPNIOTransport transport = setUpTransport(filterChain); transport.bind("127.0.0.1", port); transport.start(); @@ -88,7 +86,7 @@ class GrizzlyFilterchainServerTest extends AbstractHttpServerTest { options.setTestErrorBody(false); } - private void setUpTransport(FilterChain filterChain) { + private static TCPNIOTransport setUpTransport(FilterChain filterChain) { TCPNIOTransportBuilder transportBuilder = TCPNIOTransportBuilder.newInstance().setOptimizedForMultiplexing(true); @@ -98,8 +96,10 @@ class GrizzlyFilterchainServerTest extends AbstractHttpServerTest { transportBuilder.setServerConnectionBackLog(50); transportBuilder.setServerSocketSoTimeout(80000); - transport = transportBuilder.build(); + TCPNIOTransport transport = transportBuilder.build(); transport.setProcessor(filterChain); + + return transport; } @SuppressWarnings(