open-telemetry
/
opentelemetry-java-instrumentation
mirror of https://github.com/open-telemetry/opentelemetry-java-instrumentation.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix another reverse lookup (#5393) 

* Fix another reverse lookup

* Update tests to verify NET_PEER_NAME is never captured for http server spans

* Revert "Update tests to verify NET_PEER_NAME is never captured for http server spans"

This reverts commit 44c9e91048.
This commit is contained in:
Trask Stalnaker 2022-02-18 08:54:08 -08:00 committed by GitHub
parent 698503cbec
commit 2f5e1f0703
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
instrumentation/tomcat/tomcat-common/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/tomcat/common/TomcatNetAttributesGetter.java
View File

@ -22,8 +22,9 @@ public class TomcatNetAttributesGetter implements NetServerAttributesGetter<Requ
@Override
@Nullable
public String peerName(Request request) {
request.action(ActionCode.REQ_HOST_ATTRIBUTE, request);
return request.remoteHost().toString();
// not using request.action(ActionCode.REQ_HOST_ATTRIBUTE, request) since that calls
// InetAddress.getHostName() which trigger reverse name lookup
return null;
}
@Override