From 2e9b20ceb585476fd8dc090f6e9b239cf967c9af Mon Sep 17 00:00:00 2001 From: Nikolay Martynov Date: Wed, 5 Dec 2018 11:53:19 -0500 Subject: [PATCH] Remove unused variable from AsyncChild classes --- .../scala-testing/src/test/java/AsyncChild.java | 13 +++---------- .../java-concurrent/src/test/java/AsyncChild.java | 11 ++--------- 2 files changed, 5 insertions(+), 19 deletions(-) diff --git a/dd-java-agent/instrumentation/java-concurrent/scala-testing/src/test/java/AsyncChild.java b/dd-java-agent/instrumentation/java-concurrent/scala-testing/src/test/java/AsyncChild.java index 8d8746be2d..17a398bf64 100644 --- a/dd-java-agent/instrumentation/java-concurrent/scala-testing/src/test/java/AsyncChild.java +++ b/dd-java-agent/instrumentation/java-concurrent/scala-testing/src/test/java/AsyncChild.java @@ -1,18 +1,16 @@ import datadog.trace.api.Trace; import java.util.concurrent.Callable; import java.util.concurrent.atomic.AtomicBoolean; -import java.util.concurrent.atomic.AtomicInteger; public class AsyncChild implements Runnable, Callable { private final AtomicBoolean blockThread; private final boolean doTraceableWork; - private final AtomicInteger numberOfWorkers = new AtomicInteger(0); public AsyncChild() { this(true, false); } - public AsyncChild(boolean doTraceableWork, boolean blockThread) { + public AsyncChild(final boolean doTraceableWork, final boolean blockThread) { this.doTraceableWork = doTraceableWork; this.blockThread = new AtomicBoolean(blockThread); } @@ -36,13 +34,8 @@ public class AsyncChild implements Runnable, Callable { if (doTraceableWork) { asyncChild(); } - numberOfWorkers.getAndIncrement(); - try { - while (blockThread.get()) { - // busy-wait to block thread - } - } finally { - numberOfWorkers.getAndDecrement(); + while (blockThread.get()) { + // busy-wait to block thread } } diff --git a/dd-java-agent/instrumentation/java-concurrent/src/test/java/AsyncChild.java b/dd-java-agent/instrumentation/java-concurrent/src/test/java/AsyncChild.java index 7da76e3c88..17a398bf64 100644 --- a/dd-java-agent/instrumentation/java-concurrent/src/test/java/AsyncChild.java +++ b/dd-java-agent/instrumentation/java-concurrent/src/test/java/AsyncChild.java @@ -1,12 +1,10 @@ import datadog.trace.api.Trace; import java.util.concurrent.Callable; import java.util.concurrent.atomic.AtomicBoolean; -import java.util.concurrent.atomic.AtomicInteger; public class AsyncChild implements Runnable, Callable { private final AtomicBoolean blockThread; private final boolean doTraceableWork; - private final AtomicInteger numberOfWorkers = new AtomicInteger(0); public AsyncChild() { this(true, false); @@ -36,13 +34,8 @@ public class AsyncChild implements Runnable, Callable { if (doTraceableWork) { asyncChild(); } - numberOfWorkers.getAndIncrement(); - try { - while (blockThread.get()) { - // busy-wait to block thread - } - } finally { - numberOfWorkers.getAndDecrement(); + while (blockThread.get()) { + // busy-wait to block thread } }