From 3db872e50fd1e59f9182a7191542b918e120cc6e Mon Sep 17 00:00:00 2001 From: Nikita Salnikov-Tarnovski Date: Mon, 26 Oct 2020 13:49:25 +0200 Subject: [PATCH] Fix net.peer.* setting for Cassandra 4.+ (#1482) --- .../cassandra/v4_0/CassandraDatabaseClientTracer.java | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/instrumentation/cassandra/cassandra-4.0/src/main/java/io/opentelemetry/javaagent/instrumentation/cassandra/v4_0/CassandraDatabaseClientTracer.java b/instrumentation/cassandra/cassandra-4.0/src/main/java/io/opentelemetry/javaagent/instrumentation/cassandra/v4_0/CassandraDatabaseClientTracer.java index b463d6b33f..d276dfc280 100644 --- a/instrumentation/cassandra/cassandra-4.0/src/main/java/io/opentelemetry/javaagent/instrumentation/cassandra/v4_0/CassandraDatabaseClientTracer.java +++ b/instrumentation/cassandra/cassandra-4.0/src/main/java/io/opentelemetry/javaagent/instrumentation/cassandra/v4_0/CassandraDatabaseClientTracer.java @@ -14,7 +14,7 @@ import io.opentelemetry.instrumentation.api.tracer.utils.NetPeerUtils; import io.opentelemetry.javaagent.instrumentation.api.db.DbSystem; import io.opentelemetry.trace.Span; import java.net.InetSocketAddress; -import java.util.Optional; +import java.net.SocketAddress; public class CassandraDatabaseClientTracer extends DatabaseClientTracer { public static final CassandraDatabaseClientTracer TRACER = new CassandraDatabaseClientTracer(); @@ -47,8 +47,10 @@ public class CassandraDatabaseClientTracer extends DatabaseClientTracer address = coordinator.getBroadcastRpcAddress(); - address.ifPresent(inetSocketAddress -> NetPeerUtils.setNetPeer(span, inetSocketAddress)); + SocketAddress socketAddress = coordinator.getEndPoint().resolve(); + if (socketAddress instanceof InetSocketAddress) { + NetPeerUtils.setNetPeer(span, ((InetSocketAddress) socketAddress)); + } } } }