From 465e2375222da7d25dbac893ca55b98a39d94f52 Mon Sep 17 00:00:00 2001 From: Nikolay Martynov Date: Thu, 15 Nov 2018 12:32:11 -0500 Subject: [PATCH] Do not set component in AWS instrumentation that later get rewritten anyway --- .../trace/instrumentation/aws/v0/TracingRequestHandler.java | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/dd-java-agent/instrumentation/aws-java-sdk-1.11.0/src/main/java/datadog/trace/instrumentation/aws/v0/TracingRequestHandler.java b/dd-java-agent/instrumentation/aws-java-sdk-1.11.0/src/main/java/datadog/trace/instrumentation/aws/v0/TracingRequestHandler.java index 8f9be7fc60..cf3d3d8763 100644 --- a/dd-java-agent/instrumentation/aws-java-sdk-1.11.0/src/main/java/datadog/trace/instrumentation/aws/v0/TracingRequestHandler.java +++ b/dd-java-agent/instrumentation/aws-java-sdk-1.11.0/src/main/java/datadog/trace/instrumentation/aws/v0/TracingRequestHandler.java @@ -56,11 +56,9 @@ public class TracingRequestHandler extends RequestHandler2 { /** {@inheritDoc} */ @Override public void beforeRequest(final Request request) { + // Note: not setting Component tag here because it is always set by SpanDecorator final Tracer.SpanBuilder spanBuilder = - tracer - .buildSpan("aws.command") - .withTag(Tags.COMPONENT.getKey(), "aws-sdk") - .withTag(Tags.SPAN_KIND.getKey(), Tags.SPAN_KIND_CLIENT); + tracer.buildSpan("aws.command").withTag(Tags.SPAN_KIND.getKey(), Tags.SPAN_KIND_CLIENT); if (parentContext != null) { spanBuilder.asChildOf(parentContext);