open-telemetry
/
opentelemetry-java-instrumentation
mirror of https://github.com/open-telemetry/opentelemetry-java-instrumentation.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Replace junit4 @Test annotation with junit5 annotation (#11745)

This commit is contained in:
Lauri Tulmin 2024-07-05 16:38:54 +03:00 committed by GitHub
parent 4597d716f4
commit 47bb31dc99
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 14 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
instrumentation/aws-sdk/aws-sdk-2.2/library/src/test/java/io/opentelemetry/instrumentation/awssdk/v2_2/FieldMapperTest.java
View File

@ -16,7 +16,7 @@ import io.opentelemetry.api.trace.Span;
import java.util.Collection; import java.util.Collection;
import java.util.HashMap; import java.util.HashMap;
import java.util.Map; import java.util.Map;
import org.junit.Test; import org.junit.jupiter.api.Test;
import software.amazon.awssdk.services.dynamodb.model.BatchWriteItemRequest; import software.amazon.awssdk.services.dynamodb.model.BatchWriteItemRequest;
import software.amazon.awssdk.services.dynamodb.model.BatchWriteItemResponse; import software.amazon.awssdk.services.dynamodb.model.BatchWriteItemResponse;
import software.amazon.awssdk.services.dynamodb.model.ConsumedCapacity; import software.amazon.awssdk.services.dynamodb.model.ConsumedCapacity;
@ -25,11 +25,10 @@ import software.amazon.awssdk.services.dynamodb.model.ProvisionedThroughput;
import software.amazon.awssdk.services.dynamodb.model.UpdateTableRequest; import software.amazon.awssdk.services.dynamodb.model.UpdateTableRequest;
import software.amazon.awssdk.services.dynamodb.model.WriteRequest; import software.amazon.awssdk.services.dynamodb.model.WriteRequest;
public class FieldMapperTest { class FieldMapperTest {
@Test @Test
public void shouldMapNestedField() { void shouldMapNestedField() {
// given // given
AwsSdkRequest awsSdkRequest = UpdateTable; AwsSdkRequest awsSdkRequest = UpdateTable;
MethodHandleFactory methodHandleFactory = new MethodHandleFactory(); MethodHandleFactory methodHandleFactory = new MethodHandleFactory();
@ -56,8 +55,7 @@ public class FieldMapperTest {
} }
@Test @Test
public void shouldMapRequestFieldsOnly() { void shouldMapRequestFieldsOnly() {
// given // given
AwsSdkRequest awsSdkRequest = BatchWriteItem; AwsSdkRequest awsSdkRequest = BatchWriteItem;
MethodHandleFactory methodHandleFactory = new MethodHandleFactory(); MethodHandleFactory methodHandleFactory = new MethodHandleFactory();
@ -76,8 +74,7 @@ public class FieldMapperTest {
} }
@Test @Test
public void shouldMapResponseFieldsOnly() { void shouldMapResponseFieldsOnly() {
// given // given
AwsSdkRequest awsSdkRequest = BatchWriteItem; AwsSdkRequest awsSdkRequest = BatchWriteItem;
MethodHandleFactory methodHandleFactory = new MethodHandleFactory(); MethodHandleFactory methodHandleFactory = new MethodHandleFactory();

3
instrumentation/aws-sdk/aws-sdk-2.2/library/src/test/java/io/opentelemetry/instrumentation/awssdk/v2_2/QueryProtocolModelTest.java
View File

@ -12,7 +12,8 @@ import software.amazon.awssdk.core.client.config.ClientOverrideConfiguration;
class QueryProtocolModelTest extends AbstractQueryProtocolModelTest { class QueryProtocolModelTest extends AbstractQueryProtocolModelTest {
@RegisterExtension @RegisterExtension
public final LibraryInstrumentationExtension testing = LibraryInstrumentationExtension.create(); private static final LibraryInstrumentationExtension testing =
LibraryInstrumentationExtension.create();
@Override @Override
protected ClientOverrideConfiguration.Builder createClientOverrideConfigurationBuilder() { protected ClientOverrideConfiguration.Builder createClientOverrideConfigurationBuilder() {

14
instrumentation/aws-sdk/aws-sdk-2.2/library/src/test/java/io/opentelemetry/instrumentation/awssdk/v2_2/SerializerTest.java
View File

@ -13,14 +13,14 @@ import java.util.HashMap;
import java.util.LinkedHashMap; import java.util.LinkedHashMap;
import java.util.List; import java.util.List;
import java.util.Map; import java.util.Map;
import org.junit.Test; import org.junit.jupiter.api.Test;
import software.amazon.awssdk.core.SdkPojo; import software.amazon.awssdk.core.SdkPojo;
import software.amazon.awssdk.services.dynamodb.model.ProvisionedThroughput; import software.amazon.awssdk.services.dynamodb.model.ProvisionedThroughput;
public class SerializerTest { class SerializerTest {
@Test @Test
public void shouldSerializeSimpleString() { void shouldSerializeSimpleString() {
// given // given
// when // when
String serialized = new Serializer().serialize("simpleString"); String serialized = new Serializer().serialize("simpleString");
@ -29,7 +29,7 @@ public class SerializerTest {
} }
@Test @Test
public void shouldSerializeSdkPojo() { void shouldSerializeSdkPojo() {
// given // given
SdkPojo sdkPojo = SdkPojo sdkPojo =
ProvisionedThroughput.builder().readCapacityUnits(1L).writeCapacityUnits(2L).build(); ProvisionedThroughput.builder().readCapacityUnits(1L).writeCapacityUnits(2L).build();
@ -40,7 +40,7 @@ public class SerializerTest {
} }
@Test @Test
public void shouldSerializeCollection() { void shouldSerializeCollection() {
// given // given
List<String> collection = Arrays.asList("one", "two", "three"); List<String> collection = Arrays.asList("one", "two", "three");
// when // when
@ -50,7 +50,7 @@ public class SerializerTest {
} }
@Test @Test
public void shouldSerializeEmptyCollectionAsNull() { void shouldSerializeEmptyCollectionAsNull() {
// given // given
List<String> collection = Collections.emptyList(); List<String> collection = Collections.emptyList();
// when // when
@ -60,7 +60,7 @@ public class SerializerTest {
} }
@Test @Test
public void shouldSerializeMapAsKeyCollection() { void shouldSerializeMapAsKeyCollection() {
// given // given
Map<String, Object> map = new HashMap<>(); Map<String, Object> map = new HashMap<>();
map.put("uno", 1L); map.put("uno", 1L);