open-telemetry
/
opentelemetry-java-instrumentation
mirror of https://github.com/open-telemetry/opentelemetry-java-instrumentation.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Update span types to be consistent with other tracers

This commit is contained in:
Tyler Benson 2018-07-26 16:01:27 +10:00
parent 8dd87a8d30
commit 561eb0fcd9
2 changed files with 10 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
dd-trace-api/src/main/java/datadog/trace/api/DDSpanTypes.java
View File

@ -1,13 +1,18 @@
package datadog.trace.api; package datadog.trace.api;
public class DDSpanTypes { public class DDSpanTypes {
public static final String HTTP_SERVER = "http";
public static final String HTTP_CLIENT = "http"; public static final String HTTP_CLIENT = "http";
public static final String WEB_SERVLET = "web"; public static final String WEB_SERVLET = "web";
public static final String RPC = "rpc"; public static final String RPC = "rpc";
public static final String CACHE = "cache";
public static final String SQL = "sql"; public static final String SQL = "sql";
public static final String MONGO = "mongodb"; public static final String MONGO = "mongodb";
public static final String CASSANDRA = "cassandra"; public static final String CASSANDRA = "cassandra";
public static final String REDIS = "redis";
public static final String MEMCACHED = "memcached";
public static final String ELASTICSEARCH = "elasticsearch";
public static final String MESSAGE_CONSUMER = "queue"; public static final String MESSAGE_CONSUMER = "queue";
public static final String MESSAGE_PRODUCER = "queue"; public static final String MESSAGE_PRODUCER = "queue";

9
dd-trace-ot/src/main/java/datadog/opentracing/decorators/DBTypeDecorator.java
View File

@ -1,6 +1,7 @@
package datadog.opentracing.decorators; package datadog.opentracing.decorators;
import datadog.opentracing.DDSpanContext; import datadog.opentracing.DDSpanContext;
import datadog.trace.api.DDSpanTypes;
import datadog.trace.api.DDTags; import datadog.trace.api.DDTags;
import io.opentracing.tag.Tags; import io.opentracing.tag.Tags;
@ -25,13 +26,13 @@ public class DBTypeDecorator extends AbstractDecorator {
// Special case: Mongo, set to mongodb // Special case: Mongo, set to mongodb
if ("mongo".equals(value)) { if ("mongo".equals(value)) {
// Todo: not sure it's used cos already in the agent mongo helper // Todo: not sure it's used cos already in the agent mongo helper
context.setSpanType("mongodb"); context.setSpanType(DDSpanTypes.MONGO);
} else if ("cassandra".equals(value)) { } else if ("cassandra".equals(value)) {
context.setSpanType("cassandra"); context.setSpanType(DDSpanTypes.CASSANDRA);
} else if ("memcached".equals(value)) { } else if ("memcached".equals(value)) {
context.setSpanType("cache"); context.setSpanType(DDSpanTypes.MEMCACHED);
} else { } else {
context.setSpanType("sql"); context.setSpanType(DDSpanTypes.SQL);
} }
// Works for: mongo, cassandra, jdbc // Works for: mongo, cassandra, jdbc
context.setOperationName(String.valueOf(value) + ".query"); context.setOperationName(String.valueOf(value) + ".query");