From 566ec617281bca2f9d140de8d5a3a97bebf0da87 Mon Sep 17 00:00:00 2001 From: jason plumb <75337021+breedx-splk@users.noreply.github.com> Date: Mon, 23 Aug 2021 10:56:25 -0700 Subject: [PATCH] [overhead] fix permissions issue with test results (#3888) * run as root and provide a little more timeout room * update test result data * update test result data * update test result data Co-authored-by: breedx-splk --- benchmark-overhead/results/release/results.csv | 4 ++++ benchmark-overhead/results/release/summary.txt | 17 +++++++++++++++++ .../results/snapshot-regression/results.csv | 4 ++++ .../results/snapshot-regression/summary.txt | 17 +++++++++++++++++ benchmark-overhead/results/snapshot/results.csv | 4 ++++ benchmark-overhead/results/snapshot/summary.txt | 17 +++++++++++++++++ .../opentelemetry/containers/K6Container.java | 7 ++++--- 7 files changed, 67 insertions(+), 3 deletions(-) create mode 100644 benchmark-overhead/results/release/results.csv create mode 100644 benchmark-overhead/results/release/summary.txt create mode 100644 benchmark-overhead/results/snapshot-regression/results.csv create mode 100644 benchmark-overhead/results/snapshot-regression/summary.txt create mode 100644 benchmark-overhead/results/snapshot/results.csv create mode 100644 benchmark-overhead/results/snapshot/summary.txt diff --git a/benchmark-overhead/results/release/results.csv b/benchmark-overhead/results/release/results.csv new file mode 100644 index 0000000000..51e4e9bd2c --- /dev/null +++ b/benchmark-overhead/results/release/results.csv @@ -0,0 +1,4 @@ +timestamp,latest:startupTimeMs,latest:minHeapUsed,latest:maxHeapUsed,latest:totalAllocatedMB,latest:totalGCTime,latest:maxThreadContextSwitchRate,latest:iterationAvg,latest:iterationP95,latest:requestAvg,latest:requestP95,latest:peakThreadCount,none:startupTimeMs,none:minHeapUsed,none:maxHeapUsed,none:totalAllocatedMB,none:totalGCTime,none:maxThreadContextSwitchRate,none:iterationAvg,none:iterationP95,none:requestAvg,none:requestP95,none:peakThreadCount +1629523302,15423,65011712,379882496,14817.57640838623,1970509155,39813.44,124.03029416000024,192.06150875,9.153639939055589,28.654695,46,13671,49807360,253623808,9782.304428100586,1744148166,36498.2,117.4539864234003,193.54589740000003,8.739646627666668,27.172226850000033,40 +1629609841,16368,62914560,379060224,14980.932846069336,1957367119,38207.1,127.34158357259976,197.05194515,9.376904915933446,29.193523150000004,46,13747,49283072,255251968,9640.229476928711,1839414632,34709.8,123.23323700399986,210.06554905000004,9.141136852911105,28.733041050000004,41 +1629696213,17898,63406592,354418688,14847.207527160645,2236987332,36178.8,136.82131952279988,219.70631450000002,10.054132867544576,31.83805915,48,14984,56623104,256304128,9465.193664550781,1891923844,36829.7,129.7720654628005,225.07373530000007,9.669844519011013,30.189436900000004,40 diff --git a/benchmark-overhead/results/release/summary.txt b/benchmark-overhead/results/release/summary.txt new file mode 100644 index 0000000000..487518eb08 --- /dev/null +++ b/benchmark-overhead/results/release/summary.txt @@ -0,0 +1,17 @@ +---------------------------------------------------------- + Run at Mon Aug 23 05:23:33 UTC 2021 + release : compares the latest stable release to no agent + 5 users, 5000 iterations +---------------------------------------------------------- +Agent : latest none +Startup time (ms) : 17898 14984 +Total allocated MB : 14847.21 9465.19 +Heap (min) : 63406592 56623104 +Heap (max) : 354418688 256304128 +Thread switch rate : 36178.8 36829.7 +GC time : 2236987332 1891923844 +Req. mean : 10.05 9.67 +Req. p95 : 31.84 30.19 +Iter. mean : 136.82 129.77 +Iter. p95 : 219.71 225.07 +Peak threads : 48 40 diff --git a/benchmark-overhead/results/snapshot-regression/results.csv b/benchmark-overhead/results/snapshot-regression/results.csv new file mode 100644 index 0000000000..f4648ae08e --- /dev/null +++ b/benchmark-overhead/results/snapshot-regression/results.csv @@ -0,0 +1,4 @@ +timestamp,latest:startupTimeMs,latest:minHeapUsed,latest:maxHeapUsed,latest:totalAllocatedMB,latest:totalGCTime,latest:maxThreadContextSwitchRate,latest:iterationAvg,latest:iterationP95,latest:requestAvg,latest:requestP95,latest:peakThreadCount,snapshot:startupTimeMs,snapshot:minHeapUsed,snapshot:maxHeapUsed,snapshot:totalAllocatedMB,snapshot:totalGCTime,snapshot:maxThreadContextSwitchRate,snapshot:iterationAvg,snapshot:iterationP95,snapshot:requestAvg,snapshot:requestP95,snapshot:peakThreadCount +1629524039,15137,62764544,292714496,14961.89234161377,2426467878,37606.84,124.49783342839969,195.58417200000002,9.14865907544451,28.833727050000004,47,15353,65508864,352754176,14629.042739868164,1933721577,34286.4,122.5971177362004,190.21387735000002,9.015280540911023,28.086541600000004,46 +1629610609,16525,67555840,365829120,14640.906295776367,1925267662,35109.82,127.9748868862001,203.04448250000002,9.4256748516,29.516775000000003,47,16672,62142976,305790464,14665.66056060791,2445394909,36501.8,130.12268295500022,207.25601799999998,9.603572605444535,30.50619900000003,47 +1629697027,18379,61341696,320497664,15030.382804870605,2707956726,31842.994,144.4205029966004,228.77327879999999,10.641616290500012,33.989557050000016,48,16547,63963136,347695616,14560.818649291992,2247842953,39058.863,137.42310366759975,215.33690965,10.12712858276665,31.56386445,48 diff --git a/benchmark-overhead/results/snapshot-regression/summary.txt b/benchmark-overhead/results/snapshot-regression/summary.txt new file mode 100644 index 0000000000..8ad6afcc65 --- /dev/null +++ b/benchmark-overhead/results/snapshot-regression/summary.txt @@ -0,0 +1,17 @@ +---------------------------------------------------------- + Run at Mon Aug 23 05:37:07 UTC 2021 + snapshot-regression : compares the latest snapshot to the latest stable release + 5 users, 5000 iterations +---------------------------------------------------------- +Agent : latest snapshot +Startup time (ms) : 18379 16547 +Total allocated MB : 15030.38 14560.82 +Heap (min) : 61341696 63963136 +Heap (max) : 320497664 347695616 +Thread switch rate : 31842.994 39058.863 +GC time : 2707956726 2247842953 +Req. mean : 10.64 10.13 +Req. p95 : 33.99 31.56 +Iter. mean : 144.42 137.42 +Iter. p95 : 228.77 215.34 +Peak threads : 48 48 diff --git a/benchmark-overhead/results/snapshot/results.csv b/benchmark-overhead/results/snapshot/results.csv new file mode 100644 index 0000000000..8ff47c1609 --- /dev/null +++ b/benchmark-overhead/results/snapshot/results.csv @@ -0,0 +1,4 @@ +timestamp,none:startupTimeMs,none:minHeapUsed,none:maxHeapUsed,none:totalAllocatedMB,none:totalGCTime,none:maxThreadContextSwitchRate,none:iterationAvg,none:iterationP95,none:requestAvg,none:requestP95,none:peakThreadCount,snapshot:startupTimeMs,snapshot:minHeapUsed,snapshot:maxHeapUsed,snapshot:totalAllocatedMB,snapshot:totalGCTime,snapshot:maxThreadContextSwitchRate,snapshot:iterationAvg,snapshot:iterationP95,snapshot:requestAvg,snapshot:requestP95,snapshot:peakThreadCount +1629523664,8651,57147392,263586304,9643.637176513672,1622332244,39076.3,117.43120787140022,200.65121405,8.7195773352111,27.55909005000003,41,15267,66584576,325196288,14734.707290649414,2307639736,38325.04,124.92777602399993,194.42115505,9.28478082983333,29.83340700000003,47 +1629610221,9845,54525952,275775488,9749.956314086914,1670595277,37232.1,123.97958917520006,216.38535765000003,9.195022611266712,29.06991295,41,16512,67265024,306098688,15137.290794372559,2447837459,36117.91,130.58804246579993,204.32761200000002,9.64791714134449,30.95108965000001,47 +1629696609,9833,49180160,253755392,9680.444984436035,1986453613,33831.2,130.51002116659967,220.7256701,9.661561589033333,29.94263695,40,17431,61856256,317718528,14607.608840942383,2477043679,34800.2,142.3983490810001,218.82883030000002,10.482793739411076,33.17418600000001,47 diff --git a/benchmark-overhead/results/snapshot/summary.txt b/benchmark-overhead/results/snapshot/summary.txt new file mode 100644 index 0000000000..d2b9bfdd0e --- /dev/null +++ b/benchmark-overhead/results/snapshot/summary.txt @@ -0,0 +1,17 @@ +---------------------------------------------------------- + Run at Mon Aug 23 05:30:09 UTC 2021 + snapshot : compares the latest snapshot to no agent + 5 users, 5000 iterations +---------------------------------------------------------- +Agent : none snapshot +Startup time (ms) : 9833 17431 +Total allocated MB : 9680.44 14607.61 +Heap (min) : 49180160 61856256 +Heap (max) : 253755392 317718528 +Thread switch rate : 33831.2 34800.2 +GC time : 1986453613 2477043679 +Req. mean : 9.66 10.48 +Req. p95 : 29.94 33.17 +Iter. mean : 130.51 142.40 +Iter. p95 : 220.73 218.83 +Peak threads : 40 47 diff --git a/benchmark-overhead/src/test/java/io/opentelemetry/containers/K6Container.java b/benchmark-overhead/src/test/java/io/opentelemetry/containers/K6Container.java index ecfadba4b3..3b0b286a34 100644 --- a/benchmark-overhead/src/test/java/io/opentelemetry/containers/K6Container.java +++ b/benchmark-overhead/src/test/java/io/opentelemetry/containers/K6Container.java @@ -7,6 +7,8 @@ package io.opentelemetry.containers; import io.opentelemetry.agents.Agent; import io.opentelemetry.config.TestConfig; import io.opentelemetry.util.NamingConventions; +import java.nio.file.Path; +import java.time.Duration; import org.slf4j.Logger; import org.slf4j.LoggerFactory; import org.testcontainers.containers.GenericContainer; @@ -15,8 +17,6 @@ import org.testcontainers.containers.output.Slf4jLogConsumer; import org.testcontainers.containers.startupcheck.OneShotStartupCheckStrategy; import org.testcontainers.utility.DockerImageName; import org.testcontainers.utility.MountableFile; -import java.nio.file.Path; -import java.time.Duration; public class K6Container { private static final Logger logger = LoggerFactory.getLogger(K6Container.class); @@ -42,6 +42,7 @@ public class K6Container { .withCopyFileToContainer( MountableFile.forHostPath("./k6"), "/app") .withFileSystemBind(namingConventions.localResults(), namingConventions.containerResults()) + .withCreateContainerCmdModifier(cmd -> cmd.withUser("root")) .withCommand( "run", "-u", String.valueOf(config.getConcurrentConnections()), @@ -51,7 +52,7 @@ public class K6Container { "/app/basic.js" ) .withStartupCheckStrategy( - new OneShotStartupCheckStrategy().withTimeout(Duration.ofMinutes(5)) + new OneShotStartupCheckStrategy().withTimeout(Duration.ofMinutes(15)) ); } }