diff --git a/instrumentation/vertx-reactive-3.5/javaagent/src/test/groovy/server/VertxRxCircuitBreakerHttpServerTest.groovy b/instrumentation/vertx-reactive-3.5/javaagent/src/test/groovy/server/VertxRxCircuitBreakerHttpServerTest.groovy index a0ed592b0d..3d636bda83 100644 --- a/instrumentation/vertx-reactive-3.5/javaagent/src/test/groovy/server/VertxRxCircuitBreakerHttpServerTest.groovy +++ b/instrumentation/vertx-reactive-3.5/javaagent/src/test/groovy/server/VertxRxCircuitBreakerHttpServerTest.groovy @@ -126,4 +126,9 @@ class VertxRxCircuitBreakerHttpServerTest extends VertxRxHttpServerTest { .listen(port) { startFuture.complete() } } } + + @Override + boolean hasExceptionOnServerSpan(HttpServerTest.ServerEndpoint endpoint) { + return endpoint != EXCEPTION && super.hasExceptionOnServerSpan(endpoint) + } } diff --git a/instrumentation/vertx-reactive-3.5/javaagent/src/test/groovy/server/VertxRxHttpServerTest.groovy b/instrumentation/vertx-reactive-3.5/javaagent/src/test/groovy/server/VertxRxHttpServerTest.groovy index bb16589732..a92c30e868 100644 --- a/instrumentation/vertx-reactive-3.5/javaagent/src/test/groovy/server/VertxRxHttpServerTest.groovy +++ b/instrumentation/vertx-reactive-3.5/javaagent/src/test/groovy/server/VertxRxHttpServerTest.groovy @@ -7,6 +7,7 @@ package server import static io.opentelemetry.instrumentation.test.base.HttpServerTest.ServerEndpoint.ERROR import static io.opentelemetry.instrumentation.test.base.HttpServerTest.ServerEndpoint.EXCEPTION +import static io.opentelemetry.instrumentation.test.base.HttpServerTest.ServerEndpoint.NOT_FOUND import static io.opentelemetry.instrumentation.test.base.HttpServerTest.ServerEndpoint.PATH_PARAM import static io.opentelemetry.instrumentation.test.base.HttpServerTest.ServerEndpoint.QUERY_PARAM import static io.opentelemetry.instrumentation.test.base.HttpServerTest.ServerEndpoint.REDIRECT @@ -53,25 +54,21 @@ class VertxRxHttpServerTest extends HttpServerTest implements AgentTestTr server.close() } - @Override - boolean testException() { - // https://github.com/open-telemetry/opentelemetry-java-instrumentation/issues/807 - return false - } - @Override boolean testPathParam() { return true } - @Override - boolean testNotFound() { - return false - } - @Override String expectedServerSpanName(ServerEndpoint endpoint) { - return endpoint == PATH_PARAM ? "/path/:id/param" : endpoint.getPath() + switch (endpoint) { + case PATH_PARAM: + return "/path/:id/param" + case NOT_FOUND: + return "HTTP GET" + default: + return endpoint.getPath() + } } protected Class verticle() { diff --git a/instrumentation/vertx-web-3.0/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/vertx/RoutingContextHandlerWrapper.java b/instrumentation/vertx-web-3.0/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/vertx/RoutingContextHandlerWrapper.java index 2a3ab7522e..733e80f778 100644 --- a/instrumentation/vertx-web-3.0/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/vertx/RoutingContextHandlerWrapper.java +++ b/instrumentation/vertx-web-3.0/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/vertx/RoutingContextHandlerWrapper.java @@ -10,6 +10,10 @@ import io.opentelemetry.context.Context; import io.opentelemetry.instrumentation.api.tracer.ServerSpan; import io.vertx.core.Handler; import io.vertx.ext.web.RoutingContext; +import java.lang.reflect.InvocationTargetException; +import java.lang.reflect.UndeclaredThrowableException; +import java.util.concurrent.CompletionException; +import java.util.concurrent.ExecutionException; import org.slf4j.Logger; import org.slf4j.LoggerFactory; @@ -26,8 +30,8 @@ public final class RoutingContextHandlerWrapper implements Handler implements AgentTestTrai server.close() } - @Override - boolean testException() { - // TODO(anuraaga): https://github.com/open-telemetry/opentelemetry-java-instrumentation/issues/807 - return false - } - @Override boolean testPathParam() { return true } - @Override - boolean testNotFound() { - return false - } - @Override boolean testConcurrency() { return true @@ -71,7 +61,14 @@ class VertxHttpServerTest extends HttpServerTest implements AgentTestTrai @Override String expectedServerSpanName(ServerEndpoint endpoint) { - return endpoint == PATH_PARAM ? "/path/:id/param" : endpoint.getPath() + switch (endpoint) { + case PATH_PARAM: + return "/path/:id/param" + case NOT_FOUND: + return "HTTP GET" + default: + return endpoint.getPath() + } } }