From 5b88f1bf050764815da7b88f7927e93d4ec40ae8 Mon Sep 17 00:00:00 2001 From: Trask Stalnaker Date: Sat, 20 Nov 2021 00:56:59 -0800 Subject: [PATCH] Fix ratpack test latest deps (#4679) --- instrumentation/ratpack-1.4/library/build.gradle.kts | 2 ++ instrumentation/ratpack-1.4/testing/build.gradle.kts | 6 ++++-- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/instrumentation/ratpack-1.4/library/build.gradle.kts b/instrumentation/ratpack-1.4/library/build.gradle.kts index 5d42899595..e8c8465db6 100644 --- a/instrumentation/ratpack-1.4/library/build.gradle.kts +++ b/instrumentation/ratpack-1.4/library/build.gradle.kts @@ -7,6 +7,8 @@ dependencies { library("io.ratpack:ratpack-core:1.4.0") testImplementation(project(":instrumentation:ratpack-1.4:testing")) + + testLibrary("io.ratpack:ratpack-test:1.4.0") testLibrary("io.ratpack:ratpack-guice:1.4.0") if (JavaVersion.current().isCompatibleWith(JavaVersion.VERSION_11)) { diff --git a/instrumentation/ratpack-1.4/testing/build.gradle.kts b/instrumentation/ratpack-1.4/testing/build.gradle.kts index 7eb81f3189..cc327478e2 100644 --- a/instrumentation/ratpack-1.4/testing/build.gradle.kts +++ b/instrumentation/ratpack-1.4/testing/build.gradle.kts @@ -5,8 +5,10 @@ plugins { dependencies { api(project(":testing-common")) - api("io.ratpack:ratpack-core:1.4.0") - api("io.ratpack:ratpack-test:1.4.0") + // it's important for these to not be api dependencies, because api dependencies pull in their + // transitive dependencies as well, which causes issues for testLatestDep + implementation("io.ratpack:ratpack-core:1.4.0") + implementation("io.ratpack:ratpack-test:1.4.0") implementation("org.codehaus.groovy:groovy-all") implementation("io.opentelemetry:opentelemetry-api")