From ae3b189ae62ffcd892b2327d9bae0fb3d2e18976 Mon Sep 17 00:00:00 2001 From: Laplie Anderson Date: Mon, 20 Apr 2020 17:59:15 -0400 Subject: [PATCH 1/2] Handle pagination when updating issues --- .github/workflows/update-issues-on-release.yaml | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/.github/workflows/update-issues-on-release.yaml b/.github/workflows/update-issues-on-release.yaml index fb75dd6bc7..de6f9d5ea2 100644 --- a/.github/workflows/update-issues-on-release.yaml +++ b/.github/workflows/update-issues-on-release.yaml @@ -26,15 +26,17 @@ jobs: with: github-token: ${{secrets.GITHUB_TOKEN}} script: | - const list = await github.issues.listForRepo({ + const options = github.issues.listForRepo.endpoint.merge({ owner: context.repo.owner, repo: context.repo.repo, state: 'all', milestone: ${{steps.milestone.outputs.result}} }) + const issues = await github.paginate(options) + // Pull requests are issues so filter them out - return list.data.filter( issue => !issue["pull_request"] ) + return issues.filter( issue => !issue["pull_request"] ) - name: Comment and close issues uses: actions/github-script@0.9.0 with: @@ -55,4 +57,4 @@ jobs: issue_number: issue.number, state: 'closed' }) - } \ No newline at end of file + } From c1d71efdd021b896bc24387394afb152a1e8aea5 Mon Sep 17 00:00:00 2001 From: Laplie Anderson Date: Mon, 20 Apr 2020 18:37:44 -0400 Subject: [PATCH 2/2] Pagination issues with milestones too --- .github/workflows/update-issues-on-release.yaml | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/.github/workflows/update-issues-on-release.yaml b/.github/workflows/update-issues-on-release.yaml index de6f9d5ea2..3af1dbf3a4 100644 --- a/.github/workflows/update-issues-on-release.yaml +++ b/.github/workflows/update-issues-on-release.yaml @@ -13,13 +13,15 @@ jobs: with: github-token: ${{secrets.GITHUB_TOKEN}} script: | - const milestones = await github.issues.listMilestonesForRepo({ + const options = github.issues.listMilestonesForRepo.endpoint.merge({ owner: context.repo.owner, repo: context.repo.repo, state: 'all' }) - return milestones.data.find( milestone => milestone.title == "${{github.event.release.name}}" ).number + const milestones = await github.paginate(options) + + return milestones.find( milestone => milestone.title == "${{github.event.release.name}}" ).number - name: Get issues for milestone id: issues uses: actions/github-script@0.9.0