diff --git a/instrumentation-core/servlet/src/main/java/io/opentelemetry/instrumentation/servlet/ServletHttpServerTracer.java b/instrumentation-core/servlet/src/main/java/io/opentelemetry/instrumentation/servlet/ServletHttpServerTracer.java index b63f122727..65308e23e6 100644 --- a/instrumentation-core/servlet/src/main/java/io/opentelemetry/instrumentation/servlet/ServletHttpServerTracer.java +++ b/instrumentation-core/servlet/src/main/java/io/opentelemetry/instrumentation/servlet/ServletHttpServerTracer.java @@ -30,11 +30,6 @@ import javax.servlet.http.HttpServletRequest; public abstract class ServletHttpServerTracer extends HttpServerTracer { - @Override - protected String getVersion() { - return null; - } - @Override // TODO this violates convention protected URI url(HttpServletRequest httpServletRequest) throws URISyntaxException { diff --git a/instrumentation-core/spring/spring-webmvc-3.1/src/main/java/io/opentelemetry/instrumentation/spring/webmvc/SpringWebMvcServerTracer.java b/instrumentation-core/spring/spring-webmvc-3.1/src/main/java/io/opentelemetry/instrumentation/spring/webmvc/SpringWebMvcServerTracer.java index 38cc335f43..188de53bb1 100644 --- a/instrumentation-core/spring/spring-webmvc-3.1/src/main/java/io/opentelemetry/instrumentation/spring/webmvc/SpringWebMvcServerTracer.java +++ b/instrumentation-core/spring/spring-webmvc-3.1/src/main/java/io/opentelemetry/instrumentation/spring/webmvc/SpringWebMvcServerTracer.java @@ -89,9 +89,4 @@ class SpringWebMvcServerTracer protected String getInstrumentationName() { return null; } - - @Override - protected String getVersion() { - return null; - } } diff --git a/instrumentation/akka-http-10.0/src/main/java/io/opentelemetry/instrumentation/auto/akkahttp/AkkaHttpServerTracer.java b/instrumentation/akka-http-10.0/src/main/java/io/opentelemetry/instrumentation/auto/akkahttp/AkkaHttpServerTracer.java index 54e1094e65..e665f6c9d7 100644 --- a/instrumentation/akka-http-10.0/src/main/java/io/opentelemetry/instrumentation/auto/akkahttp/AkkaHttpServerTracer.java +++ b/instrumentation/akka-http-10.0/src/main/java/io/opentelemetry/instrumentation/auto/akkahttp/AkkaHttpServerTracer.java @@ -77,11 +77,6 @@ public class AkkaHttpServerTracer return "io.opentelemetry.auto.akka-http-10.0"; } - @Override - protected String getVersion() { - return null; - } - @Override protected Integer peerPort(HttpRequest httpRequest) { return null; diff --git a/instrumentation/armeria-1.0/library/src/main/java/io/opentelemetry/instrumentation/armeria/v1_0/server/ArmeriaServerTracer.java b/instrumentation/armeria-1.0/library/src/main/java/io/opentelemetry/instrumentation/armeria/v1_0/server/ArmeriaServerTracer.java index 0598a7cdd5..8853e70290 100644 --- a/instrumentation/armeria-1.0/library/src/main/java/io/opentelemetry/instrumentation/armeria/v1_0/server/ArmeriaServerTracer.java +++ b/instrumentation/armeria-1.0/library/src/main/java/io/opentelemetry/instrumentation/armeria/v1_0/server/ArmeriaServerTracer.java @@ -46,11 +46,6 @@ public class ArmeriaServerTracer return "io.opentelemetry.armeria-1.0"; } - @Override - protected String getVersion() { - return null; - } - @Override protected Integer peerPort(ServiceRequestContext ctx) { SocketAddress socketAddress = ctx.remoteAddress(); diff --git a/instrumentation/grizzly-2.0/src/main/java/io/opentelemetry/instrumentation/auto/grizzly/GrizzlyHttpServerTracer.java b/instrumentation/grizzly-2.0/src/main/java/io/opentelemetry/instrumentation/auto/grizzly/GrizzlyHttpServerTracer.java index d84712c3d3..7bcfc0bf46 100644 --- a/instrumentation/grizzly-2.0/src/main/java/io/opentelemetry/instrumentation/auto/grizzly/GrizzlyHttpServerTracer.java +++ b/instrumentation/grizzly-2.0/src/main/java/io/opentelemetry/instrumentation/auto/grizzly/GrizzlyHttpServerTracer.java @@ -88,11 +88,6 @@ public class GrizzlyHttpServerTracer return "io.opentelemetry.auto.grizzly-2.0"; } - @Override - protected String getVersion() { - return null; - } - @Override protected Integer peerPort(HttpRequestPacket httpRequest) { return httpRequest.getRemotePort(); diff --git a/instrumentation/netty/netty-3.8/src/main/java/io/opentelemetry/instrumentation/auto/netty/v3_8/server/NettyHttpServerTracer.java b/instrumentation/netty/netty-3.8/src/main/java/io/opentelemetry/instrumentation/auto/netty/v3_8/server/NettyHttpServerTracer.java index 74c7a182db..707e2325a3 100644 --- a/instrumentation/netty/netty-3.8/src/main/java/io/opentelemetry/instrumentation/auto/netty/v3_8/server/NettyHttpServerTracer.java +++ b/instrumentation/netty/netty-3.8/src/main/java/io/opentelemetry/instrumentation/auto/netty/v3_8/server/NettyHttpServerTracer.java @@ -93,11 +93,6 @@ public class NettyHttpServerTracer return "io.opentelemetry.auto.netty-3.8"; } - @Override - protected String getVersion() { - return null; - } - @Override protected Integer peerPort(Channel channel) { SocketAddress socketAddress = channel.getRemoteAddress(); diff --git a/instrumentation/netty/netty-4.0/src/main/java/io/opentelemetry/instrumentation/auto/netty/v4_0/server/NettyHttpServerTracer.java b/instrumentation/netty/netty-4.0/src/main/java/io/opentelemetry/instrumentation/auto/netty/v4_0/server/NettyHttpServerTracer.java index 276d63a468..ffa1fe20b6 100644 --- a/instrumentation/netty/netty-4.0/src/main/java/io/opentelemetry/instrumentation/auto/netty/v4_0/server/NettyHttpServerTracer.java +++ b/instrumentation/netty/netty-4.0/src/main/java/io/opentelemetry/instrumentation/auto/netty/v4_0/server/NettyHttpServerTracer.java @@ -64,11 +64,6 @@ public class NettyHttpServerTracer return "io.opentelemetry.auto.netty-4.0"; } - @Override - protected String getVersion() { - return null; - } - @Override protected Getter getGetter() { return NettyRequestExtractAdapter.GETTER; diff --git a/instrumentation/netty/netty-4.1/src/main/java/io/opentelemetry/instrumentation/auto/netty/v4_1/server/NettyHttpServerTracer.java b/instrumentation/netty/netty-4.1/src/main/java/io/opentelemetry/instrumentation/auto/netty/v4_1/server/NettyHttpServerTracer.java index c6b1654507..afa8da997c 100644 --- a/instrumentation/netty/netty-4.1/src/main/java/io/opentelemetry/instrumentation/auto/netty/v4_1/server/NettyHttpServerTracer.java +++ b/instrumentation/netty/netty-4.1/src/main/java/io/opentelemetry/instrumentation/auto/netty/v4_1/server/NettyHttpServerTracer.java @@ -64,11 +64,6 @@ public class NettyHttpServerTracer return "io.opentelemetry.auto.netty-4.1"; } - @Override - protected String getVersion() { - return null; - } - @Override protected Getter getGetter() { return NettyRequestExtractAdapter.GETTER;